Re: [PATCH mptcp-next] mptcp: validate maxseg sockopt

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 08/05/2025 09:21, Geliang Tang wrote:
> Hi Matt,
> 
> Thanks for the review.
> 
> On Wed, 2025-04-30 at 11:42 +0200, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 30/04/2025 07:49, Geliang Tang wrote:
>>> This patch validates the newly added TCP_MAXSEG sockopt.
>>
>> If you don't mind and have access, do you mind creating a PR on
>> GitHub
>> instead please?
> 
> Here's the PR:
> 
> https://github.com/multipath-tcp/packetdrill/pull/161

Thanks, I just did a review:

  https://github.com/multipath-tcp/packetdrill/pull/161/files

(...)

> In this PR, I almost addressed all your comments above ...
> 
>> Then, if you don't mind, please also create a new subflow by
>> injecting
>> an MP_JOIN with a MSS of 1460, and check that the SYN+ACK+MP_JOIN
>> generated by the kernel has a MSS of 1000 as expected. For an
>> example,
>> check mptcp/mp_join/mp_join_server.pkt.
> 
> But I still have some problems when creating a new subflow, which will
> be added later.

Do not hesitate to share this WIP code and the error you have on the PR.
I also added a few pointers there.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.