From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5567ACD37AD for ; Fri, 15 Sep 2023 20:48:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237336AbjIOUsU (ORCPT ); Fri, 15 Sep 2023 16:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237651AbjIOUsM (ORCPT ); Fri, 15 Sep 2023 16:48:12 -0400 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F0242735 for ; Fri, 15 Sep 2023 13:47:45 -0700 (PDT) Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTP id hFDFqZIwUyYOwhFj7q0uv5; Fri, 15 Sep 2023 20:47:45 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id hFj6qfuRG7DhyhFj6qPF2G; Fri, 15 Sep 2023 20:47:44 +0000 X-Authority-Analysis: v=2.4 cv=fpfP2X0f c=1 sm=1 tr=0 ts=6504c2f0 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=KKAkSRfTAAAA:8 a=P-IC7800AAAA:8 a=sozttTNsAAAA:8 a=XYAwZIGsAAAA:8 a=JfrnYn6hAAAA:8 a=cm27Pg_UAAAA:8 a=VwQbUJbxAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=d3PnA9EDa4IxuAV0gXij:22 a=aeg5Gbbo78KNqacMgKqU:22 a=E8ToXWR_bxluHZ7gmE-Z:22 a=1CNFftbPRP8L7MoqJWF3:22 a=xmb-EsYY8bH0VWELuYED:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LbVMVYvQi67lp6PSBgdTc/MiJ1dwykFXI+Yhs9US8hw=; b=k8TcjOOcWsgmPVu/yrQnOTixIX aYUEfTiZUp4wGD5rduid+L+xWdg0wg0PKzYwAt2Doe5/d6Rmij1YBOAU4a8ZS/KYZexzswSWI/DfU zQtOJ5MgAWO8F5vJCFAU6AwoDVQSTB0Icn2yLlx+5cmfPEFxMOOmfb9lbTDuwC1hr/YIcviWthxUk 8CrEZ5Whwbi+k123CVUUdnkwTLb5Ow5dRi7HR+q2ty6iY/vB9oVI+sMXAwxagDDQh9UX1MibTZXd5 R0u1KB4BjTNlAyAbBiLpk2yheJo4Fx8VbIugzABhbBLIBDc7zTb02EtZ5G3u1YaFhTbeqq9Sl523A QGawfcow==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:57296 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qhFj4-002cc0-0V; Fri, 15 Sep 2023 15:47:42 -0500 Message-ID: Date: Fri, 15 Sep 2023 14:48:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mtd: rawnand: atmel: Annotate struct atmel_nand with __counted_by Content-Language: en-US To: Kees Cook , Tudor Ambarus Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230915201219.never.352-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230915201219.never.352-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qhFj4-002cc0-0V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:57296 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 309 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFoG7AYKTD/3faBjOWkNlbXUSFlNR1fJDW+lN4/D7ENPmPLE5TqoaZ8V1z81h9dRjy8VnPpLf2ivH9iQYxm6clkgRp77fvOdzo8K4wMnj7xL8cbD3SNi Fur/BvTOvGQqKrFksO0gszCmTqgf4KL2JoZytvELEtyCjEOQpu6a/WZCL7o66pryJhptyraVL1jPqjQZLlJlOhTIDt5JGl6yXdJUt9b8imQZ0F7wGBpJCFKq Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On 9/15/23 14:12, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct atmel_nand. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Tudor Ambarus > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Claudiu Beznea > Cc: linux-mtd@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index 3f494f7c7ecb..4cb478bbee4a 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -165,7 +165,7 @@ struct atmel_nand { > struct atmel_pmecc_user *pmecc; > struct gpio_desc *cdgpio; > int numcs; > - struct atmel_nand_cs cs[]; > + struct atmel_nand_cs cs[] __counted_by(numcs); > }; > > static inline struct atmel_nand *to_atmel_nand(struct nand_chip *chip) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACF2ACD37AC for ; Fri, 15 Sep 2023 20:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/4UjtB8LKD4JUqHWHUOLkAMVPLdum98GxQjcsb8X/ao=; b=nht+EI5Gef+8R8 fcWHxy6PdF/SQkDrixr2t9rBxEVF61CyJrJUXtaEaolDXRrFUxhnlPk1KT2lDYOWv1FYVvs+PEpUI CjHTqbT9Li5JRS1qJjAf58AO3sCzAlN01gGxkgANm3hVEDtMUtl6R0/fF4rT6Dn52OrSlXDm0TnxH jvTzMUEETh2sJWJXPCL5JUXfXXz/iWhZyv6MLV9W9YkHC/9mA9pBLTZwkVC07Mp0eG4f7uv33EmGS U2NbRW02bg2P6+m8WlBXrM+3AINV9mP/VIwlc+NUe2Irc+oVJWsjdvFgV9gUQlhawzLP0bBNVdCAh wT4NdnTtT420UjCpXpGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhFjS-00BLwK-1F; Fri, 15 Sep 2023 20:48:06 +0000 Received: from omta40.uswest2.a.cloudfilter.net ([35.89.44.39]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhFj7-00BLrZ-0f for linux-mtd@lists.infradead.org; Fri, 15 Sep 2023 20:48:01 +0000 Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTP id hFD6qkOstbK1VhFj6qlLbM; Fri, 15 Sep 2023 20:47:44 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id hFj5qZnGvn5VDhFj6qR8Vn; Fri, 15 Sep 2023 20:47:44 +0000 X-Authority-Analysis: v=2.4 cv=bOkFndyZ c=1 sm=1 tr=0 ts=6504c2f0 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=KKAkSRfTAAAA:8 a=P-IC7800AAAA:8 a=sozttTNsAAAA:8 a=XYAwZIGsAAAA:8 a=JfrnYn6hAAAA:8 a=cm27Pg_UAAAA:8 a=VwQbUJbxAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=d3PnA9EDa4IxuAV0gXij:22 a=aeg5Gbbo78KNqacMgKqU:22 a=E8ToXWR_bxluHZ7gmE-Z:22 a=1CNFftbPRP8L7MoqJWF3:22 a=xmb-EsYY8bH0VWELuYED:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LbVMVYvQi67lp6PSBgdTc/MiJ1dwykFXI+Yhs9US8hw=; b=k8TcjOOcWsgmPVu/yrQnOTixIX aYUEfTiZUp4wGD5rduid+L+xWdg0wg0PKzYwAt2Doe5/d6Rmij1YBOAU4a8ZS/KYZexzswSWI/DfU zQtOJ5MgAWO8F5vJCFAU6AwoDVQSTB0Icn2yLlx+5cmfPEFxMOOmfb9lbTDuwC1hr/YIcviWthxUk 8CrEZ5Whwbi+k123CVUUdnkwTLb5Ow5dRi7HR+q2ty6iY/vB9oVI+sMXAwxagDDQh9UX1MibTZXd5 R0u1KB4BjTNlAyAbBiLpk2yheJo4Fx8VbIugzABhbBLIBDc7zTb02EtZ5G3u1YaFhTbeqq9Sl523A QGawfcow==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:57296 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qhFj4-002cc0-0V; Fri, 15 Sep 2023 15:47:42 -0500 Message-ID: Date: Fri, 15 Sep 2023 14:48:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mtd: rawnand: atmel: Annotate struct atmel_nand with __counted_by Content-Language: en-US To: Kees Cook , Tudor Ambarus Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230915201219.never.352-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230915201219.never.352-kees@kernel.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qhFj4-002cc0-0V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:57296 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 316 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJlrZ1lL0fi9Ah3GrZ3I5KNx2TLwWmALkuPbcyGI1yVXevo4A4Dz1yVHWj6Z9jjoGox6S1wPPQYtuvCXdCgIxOwakgIn6Qwx3eA8SkEcA0MwDRK9lZMn 1NhEQIABDMnkZW+s70I3rxHlbaFincSh3/B5xZmos8uMeSGububsTVRMbsXWI/gxjnXZVSLVpKpJ8nXhRWC2jj1KIgH5hQZpX1/IpovvrX+IsNJjjo4qgFPq X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_134759_491629_15B86B8B X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 9/15/23 14:12, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct atmel_nand. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Tudor Ambarus > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Claudiu Beznea > Cc: linux-mtd@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index 3f494f7c7ecb..4cb478bbee4a 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -165,7 +165,7 @@ struct atmel_nand { > struct atmel_pmecc_user *pmecc; > struct gpio_desc *cdgpio; > int numcs; > - struct atmel_nand_cs cs[]; > + struct atmel_nand_cs cs[] __counted_by(numcs); > }; > > static inline struct atmel_nand *to_atmel_nand(struct nand_chip *chip) ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8932C46CA1 for ; Fri, 15 Sep 2023 20:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DhaST9M5v2BillGSFeNJDquMjH0tm8aspig6ddgOf54=; b=EK/oHdcAQvExsj7CMWhXhJvb16 OuuVw6+dhvx23SWIkbt04qqbv5ISNjji/EDmyQQo77Cjubvl2SnHdtVYITUghH1EtFJS6J2VnTezj bhav10koWwimf5R8jLWybWLqbAlPYCoQAYi5/nCjtHfp2MVSWuG7pPjvG99t/pgHSy3ZQj+sY4J69 z0qknse2GoOU4ISLp0/qcfQRcbtcZgqYs569xD80XPqLS4TB8LWbmHnBPYUCOjYiOn8cpqd5rJ0oB ZAkHHr8M/IiAesaLtbju9sOA1lq5TPlnvGiLMuSRBr75fWB9+YwTz/8BGX+V2GIQWQC9aXjQKTBm7 G6ni75EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhFjW-00BLxb-2m; Fri, 15 Sep 2023 20:48:10 +0000 Received: from omta40.uswest2.a.cloudfilter.net ([35.89.44.39]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhFj6-00BLrY-37 for linux-arm-kernel@lists.infradead.org; Fri, 15 Sep 2023 20:48:02 +0000 Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTP id hAOdqiyBlbK1VhFj6qlLbG; Fri, 15 Sep 2023 20:47:44 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id hFj5qEYNnp9rehFj5qaSrR; Fri, 15 Sep 2023 20:47:44 +0000 X-Authority-Analysis: v=2.4 cv=Ztv+lv3G c=1 sm=1 tr=0 ts=6504c2f0 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=KKAkSRfTAAAA:8 a=P-IC7800AAAA:8 a=sozttTNsAAAA:8 a=XYAwZIGsAAAA:8 a=JfrnYn6hAAAA:8 a=cm27Pg_UAAAA:8 a=VwQbUJbxAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=d3PnA9EDa4IxuAV0gXij:22 a=aeg5Gbbo78KNqacMgKqU:22 a=E8ToXWR_bxluHZ7gmE-Z:22 a=1CNFftbPRP8L7MoqJWF3:22 a=xmb-EsYY8bH0VWELuYED:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LbVMVYvQi67lp6PSBgdTc/MiJ1dwykFXI+Yhs9US8hw=; b=k8TcjOOcWsgmPVu/yrQnOTixIX aYUEfTiZUp4wGD5rduid+L+xWdg0wg0PKzYwAt2Doe5/d6Rmij1YBOAU4a8ZS/KYZexzswSWI/DfU zQtOJ5MgAWO8F5vJCFAU6AwoDVQSTB0Icn2yLlx+5cmfPEFxMOOmfb9lbTDuwC1hr/YIcviWthxUk 8CrEZ5Whwbi+k123CVUUdnkwTLb5Ow5dRi7HR+q2ty6iY/vB9oVI+sMXAwxagDDQh9UX1MibTZXd5 R0u1KB4BjTNlAyAbBiLpk2yheJo4Fx8VbIugzABhbBLIBDc7zTb02EtZ5G3u1YaFhTbeqq9Sl523A QGawfcow==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:57296 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qhFj4-002cc0-0V; Fri, 15 Sep 2023 15:47:42 -0500 Message-ID: Date: Fri, 15 Sep 2023 14:48:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mtd: rawnand: atmel: Annotate struct atmel_nand with __counted_by Content-Language: en-US To: Kees Cook , Tudor Ambarus References: <20230915201219.never.352-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230915201219.never.352-kees@kernel.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qhFj4-002cc0-0V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:57296 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 315 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN8ZbjkFVTX8+KOWuxaP3EsgTigDxIu0MX+u2lxLnClojYRjx16SCHv4aX2oo1TW5EGRPBrJlT+xvQooYH1qGlfN7d9dUQ3Ne5bOCJ964VPDMzJgxu+Y ehh5nl1Dxx/KpLSq1jkrJD0iyj54i9M4r0mL8cQoVeHdAEyuGAZ1ukuzdJyVGjkWgfJYOYszvIRgHJjVk7ohDZ76B9KP4CAu5j/yRZYGKCwGNirw/K0A1caM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_134759_502155_634F0BCC X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Vignesh Raghavendra , Richard Weinberger , llvm@lists.linux.dev, Nick Desaulniers , Claudiu Beznea , Nathan Chancellor , Tom Rix , linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org, Miquel Raynal , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/15/23 14:12, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct atmel_nand. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Tudor Ambarus > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Claudiu Beznea > Cc: linux-mtd@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index 3f494f7c7ecb..4cb478bbee4a 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -165,7 +165,7 @@ struct atmel_nand { > struct atmel_pmecc_user *pmecc; > struct gpio_desc *cdgpio; > int numcs; > - struct atmel_nand_cs cs[]; > + struct atmel_nand_cs cs[] __counted_by(numcs); > }; > > static inline struct atmel_nand *to_atmel_nand(struct nand_chip *chip) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel