From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924ABEB64DC for ; Sat, 17 Jun 2023 17:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346404AbjFQRmg (ORCPT ); Sat, 17 Jun 2023 13:42:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235173AbjFQRmf (ORCPT ); Sat, 17 Jun 2023 13:42:35 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C18E18D for ; Sat, 17 Jun 2023 10:42:33 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-978863fb00fso296751066b.3 for ; Sat, 17 Jun 2023 10:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=aRdxjDw/1uvXnJ//jlaQwyS/TqDcl1/7LzBQg/R1EXypY+rnCSK/aDPHd6Q+4ARnv4 +NGnyV7dsW8AqrGmOwr/rR/VMnnoMMuDleT1XolFanwT3Kgg/pD9yP/t1KZl2GV3AH2j AZ7OuposYBI5ZkMMLmh/SKduk8jAxGkr6PFfpHHDhqjOcr/g2KkxXV+a6lk/CygopQ3j x/+8JctmHVdvEvaDP4TZBDZi5y2qR8yQMAKQwdTO1UPbtICOJVQ4Tmk/vjKUUT3+kWPG 9Bb4KFGsv84LnW8l0rr4tltcD4pVuRDZD9jAHZhRxHlAgdpSDg/6P5R8vxdC0LmUzS/2 rMpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=UYm9Qo3SygWZiBc6ZcrgFDPOGhFQG9fwhn0aG0Fi8GHTI5YV0AnSDgpB3r4ZHLHlwa oka4uWmiQ/d6dBbyH4HDzpfLRqj2a/huMkefsvyuXbFeLijc/T7fuogc4kU3FeT7ZdoH wxm3TdGbHIRTqkTxj+jOSQsTrSNJ6hqfIQciPRrU68m/wCS1pV4FwUGEmsi5uYCj292H BQjXGaYnuxETbsPow/dM6HAFLYfStF+T1NxrbSjnk9h5cbFGh9FpEB/Pg19SbrGyW6O8 UYBab3/B2/wXl+g9z3cff0qVnggX8+8JlBChxD8nlPWUFDEfK10Urk/eqUOPhtYwL2hv x/CA== X-Gm-Message-State: AC+VfDyw+sI19iM/TdK7Bz8+59JSKZbTVOGVf6pyBc857CUIvauZHkGL ZBGb/b13ww1clff/dAqm2hrJ/Q== X-Google-Smtp-Source: ACHHUZ5PyeAyyYwAOEyIOLQVoZ7ixv/ktFKK7Bl05nXnE2sYt17DPKOVjyphVc5AwypZukVfvRQ7mg== X-Received: by 2002:a17:907:a41e:b0:978:8ecd:fa75 with SMTP id sg30-20020a170907a41e00b009788ecdfa75mr5415289ejc.9.1687023751850; Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id m22-20020a056402051600b0051a4efed295sm51678edv.7.2023.06.17.10.42.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 19:42:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control boost frequency Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Maximilian Weigand , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Maximilian Weigand References: <20230602-lm3630a_boost_frequency-v1-0-076472036d1a@mweigand.net> <20230602-lm3630a_boost_frequency-v1-2-076472036d1a@mweigand.net> <17576d81-a342-0b77-367a-eb9f2b97b734@linaro.org> <7491264.lOV4Wx5bFT@diego> From: Krzysztof Kozlowski In-Reply-To: <7491264.lOV4Wx5bFT@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 17/06/2023 18:34, Heiko Stübner wrote: > Am Samstag, 17. Juni 2023, 12:12:17 CEST schrieb Krzysztof Kozlowski: >> On 14/06/2023 21:08, Maximilian Weigand wrote: >>> From: Maximilian Weigand >>> >>> Add 'ti,boost_use_1mhz' to switch between 500 kHz and 1 MHz boost >>> converter switching frequency, and add 'ti,boost_frequency_shift' to >>> activate a frequency shift to 560 kHz or 1.12 MHz, respectively. >>> >>> Signed-off-by: Maximilian Weigand >>> --- >>> .../bindings/leds/backlight/lm3630a-backlight.yaml | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >>> index 3c9b4054ed9a..ef7ea0ad2d25 100644 >>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >>> @@ -33,6 +33,18 @@ properties: >>> description: GPIO to use to enable/disable the backlight (HWEN pin). >>> maxItems: 1 >>> >>> + ti,boost_use_1mhz: >> >> No underscores in property names. >> >>> + description: | >> >> Do not need '|' unless you need to preserve formatting. >> >>> + If present, change the boost converter switching frequency from the >>> + default 500 kHz to 1 MHz. Refer to data sheet for hardware requirements. >>> + type: boolean >>> + >>> + ti,boost_frequency_shift: >>> + description: | >>> + If present, change boost converter switching frequency from 500 kHz to >>> + 560 kHz or from 1 Mhz to 1.12 Mhz, respectively. >> >> So just make it a property choosing the frequency, not bools, with >> proper unit suffix. > > i.e. > ti,boost-frequency-hz = ; > with x being 500000, 560000, 1000000, 1120000 > > with the driver failing when the frequency is not achievable > with the two knobs of 1mhz and shift. Yeah, with a default value (500000, I guess). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CDE8EB64D9 for ; Sat, 17 Jun 2023 17:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u8e0Jr0z0n5D0p+SI4WssFKOfZsXEofzSsn8rRKlZT0=; b=GWxVQ6j+kOb6qP DcYc8hlfZBxSiCYblQ5rEv+7ml1/bTL6WdsPltchjzaORPp3tadAa15c16M6yqRmJPmpLoNVOMK9y 1T93bptlS6/5XG1dtIZGsy/UybYjv7CvAta8tA40tKk38TgzCEDniSk0lpcN93K3tOOjk40BxZj4W XvmL8p7d8DlsfIxfm9D6qDvHlyyc3/gMkiCMJ/55L5hHb5ZB/TBjpB5rcc9C7mspKnqy6bEEUsqQ7 wP8bJ2ji7A98/LKFGyztDco9jBlNRNSLk+EVqklGdnQPd2pdeX4w3djNOfBijt9O4pYQq8y2OeZ3k C3v3hWBRt3kQE9Ucj9dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAZwe-0041HL-1j; Sat, 17 Jun 2023 17:42:40 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAZwc-0041FB-20 for linux-rockchip@lists.infradead.org; Sat, 17 Jun 2023 17:42:39 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9829a5ae978so296638366b.2 for ; Sat, 17 Jun 2023 10:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=aRdxjDw/1uvXnJ//jlaQwyS/TqDcl1/7LzBQg/R1EXypY+rnCSK/aDPHd6Q+4ARnv4 +NGnyV7dsW8AqrGmOwr/rR/VMnnoMMuDleT1XolFanwT3Kgg/pD9yP/t1KZl2GV3AH2j AZ7OuposYBI5ZkMMLmh/SKduk8jAxGkr6PFfpHHDhqjOcr/g2KkxXV+a6lk/CygopQ3j x/+8JctmHVdvEvaDP4TZBDZi5y2qR8yQMAKQwdTO1UPbtICOJVQ4Tmk/vjKUUT3+kWPG 9Bb4KFGsv84LnW8l0rr4tltcD4pVuRDZD9jAHZhRxHlAgdpSDg/6P5R8vxdC0LmUzS/2 rMpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=PZG2bco6bHjddq+BQCySlYBvKgmZu0JxFRjT3vCq65OCsATEE9R/PyqFj7uFTP2JUK myQcj67vgPhYTsfRVevQtsfWV7HBov1JngoTl+NLLo1eJ90fOcnwwQYSmlBBAmw98LFN MxMm9hbwUd8+lBBE2JPCUvsNcv9KLe4YTZlvs8ZMI7Wxqe3EVsvndupFonERubB2ZmFW WcgskQ8sXCVQZGeWJ0FqRA87Bg8JUkyhiSP7NoAJjuTHV7dmhm7hFXIEpNW5oQqxSjGp ZFUTwpDZ9OJyyQyLden46TYJN3eK8RwZgAD2j7IeqYv82DURJjNearEu7v3IR9jWH5ZN xowg== X-Gm-Message-State: AC+VfDwqtWTEdJOlwjBTduD3iPrpjxumjMRAWDI7rufmkTJiGWm434mu bA+1cwP+zWox/0b0/CofCvPVEQ== X-Google-Smtp-Source: ACHHUZ5PyeAyyYwAOEyIOLQVoZ7ixv/ktFKK7Bl05nXnE2sYt17DPKOVjyphVc5AwypZukVfvRQ7mg== X-Received: by 2002:a17:907:a41e:b0:978:8ecd:fa75 with SMTP id sg30-20020a170907a41e00b009788ecdfa75mr5415289ejc.9.1687023751850; Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id m22-20020a056402051600b0051a4efed295sm51678edv.7.2023.06.17.10.42.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 19:42:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control boost frequency Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Maximilian Weigand , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Maximilian Weigand References: <20230602-lm3630a_boost_frequency-v1-0-076472036d1a@mweigand.net> <20230602-lm3630a_boost_frequency-v1-2-076472036d1a@mweigand.net> <17576d81-a342-0b77-367a-eb9f2b97b734@linaro.org> <7491264.lOV4Wx5bFT@diego> From: Krzysztof Kozlowski In-Reply-To: <7491264.lOV4Wx5bFT@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230617_104238_664524_ADA626E6 X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMTcvMDYvMjAyMyAxODozNCwgSGVpa28gU3TDvGJuZXIgd3JvdGU6Cj4gQW0gU2Ftc3RhZywg MTcuIEp1bmkgMjAyMywgMTI6MTI6MTcgQ0VTVCBzY2hyaWViIEtyenlzenRvZiBLb3psb3dza2k6 Cj4+IE9uIDE0LzA2LzIwMjMgMjE6MDgsIE1heGltaWxpYW4gV2VpZ2FuZCB3cm90ZToKPj4+IEZy b206IE1heGltaWxpYW4gV2VpZ2FuZCA8bXdlaWdhbmRAbXdlaWdhbmQubmV0Pgo+Pj4KPj4+IEFk ZCAndGksYm9vc3RfdXNlXzFtaHonIHRvIHN3aXRjaCBiZXR3ZWVuIDUwMCBrSHogYW5kIDEgTUh6 IGJvb3N0Cj4+PiBjb252ZXJ0ZXIgc3dpdGNoaW5nIGZyZXF1ZW5jeSwgYW5kIGFkZCAndGksYm9v c3RfZnJlcXVlbmN5X3NoaWZ0JyB0bwo+Pj4gYWN0aXZhdGUgYSBmcmVxdWVuY3kgc2hpZnQgdG8g NTYwIGtIeiBvciAxLjEyIE1IeiwgcmVzcGVjdGl2ZWx5Lgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6 IE1heGltaWxpYW4gV2VpZ2FuZCA8bXdlaWdhbmRAbXdlaWdhbmQubmV0Pgo+Pj4gLS0tCj4+PiAg Li4uL2JpbmRpbmdzL2xlZHMvYmFja2xpZ2h0L2xtMzYzMGEtYmFja2xpZ2h0LnlhbWwgICAgICAg ICAgIHwgMTIgKysrKysrKysrKysrCj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo KykKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2xlZHMvYmFja2xpZ2h0L2xtMzYzMGEtYmFja2xpZ2h0LnlhbWwgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvbGVkcy9iYWNrbGlnaHQvbG0zNjMwYS1iYWNrbGlnaHQueWFtbAo+ Pj4gaW5kZXggM2M5YjQwNTRlZDlhLi5lZjdlYTBhZDJkMjUgMTAwNjQ0Cj4+PiAtLS0gYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbGVkcy9iYWNrbGlnaHQvbG0zNjMwYS1iYWNr bGlnaHQueWFtbAo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2xl ZHMvYmFja2xpZ2h0L2xtMzYzMGEtYmFja2xpZ2h0LnlhbWwKPj4+IEBAIC0zMyw2ICszMywxOCBA QCBwcm9wZXJ0aWVzOgo+Pj4gICAgICBkZXNjcmlwdGlvbjogR1BJTyB0byB1c2UgdG8gZW5hYmxl L2Rpc2FibGUgdGhlIGJhY2tsaWdodCAoSFdFTiBwaW4pLgo+Pj4gICAgICBtYXhJdGVtczogMQo+ Pj4gIAo+Pj4gKyAgdGksYm9vc3RfdXNlXzFtaHo6Cj4+Cj4+IE5vIHVuZGVyc2NvcmVzIGluIHBy b3BlcnR5IG5hbWVzLgo+Pgo+Pj4gKyAgICBkZXNjcmlwdGlvbjogfAo+Pgo+PiBEbyBub3QgbmVl ZCAnfCcgdW5sZXNzIHlvdSBuZWVkIHRvIHByZXNlcnZlIGZvcm1hdHRpbmcuCj4+Cj4+PiArICAg ICAgSWYgcHJlc2VudCwgY2hhbmdlIHRoZSBib29zdCBjb252ZXJ0ZXIgc3dpdGNoaW5nIGZyZXF1 ZW5jeSBmcm9tIHRoZQo+Pj4gKyAgICAgIGRlZmF1bHQgNTAwIGtIeiB0byAxIE1Iei4gUmVmZXIg dG8gZGF0YSBzaGVldCBmb3IgaGFyZHdhcmUgcmVxdWlyZW1lbnRzLgo+Pj4gKyAgICB0eXBlOiBi b29sZWFuCj4+PiArCj4+PiArICB0aSxib29zdF9mcmVxdWVuY3lfc2hpZnQ6Cj4+PiArICAgIGRl c2NyaXB0aW9uOiB8Cj4+PiArICAgICAgSWYgcHJlc2VudCwgY2hhbmdlIGJvb3N0IGNvbnZlcnRl ciBzd2l0Y2hpbmcgZnJlcXVlbmN5IGZyb20gNTAwIGtIeiB0bwo+Pj4gKyAgICAgIDU2MCBrSHog b3IgZnJvbSAxIE1oeiB0byAxLjEyIE1oeiwgcmVzcGVjdGl2ZWx5Lgo+Pgo+PiBTbyBqdXN0IG1h a2UgaXQgYSBwcm9wZXJ0eSBjaG9vc2luZyB0aGUgZnJlcXVlbmN5LCBub3QgYm9vbHMsIHdpdGgK Pj4gcHJvcGVyIHVuaXQgc3VmZml4Lgo+IAo+IGkuZS4KPiB0aSxib29zdC1mcmVxdWVuY3ktaHog PSA8eD47Cj4gd2l0aCB4IGJlaW5nIDUwMDAwMCwgNTYwMDAwLCAxMDAwMDAwLCAxMTIwMDAwCj4g Cj4gd2l0aCB0aGUgZHJpdmVyIGZhaWxpbmcgd2hlbiB0aGUgZnJlcXVlbmN5IGlzIG5vdCBhY2hp ZXZhYmxlCj4gd2l0aCB0aGUgdHdvIGtub2JzIG9mIDFtaHogYW5kIHNoaWZ0LgoKWWVhaCwgd2l0 aCBhIGRlZmF1bHQgdmFsdWUgKDUwMDAwMCwgSSBndWVzcykuCgpCZXN0IHJlZ2FyZHMsCktyenlz enRvZgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9j a2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 101FBEB64D9 for ; Sat, 17 Jun 2023 17:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CVsJxq2EzGDIwBcCJGlSGAEPI36JK6oVA1ZTF9PVbJg=; b=mGQ/c7WlKKMPcd HfUZYrr2+5jubcCqaiGxoyWZuf/jdRsw5bxQ4d8XXfDkwikut/VjP1jzuRCms11ajy8MiLADNtFfl xjRLjfq+wN3aycO4dPSNJvY/LDI9eNQdcvTenCq8DKmeyFruYVK0mOydS3O2ecKgkzEQNfI9NNhHj 1ZL2qkOlakNOmMrtldozYW3K1jU7ctut8bnQCg1BTlLU/bnCg1FgqAysokTLexJAvQlfnsdbCeEee iQHOGktlsMjCCcZ8u0Qbg9CQbq5jK5aejD+A4/oB/znWAc1jZu1rOk9RBN38OLyC/mnivK29CKsIr E/29q2j8FIbp2vfFzExw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAZwa-0041Fo-3C; Sat, 17 Jun 2023 17:42:36 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAZwY-0041FC-05 for linux-arm-kernel@lists.infradead.org; Sat, 17 Jun 2023 17:42:35 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-982a0232bdcso297440066b.1 for ; Sat, 17 Jun 2023 10:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=aRdxjDw/1uvXnJ//jlaQwyS/TqDcl1/7LzBQg/R1EXypY+rnCSK/aDPHd6Q+4ARnv4 +NGnyV7dsW8AqrGmOwr/rR/VMnnoMMuDleT1XolFanwT3Kgg/pD9yP/t1KZl2GV3AH2j AZ7OuposYBI5ZkMMLmh/SKduk8jAxGkr6PFfpHHDhqjOcr/g2KkxXV+a6lk/CygopQ3j x/+8JctmHVdvEvaDP4TZBDZi5y2qR8yQMAKQwdTO1UPbtICOJVQ4Tmk/vjKUUT3+kWPG 9Bb4KFGsv84LnW8l0rr4tltcD4pVuRDZD9jAHZhRxHlAgdpSDg/6P5R8vxdC0LmUzS/2 rMpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=GnW9H/w23oiRmVCXi7IbB5kFSGUaRPqoH53Upuya2s4RhqQPrmkrGW096RuGzXNuy7 4yby9LTS5gy10qiQHdPVjJ+y0URq0wWI3RtOMcq8nwJtoN1rqRCeHi2vjU+izaVv9VTk Uijiy40yCLTbQGMWFanL3nLvW3Z1ULmxm7+aSKDI8VUm8R4NC0tmozdvTEdFigOIwng1 NlMevtOtp84kaktt0nbYIousfbI/vQK7k3/X+A0/OAVmpMxKQCEvbwv3LtRPYDjKp+St BRICC7vNR6iN5pGh9R9ypj19aVUFbaOFBJ6KyxT0zDRTRoeZR4Er8FqoAomhSSDIVpFX UdHQ== X-Gm-Message-State: AC+VfDzF/wTVhfD3RpLVPwKZ+BajCW5pfRTqTAC9qg+ZVsvflyDWHlsr CwbFzVZn1KFvaL8OfwAykoM6sw== X-Google-Smtp-Source: ACHHUZ5PyeAyyYwAOEyIOLQVoZ7ixv/ktFKK7Bl05nXnE2sYt17DPKOVjyphVc5AwypZukVfvRQ7mg== X-Received: by 2002:a17:907:a41e:b0:978:8ecd:fa75 with SMTP id sg30-20020a170907a41e00b009788ecdfa75mr5415289ejc.9.1687023751850; Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id m22-20020a056402051600b0051a4efed295sm51678edv.7.2023.06.17.10.42.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 19:42:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control boost frequency Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Maximilian Weigand , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Maximilian Weigand References: <20230602-lm3630a_boost_frequency-v1-0-076472036d1a@mweigand.net> <20230602-lm3630a_boost_frequency-v1-2-076472036d1a@mweigand.net> <17576d81-a342-0b77-367a-eb9f2b97b734@linaro.org> <7491264.lOV4Wx5bFT@diego> From: Krzysztof Kozlowski In-Reply-To: <7491264.lOV4Wx5bFT@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230617_104234_091743_05DECD97 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTcvMDYvMjAyMyAxODozNCwgSGVpa28gU3TDvGJuZXIgd3JvdGU6Cj4gQW0gU2Ftc3RhZywg MTcuIEp1bmkgMjAyMywgMTI6MTI6MTcgQ0VTVCBzY2hyaWViIEtyenlzenRvZiBLb3psb3dza2k6 Cj4+IE9uIDE0LzA2LzIwMjMgMjE6MDgsIE1heGltaWxpYW4gV2VpZ2FuZCB3cm90ZToKPj4+IEZy b206IE1heGltaWxpYW4gV2VpZ2FuZCA8bXdlaWdhbmRAbXdlaWdhbmQubmV0Pgo+Pj4KPj4+IEFk ZCAndGksYm9vc3RfdXNlXzFtaHonIHRvIHN3aXRjaCBiZXR3ZWVuIDUwMCBrSHogYW5kIDEgTUh6 IGJvb3N0Cj4+PiBjb252ZXJ0ZXIgc3dpdGNoaW5nIGZyZXF1ZW5jeSwgYW5kIGFkZCAndGksYm9v c3RfZnJlcXVlbmN5X3NoaWZ0JyB0bwo+Pj4gYWN0aXZhdGUgYSBmcmVxdWVuY3kgc2hpZnQgdG8g NTYwIGtIeiBvciAxLjEyIE1IeiwgcmVzcGVjdGl2ZWx5Lgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6 IE1heGltaWxpYW4gV2VpZ2FuZCA8bXdlaWdhbmRAbXdlaWdhbmQubmV0Pgo+Pj4gLS0tCj4+PiAg Li4uL2JpbmRpbmdzL2xlZHMvYmFja2xpZ2h0L2xtMzYzMGEtYmFja2xpZ2h0LnlhbWwgICAgICAg ICAgIHwgMTIgKysrKysrKysrKysrCj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo KykKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2xlZHMvYmFja2xpZ2h0L2xtMzYzMGEtYmFja2xpZ2h0LnlhbWwgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvbGVkcy9iYWNrbGlnaHQvbG0zNjMwYS1iYWNrbGlnaHQueWFtbAo+ Pj4gaW5kZXggM2M5YjQwNTRlZDlhLi5lZjdlYTBhZDJkMjUgMTAwNjQ0Cj4+PiAtLS0gYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbGVkcy9iYWNrbGlnaHQvbG0zNjMwYS1iYWNr bGlnaHQueWFtbAo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2xl ZHMvYmFja2xpZ2h0L2xtMzYzMGEtYmFja2xpZ2h0LnlhbWwKPj4+IEBAIC0zMyw2ICszMywxOCBA QCBwcm9wZXJ0aWVzOgo+Pj4gICAgICBkZXNjcmlwdGlvbjogR1BJTyB0byB1c2UgdG8gZW5hYmxl L2Rpc2FibGUgdGhlIGJhY2tsaWdodCAoSFdFTiBwaW4pLgo+Pj4gICAgICBtYXhJdGVtczogMQo+ Pj4gIAo+Pj4gKyAgdGksYm9vc3RfdXNlXzFtaHo6Cj4+Cj4+IE5vIHVuZGVyc2NvcmVzIGluIHBy b3BlcnR5IG5hbWVzLgo+Pgo+Pj4gKyAgICBkZXNjcmlwdGlvbjogfAo+Pgo+PiBEbyBub3QgbmVl ZCAnfCcgdW5sZXNzIHlvdSBuZWVkIHRvIHByZXNlcnZlIGZvcm1hdHRpbmcuCj4+Cj4+PiArICAg ICAgSWYgcHJlc2VudCwgY2hhbmdlIHRoZSBib29zdCBjb252ZXJ0ZXIgc3dpdGNoaW5nIGZyZXF1 ZW5jeSBmcm9tIHRoZQo+Pj4gKyAgICAgIGRlZmF1bHQgNTAwIGtIeiB0byAxIE1Iei4gUmVmZXIg dG8gZGF0YSBzaGVldCBmb3IgaGFyZHdhcmUgcmVxdWlyZW1lbnRzLgo+Pj4gKyAgICB0eXBlOiBi b29sZWFuCj4+PiArCj4+PiArICB0aSxib29zdF9mcmVxdWVuY3lfc2hpZnQ6Cj4+PiArICAgIGRl c2NyaXB0aW9uOiB8Cj4+PiArICAgICAgSWYgcHJlc2VudCwgY2hhbmdlIGJvb3N0IGNvbnZlcnRl ciBzd2l0Y2hpbmcgZnJlcXVlbmN5IGZyb20gNTAwIGtIeiB0bwo+Pj4gKyAgICAgIDU2MCBrSHog b3IgZnJvbSAxIE1oeiB0byAxLjEyIE1oeiwgcmVzcGVjdGl2ZWx5Lgo+Pgo+PiBTbyBqdXN0IG1h a2UgaXQgYSBwcm9wZXJ0eSBjaG9vc2luZyB0aGUgZnJlcXVlbmN5LCBub3QgYm9vbHMsIHdpdGgK Pj4gcHJvcGVyIHVuaXQgc3VmZml4Lgo+IAo+IGkuZS4KPiB0aSxib29zdC1mcmVxdWVuY3ktaHog PSA8eD47Cj4gd2l0aCB4IGJlaW5nIDUwMDAwMCwgNTYwMDAwLCAxMDAwMDAwLCAxMTIwMDAwCj4g Cj4gd2l0aCB0aGUgZHJpdmVyIGZhaWxpbmcgd2hlbiB0aGUgZnJlcXVlbmN5IGlzIG5vdCBhY2hp ZXZhYmxlCj4gd2l0aCB0aGUgdHdvIGtub2JzIG9mIDFtaHogYW5kIHNoaWZ0LgoKWWVhaCwgd2l0 aCBhIGRlZmF1bHQgdmFsdWUgKDUwMDAwMCwgSSBndWVzcykuCgpCZXN0IHJlZ2FyZHMsCktyenlz enRvZgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F33F2EB64DB for ; Sat, 17 Jun 2023 17:42:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ECB7E10E09F; Sat, 17 Jun 2023 17:42:36 +0000 (UTC) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85DCA10E09F for ; Sat, 17 Jun 2023 17:42:35 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-987accb4349so103681466b.0 for ; Sat, 17 Jun 2023 10:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=aRdxjDw/1uvXnJ//jlaQwyS/TqDcl1/7LzBQg/R1EXypY+rnCSK/aDPHd6Q+4ARnv4 +NGnyV7dsW8AqrGmOwr/rR/VMnnoMMuDleT1XolFanwT3Kgg/pD9yP/t1KZl2GV3AH2j AZ7OuposYBI5ZkMMLmh/SKduk8jAxGkr6PFfpHHDhqjOcr/g2KkxXV+a6lk/CygopQ3j x/+8JctmHVdvEvaDP4TZBDZi5y2qR8yQMAKQwdTO1UPbtICOJVQ4Tmk/vjKUUT3+kWPG 9Bb4KFGsv84LnW8l0rr4tltcD4pVuRDZD9jAHZhRxHlAgdpSDg/6P5R8vxdC0LmUzS/2 rMpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687023752; x=1689615752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3wWvAWGQ6I3uVKkcwPxaCb9XbFnbEdfsJNuIbFzDQyw=; b=TAgod2RdDW4k8ACQ+BhAX1msnJ8wolXOlzjTkcLzezUFMZIHfzxsgH8f3QiHHYKN4E yPlZhO1uhEI6jDC9xU326r2sG9OHHYT0VLNhM9TwWWcfPRWXYJn8VxPe0fzXtZdMPpsT sFQQHGbxuQQlLOqc7EU+Mnq84nRDqiU3ZlH4zDGHaodGJmzOcOSha5OqHNyt0/+MzY4J /kSbNS6IN8qC8eXVA5uGorZ4yeLAE5qvLRPjD0Sd20GngMq5skcWbWDNa8bhOQIlAJwM GcZq9PuaTIRAP/G4ABqqrmMuwWbBOail6WdM8S0knE9S/OYCiEU6onIeNjf9OMm+MWqm RXGw== X-Gm-Message-State: AC+VfDz2ePvdB1IB9jUYmwH5O2pfrXv/tFWe4nIVcOqtMtvMWFjlw28A BLWtZi82XMogJLnqTvmPH6QuKA== X-Google-Smtp-Source: ACHHUZ5PyeAyyYwAOEyIOLQVoZ7ixv/ktFKK7Bl05nXnE2sYt17DPKOVjyphVc5AwypZukVfvRQ7mg== X-Received: by 2002:a17:907:a41e:b0:978:8ecd:fa75 with SMTP id sg30-20020a170907a41e00b009788ecdfa75mr5415289ejc.9.1687023751850; Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id m22-20020a056402051600b0051a4efed295sm51678edv.7.2023.06.17.10.42.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 10:42:31 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 19:42:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control boost frequency Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Maximilian Weigand , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <20230602-lm3630a_boost_frequency-v1-0-076472036d1a@mweigand.net> <20230602-lm3630a_boost_frequency-v1-2-076472036d1a@mweigand.net> <17576d81-a342-0b77-367a-eb9f2b97b734@linaro.org> <7491264.lOV4Wx5bFT@diego> From: Krzysztof Kozlowski In-Reply-To: <7491264.lOV4Wx5bFT@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Maximilian Weigand , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 17/06/2023 18:34, Heiko Stübner wrote: > Am Samstag, 17. Juni 2023, 12:12:17 CEST schrieb Krzysztof Kozlowski: >> On 14/06/2023 21:08, Maximilian Weigand wrote: >>> From: Maximilian Weigand >>> >>> Add 'ti,boost_use_1mhz' to switch between 500 kHz and 1 MHz boost >>> converter switching frequency, and add 'ti,boost_frequency_shift' to >>> activate a frequency shift to 560 kHz or 1.12 MHz, respectively. >>> >>> Signed-off-by: Maximilian Weigand >>> --- >>> .../bindings/leds/backlight/lm3630a-backlight.yaml | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >>> index 3c9b4054ed9a..ef7ea0ad2d25 100644 >>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >>> @@ -33,6 +33,18 @@ properties: >>> description: GPIO to use to enable/disable the backlight (HWEN pin). >>> maxItems: 1 >>> >>> + ti,boost_use_1mhz: >> >> No underscores in property names. >> >>> + description: | >> >> Do not need '|' unless you need to preserve formatting. >> >>> + If present, change the boost converter switching frequency from the >>> + default 500 kHz to 1 MHz. Refer to data sheet for hardware requirements. >>> + type: boolean >>> + >>> + ti,boost_frequency_shift: >>> + description: | >>> + If present, change boost converter switching frequency from 500 kHz to >>> + 560 kHz or from 1 Mhz to 1.12 Mhz, respectively. >> >> So just make it a property choosing the frequency, not bools, with >> proper unit suffix. > > i.e. > ti,boost-frequency-hz = ; > with x being 500000, 560000, 1000000, 1120000 > > with the driver failing when the frequency is not achievable > with the two knobs of 1mhz and shift. Yeah, with a default value (500000, I guess). Best regards, Krzysztof