From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ixit.cz (ixit.cz [84.42.129.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDAF2196C7C; Thu, 10 Sep 2026 00:09:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.42.129.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788998973; cv=none; b=n+kut3/SHM4Wiw1A6HD0viUK2eaBKjaaheVwZHMKhJ0efr87LVCWiSWQ0JI2cSwnyVtyBcMHTydEM7wHC3pwxvh+QaRhrc2DfkZ6B6cjnVuIqBD8y5mg0SI+rB187Gr7EpsbmENaBT9r3PYo478tRuM8EVfUlEcY6qO7CKzOOc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788998973; c=relaxed/simple; bh=MJ8O/8mlEo1PcRXQ9dntuNgNgI7uKtXeWtpIBTBoGgI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N0kMtpqwCtpLZ7YrW+W/laxCOt9xOqdqdYjlR7mhWvlZAOqXD5Zpd+y/w7mbS2r4FTlbSdtL3fpgIo6yPvCzNlDGrFO01DZKi1vImN5i2agf+ZFdoWrDii64jPzjyMEfLg7x93Ifvcymepm4n38/swl+mS0E1cT7L2aaZiho5fA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ixit.cz; spf=pass smtp.mailfrom=ixit.cz; dkim=pass (1024-bit key) header.d=ixit.cz header.i=@ixit.cz header.b=EGYIRpdx; arc=none smtp.client-ip=84.42.129.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ixit.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ixit.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ixit.cz header.i=@ixit.cz header.b="EGYIRpdx" Received: from [IPV6:2a02:830a:f787:8f00:d622:eaa3:3dd6:8f5e] (unknown [IPv6:2a02:830a:f787:8f00:d622:eaa3:3dd6:8f5e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id C46A553400B2; Thu, 10 Sep 2026 02:09:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixit.cz; s=dkim; t=1788998967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OPN1TafMfqYaUTzDsU5JbwTLbIBgnQViJQ/wMQ6fh0s=; b=EGYIRpdxcnZAqdMTh1T3Jew8CbZfsvqCxBbnEjq/EL5BZ3LibcQW0pZ2hrVD895hL0pvXh 4xRk7jRw9/9l+XvhU+RKLLa8CkYMjAIH2YsZSI5VU4Fgqi2jzEmnmiBzFMiDzvwt8sLIN2 908C6K8+44W8j6NRQ1MVP2o8jRuUrSg= Message-ID: Date: Thu, 10 Sep 2026 02:09:27 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] power: supply: bq27xxx: autodetect bq27411 and bq27541 To: Rinat Muhamedgaliev , Bjorn Andersson , Konrad Dybcio , Sebastian Reichel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Pali_Roh=C3=A1r?= , "Andrew F . Davis" , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260829205258.26955-1-rinat.muhamedgaliev@gmail.com> <20260909234744.1177153-1-rinat.muhamedgaliev@gmail.com> <20260909234744.1177153-3-rinat.muhamedgaliev@gmail.com> Content-Language: en-US, cs-CZ From: David Heidelberg Autocrypt: addr=david@ixit.cz; keydata= xsFNBF5v1x4BEADS3EddwsNsvVAI1XF8uQKbdYPY/GhjaSLziwVnbwv5BGwqB1tfXoHnccoA 9kTgKAbiXG/CiZFhD6l4WCIskQDKzyQN3JhCUIxh16Xyw0lECI7iqoW9LmMoN1dNKcUmCO9g lZxQaOl+1bY/7ttd7DapLh9rmBXJ2lKiMEaIpUwb/Nw0d7Enp4Jy2TpkhPywIpUn8CoJCv3/ 61qbvI9y5utB/UhfMAUXsaAgwEJyGPAqHlC0YZjaTwOu+YQUE3AFzhCbksq95CwDz4U4gdls dmv9tkATfu2OmzERZQ6vJTehK0Pu4l5KmCAzYg42I9Dy4E6b17x6NncKbcByQFOXMtG0qVUk F1yeeOQUHwu+8t3ZDMBUhCkRL/juuoqLmyDWKMc0hKNNeZ9BNXgB8fXkRLWEUfgDXsFyEkKp NxUy5bDRlivf6XfExnikk5kj9l2gGlNQwqROti/46bfbmlmc/a2GM4k8ZyalHNEAdwtXYSpP 8JJmlbQ7hNTLkc3HQLRsIocN5th/ur7pPMz1Beyp0gbE9GcOceqmdZQB80vJ01XDyCAihf6l AMnzwpXZsjqIqH9r7T7tM6tVEVbPSwPt4eZYXSoJijEBC/43TBbmxDX+5+3txRaSCRQrG9dY k3mMGM3xJLCps2KnaqMcgUnvb1KdTgEFUZQaItw7HyRd6RppewARAQABzSBEYXZpZCBIZWlk ZWxiZXJnIDxkYXZpZEBpeGl0LmN6PsLBlAQTAQgAPgIbAwULCQgHAgYVCgkICwIEFgIDAQIe AQIXgBYhBNd6Cc/u3Cu9U6cEdGACP8TTSSByBQJl+KksBQkPDaAOAAoJEGACP8TTSSBy6IAQ AMqFqVi9LLxCEcUWBn82ssQGiVSDniKpFE/tp7lMXflwhjD5xoftoWOmMYkiWE86t5x5Fsp7 afALx7SEDz599F1K1bLnaga+budu55JEAYGudD2WwpLJ0kPzRhqBwGFIx8k6F+goZJzxPDsf loAtXQE62UvEKa4KRRcZmF0GGoRsgA7vE7OnV8LMeocdD3eb2CuXLzauHAfdvqF50IfPH/sE jbzROiAZU+WgrwU946aOzrN8jVU+Cy8XAccGAZxsmPBfhTY5f2VN1IqvfaRdkKKlmWVJWGw+ ycFpAEJKFRdfcc5PSjUJcALn5C+hxzL2hBpIZJdfdfStn+DWHXNgBeRDiZj1x6vvyaC43RAb VXvRzOQfG4EaMVMIOvBjBA/FtIpb1gtXA42ewhvPnd5RVCqD9YYUxsVpJ9d+XsAy7uib3BsV W2idAEsPtoqhVhq8bCUs/G4sC2DdyGZK8MRFDJqciJSUbqA+5z1ZCuE8UOPDpZKiW6H/OuOM zDcjh0lOzr4p+/1TSg1PbUh7fQ+nbMuiT044sC1lLtJK0+Zyn0GwhR82oNM4fldNsaHRW42w QGD35+eNo5Pvb3We5XRMlBdhFnj7Siggp4J8/PJ6MJvRyC+RIJPGtbdMB2/RxWunFLn87e5w UgwR9jPMHAstuTR1yR23c4SIYoQ2fzkrRzuazsFNBF5v1x4BEADnlrbta2WL87BlEOotZUh0 zXANMrNV15WxexsirLetfqbs0AGCaTRNj+uWlTUDJRXOVIwzmF76Us3I2796+Od2ocNpLheZ 7EIkq8budtLVd1c06qJ+GMraz51zfgSIazVInNMPk9T6fz0lembji5yEcNPNNBA4sHiFmXfo IhepHFOBApjS0CiOPqowYxSTPe/DLcJ/LDwWpTi37doKPhBwlHev1BwVCbrLEIFjY0MLM0aT jiBBlyLJaTqvE48gblonu2SGaNmGtkC3VoQUQFcVYDXtlL9CVbNo7BAt5gwPcNqEqkUL60Jh FtvVSKyQh6gn7HHsyMtgltjZ3NKjv8S3yQd7zxvCn79tCKwoeNevsvoMq/bzlKxc9QiKaRPO aDj3FtW7R/3XoKJBY8Hckyug6uc2qYWRpnuXc0as6S0wfek6gauExUttBKrtSbPPHiuTeNHt NsT4+dyvaJtQKPBTbPHkXpTO8e1+YAg7kPj3aKFToE/dakIh8iqUHLNxywDAamRVn8Ha67WO AEAA3iklJ49QQk2ZyS1RJ2Ul28ePFDZ3QSr9LoJiOBZv9XkbhXS164iRB7rBZk6ZRVgCz3V6 hhhjkipYvpJ/fpjXNsVL8jvel1mYNf0a46T4QQDQx4KQj0zXJbC2fFikAtu1AULktF4iEXEI rSjFoqhd4euZ+QARAQABwsF8BBgBCAAmAhsMFiEE13oJz+7cK71TpwR0YAI/xNNJIHIFAmX4 qVAFCQ8NoDIACgkQYAI/xNNJIHKN4A/+Ine2Ii7JiuGITjJkcV6pgKlfwYdEs4eFD1pTRb/K 5dprUz3QSLP41u9OJQ23HnESMvn31UENk9ffebNoW7WxZ/8cTQY0JY/cgTTrlNXtyAlGbR3/ 3Q/VBJptf04Er7I6TaKAmqWzdVeKTw33LljpkHp02vrbOdylb4JQG/SginLV9purGAFptYRO 8JNa2J4FAQtQTrfOUjulOWMxy7XRkqK3QqLcPW79/CFn7q1yxamPkpoXUJq9/fVjlhk7P+da NYQpe4WQQnktBY29SkFnvfIAwqIVU8ix5Oz8rghuCcAdR7lEJ7hCX9bR0EE05FOXdZy5FWL9 GHvFa/Opkq3DPmFl/0nt4HJqq1Nwrr+WR6d0414oo1n2hPEllge/6iD3ZYwptTvOFKEw/v0A yqOoYSiKX9F7Ko7QO+VnYeVDsDDevKic2T/4GDpcSVd9ipiKxCQvUAzKUH7RUpqDTa+rYurm zRKcgRumz2Tc1ouHj6qINlzEe3a5ldctIn/dvR1l2Ko7GBTG+VGp9U5NOAEkGpxHG9yg6eeY fFYnMme51H/HKiyUlFiE3yd5LSmv8Dhbf+vsI4x6BOOOq4Iyop/Exavj1owGxW0hpdUGcCl1 ovlwVPO/6l/XLAmSGwdnGqok5eGZQzSst0tj9RC9O0dXO1TZocOsf0tJ8dR2egX4kxM= In-Reply-To: <20260909234744.1177153-3-rinat.muhamedgaliev@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/09/2026 01:47, Rinat Muhamedgaliev wrote: > Some replaceable battery packs used by OnePlus 6 and OnePlus 6T > phones contain a bq27411, while others contain a bq27541. These > devices require different register maps. > > Add support for the generic ti,bq27xxx compatible. At probe time, > issue the DeviceType control command and select the bq27411 or bq27541 > register map from the returned value. > > Signed-off-by: Rinat Muhamedgaliev > --- > drivers/power/supply/bq27xxx_battery_i2c.c | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/power/supply/bq27xxx_battery_i2c.c b/drivers/power/supply/bq27xxx_battery_i2c.c > index 868e95f..718f8e8 100644 > --- a/drivers/power/supply/bq27xxx_battery_i2c.c > +++ b/drivers/power/supply/bq27xxx_battery_i2c.c > @@ -16,6 +16,11 @@ > > static DEFINE_IDA(battery_id); > > +#define BQ27XXX_REG_CTRL 0x00 > +#define BQ27XXX_DEVICE_TYPE 0x0001 > +#define BQ27411_DEVICE_TYPE 0x0421 > +#define BQ27541_DEVICE_TYPE 0x0541 > + > static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data) > { > struct bq27xxx_device_info *di = data; > @@ -153,6 +158,32 @@ static void bq27xxx_battery_i2c_devm_ida_free(void *data) > ida_free(&battery_id, num); > } > > +static int bq27xxx_battery_i2c_detect_chip(struct bq27xxx_device_info *di) > +{ > + int ret; > + > + ret = di->bus.write(di, BQ27XXX_REG_CTRL, BQ27XXX_DEVICE_TYPE, > + false); > + if (ret < 0) > + return ret; > + > + ret = di->bus.read(di, BQ27XXX_REG_CTRL, false); > + if (ret < 0) > + return ret; > + > + switch (ret) { > + case BQ27411_DEVICE_TYPE: > + di->chip = BQ27411; > + return 0; > + case BQ27541_DEVICE_TYPE: > + di->chip = BQ27541; > + return 0; > + default: > + dev_err(di->dev, "unsupported device type 0x%04x\n", ret); > + return -ENODEV; > + } > +} > + > static int bq27xxx_battery_i2c_probe(struct i2c_client *client) > { > const struct i2c_device_id *id = i2c_client_get_device_id(client); > @@ -188,6 +219,12 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client) > di->bus.read_bulk = bq27xxx_battery_i2c_bulk_read; > di->bus.write_bulk = bq27xxx_battery_i2c_bulk_write; > > + if (!di->chip) { > + ret = bq27xxx_battery_i2c_detect_chip(di); > + if (ret) > + return ret; > + } > + > ret = bq27xxx_battery_setup(di); > if (ret) > return ret; > @@ -225,6 +262,7 @@ static void bq27xxx_battery_i2c_remove(struct i2c_client *client) > } > > static const struct i2c_device_id bq27xxx_i2c_id_table[] = { > + { "bq27xxx", 0 }, > { "bq27200", BQ27000 }, > { "bq27210", BQ27010 }, > { "bq27500", BQ2750X }, > @@ -262,6 +300,7 @@ MODULE_DEVICE_TABLE(i2c, bq27xxx_i2c_id_table); > > #ifdef CONFIG_OF > static const struct of_device_id bq27xxx_battery_i2c_of_match_table[] = { > + { .compatible = "ti,bq27xxx" }, Maybe some comment suggesting to use this compatible when autodetection is needed? David > { .compatible = "ti,bq27200" }, > { .compatible = "ti,bq27210" }, > { .compatible = "ti,bq27500" },