From: Tor Vic <torvic9@mailbox.org>
To: Martin Nybo Andersen <tweek@tweek.dk>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
Nick Terrell <terrelln@fb.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use CRC32 and a 1MiB dictionary for XZ compressed modules
Date: Fri, 22 Sep 2023 10:25:55 +0200 [thread overview]
Message-ID: <c2b92ff2-d077-4588-9d5c-93dfec0037ee@mailbox.org> (raw)
In-Reply-To: <3d34a965-ab9c-d549-0c63-c717ab5d2edc@tweek.dk>
>
> Hello?
Hello,
> Anyone?
>
> Best regards,
> - Martin
>
> On Fri, 15 Sep 2023, Martin Nybo Andersen wrote:
>
>> Kmod is now using the kernel decompressor which doesn't handle CRC64
>> and dictionaries larger than 1MiB.
>>
>> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050582
>> Signed-off-by: Martin Nybo Andersen <tweek@tweek.dk>
>> ---
>> scripts/Makefile.modinst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
>> index c59cc57286ba..ffbafbd3aeea 100644
>> --- a/scripts/Makefile.modinst
>> +++ b/scripts/Makefile.modinst
>> @@ -144,7 +144,7 @@ endif
>> quiet_cmd_gzip = GZIP $@
>> cmd_gzip = $(KGZIP) -n -f $<
>> quiet_cmd_xz = XZ $@
>> - cmd_xz = $(XZ) --lzma2=dict=2MiB -f $<
>> + cmd_xz = $(XZ) --check=crc32 --lzma2=dict=1MiB -f $<
I wonder whether it should be guarded with
ifdef CONFIG_MODULE_DECOMPRESS
But on the other hand, the difference between 1M and 2M is likely very
small in terms of compression ratio.
Cheers,
Tor Vic
>> quiet_cmd_zstd = ZSTD $@
>> cmd_zstd = $(ZSTD) -T0 --rm -f -q $<
>>
>> --
>> 2.40.1
>>
>>
>
next prev parent reply other threads:[~2023-09-22 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 10:15 [PATCH] Use CRC32 and a 1MiB dictionary for XZ compressed modules Martin Nybo Andersen
2023-09-22 7:45 ` Martin Nybo Andersen
2023-09-22 8:25 ` Tor Vic [this message]
2023-09-22 8:52 ` Martin Nybo Andersen
2023-09-22 10:41 ` Masahiro Yamada
2023-09-22 11:04 ` Martin Nybo Andersen
2023-09-22 13:34 ` Masahiro Yamada
2023-09-25 7:05 ` Masahiro Yamada
2023-09-22 9:16 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2b92ff2-d077-4588-9d5c-93dfec0037ee@mailbox.org \
--to=torvic9@mailbox.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=terrelln@fb.com \
--cc=tweek@tweek.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.