From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EAF4C83F27 for ; Wed, 16 Jul 2025 12:07:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2D9510E28B; Wed, 16 Jul 2025 12:07:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="HSx6DLZZ"; dkim-atps=neutral Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6C2B10E28B for ; Wed, 16 Jul 2025 12:07:44 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 6044E4394A; Wed, 16 Jul 2025 12:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1752667663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D5WAW+zVZAhqtZyNXVs41ilLhB/B2M4XewC+LfW1ElE=; b=HSx6DLZZcYZ2YmGplSxC+00EpfqW720bdI8bMd5Dns0aKv5WBGGDD5buLu0q/NUh7pCxpI Oua9LkmNJk7++Z0Vsfk3tvqp+aHmxl7wRpSgMiurRjO0jm8B8Krd+aDysiPAOzUrShHLDN wW71ZZnph8AATyVQZogtVDX6vRTRbp4HSp6KFirPb7rReP5zPhkVZdCB1AG2r/PRdS/YNp TE8MtVF6aT7pYqPN1zS/l/x8Q4u1FIDTHB+lKhZKSu5faFW7KebIlCZCyhgqci3cUyAYWT myquCAsGaIgI8FPTWdo/etFllTJRXHpuDkFgS5KItjkXkeMyFPDeXofBIB8cNA== Message-ID: Date: Wed, 16 Jul 2025 14:07:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t v3 38/41] lib/vkms: Test changing enabled device CRTCs To: =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , igt-dev@lists.freedesktop.org Cc: zbigniew.kempczynski@intel.com References: <20250715102513.5636-1-jose.exposito89@gmail.com> <20250715102513.5636-39-jose.exposito89@gmail.com> Content-Language: en-US From: Louis Chauvet Autocrypt: addr=louis.chauvet@bootlin.com; keydata= xsFNBGCG5KEBEAD1yQ5C7eS4rxD0Wj7JRYZ07UhWTbBpbSjHjYJQWx/qupQdzzxe6sdrxYSY 5K81kIWbtQX91pD/wH5UapRF4kwMXTAqof8+m3XfYcEDVG31Kf8QkJTG/gLBi1UfJgGBahbY hjP40kuUR/mr7M7bKoBP9Uh0uaEM+DuKl6bSXMSrJ6fOtEPOtnfBY0xVPmqIKfLFEkjh800v jD1fdwWKtAIXf+cQtC9QWvcdzAmQIwmyFBmbg+ccqao1OIXTgu+qMAHfgKDjYctESvo+Szmb DFBZudPbyTAlf2mVKpoHKMGy3ndPZ19RboKUP0wjrF+Snif6zRFisHK7D/mqpgUftoV4HjEH bQO9bTJZXIoPJMSb+Lyds0m83/LYfjcWP8w889bNyD4Lzzzu+hWIu/OObJeGEQqY01etOLMh deuSuCG9tFr0DY6l37d4VK4dqq4Snmm87IRCb3AHAEMJ5SsO8WmRYF8ReLIk0tJJPrALv8DD lnLnwadBJ9H8djZMj24+GC6MJjN8dDNWctpBXgGZKuCM7Ggaex+RLHP/+14Vl+lSLdFiUb3U ljBXuc9v5/9+D8fWlH03q+NCa1dVgUtsP2lpolOV3EE85q1HdMyt5K91oB0hLNFdTFYwn1bW WJ2FaRhiC1yV4kn/z8g7fAp57VyIb6lQfS1Wwuj5/53XYjdipQARAQABzSlMb3VpcyBDaGF1 dmV0IDxsb3Vpcy5jaGF1dmV0QGJvb3RsaW4uY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBItxBK6aJy1mk/Un8uwYg/VeC0ClBQJmlnw+BQkH8MsdAAoJEOwY g/VeC0ClyhwP/Ra6H+5F2NEW6/IMVHeXmhuly8CcZ3kyoKeGNowghIcTBo59dFh0atGCvr+y K9YD5Pyg9aX4Ropw1R1RVIMrWoUNZUKebRTu6iNHkE6tmURJaKLzR+9la+789jznQvbV+9gM YTBppX4/0cWY58jiDiDV4aJ77JDo7aWNK4hz8mZsB+Y7ezMuS4jy2r4b7dZ+YL/T9/k3/emO PkAuFkVhkNhytMEyOBsT7SjL4IUBeYWvOw9MIaXEl4qW/5HLGtMuNhS94NsviDXZquoOHOby 2uuRAI0bLz1qcsnY90yyPlDJ0pMuJHbi0DBzPTIYkyuwoyplfWxnUPp1wfsjiy/B6mRKTbdE a/K6jNzdVC1LLjTD4EjwnCE8IZBRWH1NVC1suOkw3Sr1FYcHFSYqNDrrzO+RKtR1JMrIe8/3 Xhe2/UNUhppsK3SaFaIsu98mVQY3bA/Xn9wYcuAAzRzhEHgrbp8LPzYdi6Qtlqpt4HcPV3Ya H9BkCacgyLHcdeQbBXaup9JbF5oqbdtwev3waAmNfhWhrQeqQ0tkrpJ46l9slEGEdao5Dcct QDRjmJz7Gx/rKJngQrbboOQz+rhiHPoJc/n75lgOqtHRePNEf9xmtteHYpiAXh/YNooXJvdA tgR1jAsCsxuXZnW2DpVClm1WSHNfLSWona8cTkcoSTeYCrnXzsFNBGCG6KUBEADZhvm9TZ25 JZa7wbKMOpvSH36K8wl74FhuVuv7ykeFPKH2oC7zmP1oqs1IF1UXQQzNkCHsBpIZq+TSE74a mG4sEhZP0irrG/w3JQ9Vbxds7PzlQzDarJ1WJvS2KZ4AVnwc/ucirNuxinAuAmmNBUNF8w6o Y97sdgFuIZUP6h972Tby5bu7wmy1hWL3+2QV+LEKmRpr0D9jDtJrKfm25sLwoHIojdQtGv2g JbQ9Oh9+k3QG9Kh6tiQoOrzgJ9pNjamYsnti9M2XHhlX489eXq/E6bWOBRa0UmD0tuQKNgK1 n8EDmFPW3L0vEnytAl4QyZEzPhO30GEcgtNkaJVQwiXtn4FMw4R5ncqXVvzR7rnEuXwyO9RF tjqhwxsfRlORo6vMKqvDxFfgIkVnlc2KBa563qDNARB6caG6kRaLVcy0pGVlCiHLjl6ygP+G GCNfoh/PADQz7gaobN2WZzXbsVS5LDb9w/TqskSRhkgXpxt6k2rqNgdfeyomlkQnruvkIIjs Sk2X68nwHJlCjze3IgSngS2Gc0NC/DDoUBMblP6a2LJwuF/nvaW+QzPquy5KjKUO2UqIO9y+ movZqE777uayqmMeIy4cd/gg/yTBBcGvWVm0Dh7dE6G6WXJUhWIUtXCzxKMmkvSmZy+gt1rN OyCd65HgUXPBf+hioCzGVFSoqQARAQABwsOyBBgBCAAmAhsuFiEEi3EErponLWaT9Sfy7BiD 9V4LQKUFAmaWfGYFCQfwx0ECQAkQ7BiD9V4LQKXBdCAEGQEIAB0WIQRPj7g/vng8MQxQWQQg rS7GWxAs4gUCYIbopQAKCRAgrS7GWxAs4gfGEACcA0XVNesbVIyvs5SJpJy+6csrH4yy233o GclX2P7pcCls55wiV6ywCtRaXWFjztYmklQieaZ/zq+pUuUDtBZo95rUP20E56gYV2XFB18W YeekTwH5d2d/j++60iHExWTB+sgMEv3CEGikUBj7iaMX2KtaB1k9K+3K6dx/s1KWxOClFkbJ EV/tmeq7Ta8LiytQM9b4yY550tzC0pEEeFcLFXo1m5KcJauYnAqrlOVY48NFpFUd9oAZf/Pz p3oEs+zn/8zK2PBrZZCD6AhrbotRy7irE5eimhxcsFm1+MG5ufnaQUWHrRYXVuFhvkSoqZ8j GPgPEpFor4NjRyX/PMLglQ7S5snkvKcr3Lun44aybXEHq/1FTzW2kOh6kFHFFOPbMv1voJKM IzrmDoDS+xANt/La7OwpCylCgF6t9oHHTTGfAfwtfYZbiepC66FDe/Jt/QLwkIXeIoeSS1O4 6rJdGWG2kHthUM+uIbUbaRJW8AkJpzP1Mz7TieR/9jO4YPeUm9tGL5kP2yyNtzFilcoOeox1 NSFNAPz+zPcovVmxAaSDGcSzhQVJVlk8xPib8g4fnI8qJ3Gj7xyw8D9dzxhCR2DIFmZL84En N7Rj+k4VIGY7M/cVvxL81jlbMGMERMmb96Cua9z1ROviGA1He2gbHOcp6qmLNu3nprleG8PL ZRNdEAC0iZapoyiXlVCKLFIwUPnxUz5iarqIfQU8sa1VXYYd/AAAFI6Wv3zfNtGicjgHP8rN CIegqm2Av1939XXGZJVI9f3hEoUn04rvxCgcDcUvn7I0WTZ4JB9G5qAGvQLXeXK6Byu77qTx eC7PUIIEKN3X47e8xTSj2reVTlanDr8yeqZhxpKHaS0laF8RbD85geZtAK67qEByX2KC9DUo eHBFuXpYMzGQnf2SG105ePI2f4h5iAfbTW9VWH989fx4f2hVlDwTe08/NhPdwq/Houov9f/+ uPpYEMlHCNwE8GRV7aEjd/dvu87PQPm4zFtC3jgQaUKCbYYlHmYYRlrLQenX3QSorrQNPbfz uQkNLDVcjgD2fxBpemT7EhHYBz+ugsfbtdsH+4jVCo5WLb/HxE6o5zvSIkXknWh1DhFj/qe9 Zb9PGmfp8T8Ty+c/hjE5x6SrkRCX8qPXIvfSWLlb8M0lpcpFK+tB+kZlu5I3ycQDNLTk3qmf PdjUMWb5Ld21PSyCrtGc/hTKwxMoHsOZPy6UB8YJ5omZdsavcjKMrDpybguOfxUmGYs2H3MJ ghIUQMMOe0267uQcmMNDPRueGWTLXcuyz0Tpe62Whekc3gNMl0JrNz6Gty8OBb/ETijfSHPE qGHYuyAZJo9A/IazHuJ+4n+gm4kQl1WLfxoRMzYHCA== In-Reply-To: <20250715102513.5636-39-jose.exposito89@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdehjeeiiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpefnohhuihhsucevhhgruhhvvghtuceolhhouhhishdrtghhrghuvhgvthessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepkeeivedtfeegtdekheethedttddtfefhhfegjeeljeejleduvdfhudegvdekheevnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppedvtddtudemkeeiudemgedugedtmegtkeeitdemheguiedumeeifeefleemieeirgeimegvtdejheenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepihhnvghtpedvtddtudemkeeiudemgedugedtmegtkeeitdemheguiedumeeifeefleemieeirgeimegvtdejhedphhgvlhhopeglkffrggeimedvtddtudemkeeiudemgedugedtmegtkeeitdemheguiedumeeifeefleemieeirgeimegvtdejhegnpdhmrghilhhfrhhomheplhhouhhishdrtghhrghuvhgvthessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedprhgtphhtthhopehjohhsvgdrvgigphhoshhithhokeelsehgmhgrihhlrdgtohhmpdhrtghpthhtohepihhgthdqu ggvvheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrghdprhgtphhtthhopeiisghighhnihgvfidrkhgvmhhptgiihihnshhkihesihhnthgvlhdrtghomh X-GND-Sasl: louis.chauvet@bootlin.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Le 15/07/2025 à 12:25, José Expósito a écrit : > Test that, once a VKMS device is enabled, the CRTC values can't change > and that deleting it or the attached planes/encoders doesn't change the > VKMS device. > > Signed-off-by: José Expósito Reviewed-by: Louis Chauvet > --- > lib/igt_vkms.c | 12 +++++++++ > lib/igt_vkms.h | 1 + > tests/vkms/vkms_configfs.c | 55 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 68 insertions(+) > > diff --git a/lib/igt_vkms.c b/lib/igt_vkms.c > index 96f13d628..5923e8527 100644 > --- a/lib/igt_vkms.c > +++ b/lib/igt_vkms.c > @@ -804,6 +804,18 @@ void igt_vkms_device_add_crtc(igt_vkms_t *dev, const char *name) > add_pipeline_item(dev, VKMS_PIPELINE_ITEM_CRTC, name); > } > > +/** > + * igt_vkms_device_remove_crtc: > + * @dev: Device to remove the CRTC from > + * @name: CRTC name > + * > + * Remove an existing CRTC from the VKMS device. > + */ > +bool igt_vkms_device_remove_crtc(igt_vkms_t *dev, const char *name) > +{ > + return remove_pipeline_item(dev, VKMS_PIPELINE_ITEM_CRTC, name); > +} > + > /** > * igt_vkms_crtc_is_writeback_enabled: > * @dev: Device the CRTC belongs to > diff --git a/lib/igt_vkms.h b/lib/igt_vkms.h > index 786db224e..9785a64e9 100644 > --- a/lib/igt_vkms.h > +++ b/lib/igt_vkms.h > @@ -105,6 +105,7 @@ bool igt_vkms_plane_detach_crtc(igt_vkms_t *dev, const char *plane_name, > const char *crtc_name); > > void igt_vkms_device_add_crtc(igt_vkms_t *dev, const char *name); > +bool igt_vkms_device_remove_crtc(igt_vkms_t *dev, const char *name); > bool igt_vkms_crtc_is_writeback_enabled(igt_vkms_t *dev, const char *name); > void igt_vkms_crtc_set_writeback_enabled(igt_vkms_t *dev, const char *name, > bool writeback); > diff --git a/tests/vkms/vkms_configfs.c b/tests/vkms/vkms_configfs.c > index 11dea86ed..62dfb99be 100644 > --- a/tests/vkms/vkms_configfs.c > +++ b/tests/vkms/vkms_configfs.c > @@ -1635,6 +1635,60 @@ static void test_enabled_plane_cannot_change(void) > igt_vkms_device_destroy(dev); > } > > +/** > + * SUBTEST: enabled-crtc-cannot-change > + * Description: Test that, once a VKMS device is enabled, the CRTC values can't > + * change and that deleting it or the attached planes/encoders > + * doesn't change the VKMS device. > + */ > + > +static void test_enabled_crtc_cannot_change(void) > +{ > + igt_vkms_t *dev; > + > + igt_vkms_config_t cfg = { > + .device_name = __func__, > + .planes = { > + { > + .name = "plane0", > + .type = DRM_PLANE_TYPE_PRIMARY, > + .possible_crtcs = { "crtc0"}, > + }, > + }, > + .crtcs = { > + { .name = "crtc0", .writeback = true }, > + }, > + .encoders = { > + { .name = "encoder0", .possible_crtcs = { "crtc0" } }, > + }, > + .connectors = { > + { > + .name = "connector0", > + .possible_encoders = { "encoder0" }, > + }, > + }, > + }; > + > + dev = igt_vkms_device_create_from_config(&cfg); > + igt_assert(dev); > + > + igt_vkms_device_set_enabled(dev, true); > + igt_assert(igt_vkms_device_is_enabled(dev)); > + assert_device_config(&cfg); > + > + /* Try to change values */ > + igt_vkms_crtc_set_writeback_enabled(dev, "crtc0", false); > + igt_assert(igt_vkms_crtc_is_writeback_enabled(dev, "crtc0")); > + > + /* Deleting pipeline items doesn't affect the device */ > + igt_assert(igt_vkms_plane_detach_crtc(dev, "plane0", "crtc0")); > + igt_assert(igt_vkms_encoder_detach_crtc(dev, "encoder0", "crtc0")); > + igt_assert(igt_vkms_device_remove_crtc(dev, "crtc0")); > + assert_device_config(&cfg); > + > + igt_vkms_device_destroy(dev); > +} > + > igt_main > { > struct { > @@ -1676,6 +1730,7 @@ igt_main > { "enable-no-connectors", test_enable_no_connectors }, > { "enable-too-many-connectors", test_enable_too_many_connectors }, > { "enabled-plane-cannot-change", test_enabled_plane_cannot_change }, > + { "enabled-crtc-cannot-change", test_enabled_crtc_cannot_change }, > }; > > igt_fixture { -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com