From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: Suppress a few intentional redundant whitespaces
Date: Wed, 16 Sep 2026 22:52:35 +0200 [thread overview]
Message-ID: <c2dca0c1-6dd3-4601-be2f-e5409518bedd@kernel.org> (raw)
In-Reply-To: <20260916-b4-dts-style-checker-suppress-v1-2-81b86685d068@oss.qualcomm.com>
On 16/09/2026 22:46, Krzysztof Kozlowski wrote:
> Ignore redundant whitespaces in a few places to suppress warnings from
> `dt-check-style --mode relaxed` like:
>
> sc7280-herobrine.dtsi:357: [redundant-whitespace] extra whitespace after :
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 6 ++++++
> arch/arm64/boot/dts/qcom/sm8750.dtsi | 4 ++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 58ea0532c0fb..21179ca1219b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -354,11 +354,13 @@ keyboard_backlight: led-0 {
> pp1256_s8b: &vreg_s8b_1p256 {};
>
> pp1800_l18b_s0: &vreg_l18b_1p8 {};
> +/* dt-check-style disable=redundant-whitespace */
> pp1800_l18b: &vreg_l18b_1p8 {};
>
> vreg_l19b_s0: &vreg_l19b_1p8 {};
>
> pp1800_alc5682: &vreg_l2c_1p8 {};
> +/* dt-check-style disable=redundant-whitespace */
> pp1800_l2c: &vreg_l2c_1p8 {};
>
> vreg_l4c: &vreg_l4c_1p8_3p0 {};
> @@ -368,14 +370,17 @@ keyboard_backlight: led-0 {
> pp3000_l7c: &vreg_l7c_3p0 {};
>
> pp1800_prox: &vreg_l8c_1p8 {};
> +/* dt-check-style disable=redundant-whitespace */
> pp1800_l8c: &vreg_l8c_1p8 {};
>
> pp2950_l9c: &vreg_l9c_2p96 {};
>
> +/* dt-check-style disable=redundant-whitespace */
> pp1800_lcm: &vreg_l12c_1p8 {};
> pp1800_mipi: &vreg_l12c_1p8 {};
> pp1800_l12c: &vreg_l12c_1p8 {};
>
> +/* dt-check-style disable=redundant-whitespace */
> pp3300_lcm: &vreg_l13c_3p0 {};
> pp3300_mipi: &vreg_l13c_3p0 {};
> pp3300_l13c: &vreg_l13c_3p0 {};
> @@ -384,6 +389,7 @@ keyboard_backlight: led-0 {
>
> vreg_edp_bl: &ppvar_sys {};
>
> +/* dt-check-style disable=redundant-whitespace */
> ts_avdd: &pp3300_left_in_mlb {};
> vreg_edp_3p3: &pp3300_left_in_mlb {};
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index ed3d29e13021..afeb6e57e0aa 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -2480,6 +2480,7 @@ swr3: soundwire@6ab0000 {
> qcom,din-ports = <4>;
> qcom,dout-ports = <9>;
>
> + /* dt-check-style disable=redundant-whitespace-strict */
> qcom,ports-sinterval = /bits/ 16 <0x07 0x1f 0x3f 0x07 0x1f 0x3f 0x18f 0x18f 0x18f 0x0f 0x0f 0xff 0x31f>;
The comment should be placed before node and is not really important
here, because it is from 'strict' ruleset, unlike the herobrine ones.
I should have called this RFC to show intentions and whether this is the
code we would like to maintain.
> qcom,ports-offset1 = /bits/ 8 <0x01 0x03 0x05 0x02 0x04 0x15 0x00 0x00 0x00 0x06 0x0d 0xff 0x00>;
> qcom,ports-offset2 = /bits/ 8 <0xff 0x07 0x1f 0xff 0x07 0x1f 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-16 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 20:46 [PATCH 0/3] dtc: dt-check-style: Introduce way to disable checks Krzysztof Kozlowski
2026-09-16 20:46 ` [PATCH 1/3] " Krzysztof Kozlowski
2026-09-16 20:46 ` [PATCH 2/3] arm64: dts: qcom: Suppress a few intentional redundant whitespaces Krzysztof Kozlowski
2026-09-16 20:52 ` Krzysztof Kozlowski [this message]
2026-09-16 20:46 ` [PATCH 3/3] arm64: dts: exynos5433: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2dca0c1-6dd3-4601-be2f-e5409518bedd@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.