From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
ljs@kernel.org, liam@infradead.org, vbabka@kernel.org,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
shuah@kernel.org
Subject: Re: [PATCH] kselftest: mm: remove exclusion of building soft-dirty test in arm64
Date: Fri, 11 Sep 2026 19:53:45 +0200 [thread overview]
Message-ID: <c2eeb782-a426-4cc1-9231-846db5939803@kernel.org> (raw)
In-Reply-To: <aqQrIkcPf6uMlouk@e129823.arm.com>
On 9/11/26 18:24, Yeoreum Yun wrote:
>> On 9/11/26 14:50, Yeoreum Yun wrote:
>>> Since commit 0389c305ef56 (“selftests/mm: skip soft-dirty tests when CONFIG_MEM_SOFT_DIRTY is disabled”),
>>> the soft-dirty test is skipped when soft-dirty is not supported.
>>>
>>> There is therefore no reason to exclude the test from being built on
>>> arm64. Remove the arm64-specific exclusion.
>>>
>>> Suggested-by: David Hildenbrand (Arm) <david@kernel.org>
>>> Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
>>> ---
>>> tools/testing/selftests/mm/Makefile | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
>>> index 2d5366196e30..d3e9bd67904a 100644
>>> --- a/tools/testing/selftests/mm/Makefile
>>> +++ b/tools/testing/selftests/mm/Makefile
>>> @@ -104,10 +104,7 @@ TEST_GEN_FILES += guard-regions
>>> TEST_GEN_FILES += merge
>>> TEST_GEN_FILES += rmap
>>> TEST_GEN_FILES += folio_split_race_test
>>> -
>>> -ifneq ($(ARCH),arm64)
>>> TEST_GEN_FILES += soft-dirty
>>> -endif
>>>
>>> ifeq ($(ARCH),x86_64)
>>> CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_32bit_program.c -m32)
>>
>> Does that mean we can also the following?
>>
>> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
>> index d09f9f6a384ee..33963535616b2 100755
>> --- a/tools/testing/selftests/mm/run_vmtests.sh
>> +++ b/tools/testing/selftests/mm/run_vmtests.sh
>> @@ -390,10 +390,7 @@ then
>> CATEGORY="pkey" run_test ./protection_keys_64
>> fi
>>
>> -if [ -x ./soft-dirty ]
>> -then
>> - CATEGORY="soft_dirty" run_test ./soft-dirty
>> -fi
>> +CATEGORY="soft_dirty" run_test ./soft-dirty
>>
>> CATEGORY="pagemap" run_test ./pagemap_ioctl
>
> Ah right. since all archs have the soft-dirty, we can remove the if
> condition.
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
With that, thanks!
--
Cheers,
David
next prev parent reply other threads:[~2026-09-11 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 12:50 [PATCH] kselftest: mm: remove exclusion of building soft-dirty test in arm64 Yeoreum Yun
2026-09-11 15:00 ` David Hildenbrand (Arm)
2026-09-11 16:24 ` Yeoreum Yun
2026-09-11 17:53 ` David Hildenbrand (Arm) [this message]
2026-09-11 15:04 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2eeb782-a426-4cc1-9231-846db5939803@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.