From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:610b:b0:1be9:327d:8ee3 with SMTP id tt11csp7333376njc; Tue, 12 Nov 2024 05:36:42 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUlRUia/0UDCAcD+aEnM7Q7ffb680CEtu3JAhtHVZWkcszaMkKVJVk2ROy1F2suRjI+UVS823QKX3Urhw==@linaro.org X-Google-Smtp-Source: AGHT+IFPp4ZGtCZOMdTRGLGLwQd+5vAmiY6MaysVmRG+JdTQEfpn4k1LsW3LtN1568JU4Fs3/maI X-Received: by 2002:a05:6214:4686:b0:6d3:9c7b:9384 with SMTP id 6a1803df08f44-6d39e1ff520mr281527846d6.42.1731418602528; Tue, 12 Nov 2024 05:36:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731418602; cv=none; d=google.com; s=arc-20240605; b=az3MzrNeTsBWj5g9l+AZiycdmhf1IYgF+zELCgXgmfp9tvvNN/5/X8K+gk6hiCTLdu 2UE4p7DQKkOVCj5b/A4HOCL2jdoLulh2sxxUfEsZWZV+SvWN1ksKFvaQvn0Y6HN5Ve+k vW7WlGrRKz6HwCuCj4q5yuGq60VycNxAPbBN5ze+4scjtzTUw9aEB6uiUdFor2domf93 ao0OgmNs9rm+M2zgmHJ/RDM1Sj5mw9xn3h+x3FSlcpcXqUhUO7nW5XKwK8j1z60wqfpg 76iGJfmMmytBWRJpk7yF0irQ2bET27c3tJBFwAexr6xJplbIViIkS7L61CY9WBE2OIR4 dnxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :content-language:in-reply-to:autocrypt:from:references:cc:to :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=pKzBLcMcXHy5XpA8wTRqmi6vMEHO+sLY8chTa4yGjVk=; fh=4iIu/yFnlAy+oJ4+2fKeTdG+T67L3RoxqRWu0xbDVTc=; b=NBMdzL3eykSNYFueXIiuTW6FYB7Wgofe59Rfca3NY9eUumH2dSBab55IxWawec2D9q M1rxAXU6QS4ykcf/exUSsDkHxZp1Y4oKrtO858AyoZ7QcQtVKWuZZg3gwifX8JDZxsYQ BDgwDHWkfme5NmshR9opqJdSfyuuIhMwM5gFe6MraToIP7PKrrqXYJM5/Kx/DLZ/CXNs XgB/t6INjAc6cvqphmtqdpEmzu61JSCTI12XzzdH6UvmhHwRJw0wc2LGYUyLjPQxWE3L 6skFQEVhS84U4JAZzSGgVKx0wi/+EhyD8fJmypch0SOVJvuf5hYlhvKpNBceI4hy9gYh UV+g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FpZflWh3; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-462ff457bb7si130393911cf.169.2024.11.12.05.36.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2024 05:36:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FpZflWh3; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAr4J-0006q4-By; Tue, 12 Nov 2024 08:36:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAr4E-0006of-SL for qemu-arm@nongnu.org; Tue, 12 Nov 2024 08:36:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAr4B-0001K9-Tv for qemu-arm@nongnu.org; Tue, 12 Nov 2024 08:36:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731418581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pKzBLcMcXHy5XpA8wTRqmi6vMEHO+sLY8chTa4yGjVk=; b=FpZflWh31Ns9T8ltGAybZPLSgYN5IhkewzYZSyr85+QGHzwBthgcB0Fmz7eUGhr3UOCjao /fNkyKce6B28N5/NVQH7lFuWJHMBEuo0j/KxKiUWhotoLn8RALm1OuTh2rISBrN/4KG3DJ eYdeWMOv889FXZshp5O1A4FLgUnf9CE= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-PliIVNpWMPGinjev1nFdHw-1; Tue, 12 Nov 2024 08:36:19 -0500 X-MC-Unique: PliIVNpWMPGinjev1nFdHw-1 X-Mimecast-MFC-AGG-ID: PliIVNpWMPGinjev1nFdHw Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-71819315532so4906468a34.2 for ; Tue, 12 Nov 2024 05:36:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731418578; x=1732023378; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pKzBLcMcXHy5XpA8wTRqmi6vMEHO+sLY8chTa4yGjVk=; b=ma0XJYes4s9G/bguy+ijXQDE2Eavz8tXFUUwqjcID41jL0bWvDjTHewWIzKU6DoZ+/ GYV2+9L+fOdoZ86L2x0sJKFs4Q0DR76miK4LS/B8TyspbQZd6MagI7yIBQ0dc7JhAWpc dgFSslIgH9dIISud4QQ22xuYwN//yDZDZbVyXs+I81IkEshBq5WIk5kqVE7lkgzIR3Ag YtM4xkWbfrawoZXWyadq/lprhZ8xF+1JKyBc5S+Zv7dqH8YrWsaN9cHu+GkSDiv62BRS 1Gn/8EwmcCO2nDGlE7E5okJtz0CQc47ldxZUpf4Fa30clyHV7D990g2AYSbBLKjJF3bc 340Q== X-Forwarded-Encrypted: i=1; AJvYcCVN9byn8RlSfooxIRrFsos+65z2klU84aRw+cV+StwhR9i5Eofxe0jVzcWGQrKyl06dkjL2oAWVSA==@nongnu.org X-Gm-Message-State: AOJu0Yz1bMJiqRG04o7DM+CPVSbaVA3pLy765tTHStn6BrwkTJlBlZHp hL4WbDYm12nL4ZUNZS2+Fc1TR48rX/b+PlvgCxX2WHxi/6CgqA8e76u7nPG6XablR+7uwIozsnU Q2hQaP42vDpkoxUFwU1X6uVWH4CrZE4u1VxQMRY9KMa6B1ohc5Q== X-Received: by 2002:a05:6358:d047:b0:1c3:81a4:d0f7 with SMTP id e5c5f4694b2df-1c641f66142mr640595855d.22.1731418578609; Tue, 12 Nov 2024 05:36:18 -0800 (PST) X-Received: by 2002:a05:6358:d047:b0:1c3:81a4:d0f7 with SMTP id e5c5f4694b2df-1c641f66142mr640593955d.22.1731418578239; Tue, 12 Nov 2024 05:36:18 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-49-115.web.vodafone.de. [109.42.49.115]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d39643aeb2sm71326836d6.80.2024.11.12.05.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 05:36:17 -0800 (PST) Message-ID: Date: Tue, 12 Nov 2024 14:36:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] tests/functional: Remove sleep workarounds from Aspeed tests To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= References: <20241112130246.970281-1-clg@redhat.com> <20241112130246.970281-5-clg@redhat.com> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20241112130246.970281-5-clg@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hpDpxZEK8tRfnyfWT1t8tSvt3ZU60p2U1ubFB0rO87U_1731418578 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.122, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: siksYWnDqxlq On 12/11/2024 14.02, Cédric Le Goater wrote: > These were introduced in the avocado tests to workaround read issues > when interacting with console. They are no longer necessary and we can > use the expected "login:" string now. > > Signed-off-by: Cédric Le Goater > --- > tests/functional/test_arm_aspeed.py | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/tests/functional/test_arm_aspeed.py b/tests/functional/test_arm_aspeed.py > index 7644ecbae750..2c9009f686fd 100755 > --- a/tests/functional/test_arm_aspeed.py > +++ b/tests/functional/test_arm_aspeed.py > @@ -136,10 +136,8 @@ def do_test_arm_aspeed_buildroot_start(self, image, cpu_id, pattern='Aspeed EVB' > self.wait_for_console_pattern('lease of 10.0.2.15') > # the line before login: > self.wait_for_console_pattern(pattern) > - time.sleep(0.1) > - exec_command(self, 'root') > - time.sleep(0.1) > - exec_command(self, "passw0rd") > + exec_command_and_wait_for_pattern(self, 'root', 'Password:') > + exec_command_and_wait_for_pattern(self, 'passw0rd', '#') > > def do_test_arm_aspeed_buildroot_poweroff(self): > exec_command_and_wait_for_pattern(self, 'poweroff', > @@ -158,7 +156,7 @@ def test_arm_ast2500_evb_buildroot(self): > self.vm.add_args('-device', > 'tmp105,bus=aspeed.i2c.bus.3,address=0x4d,id=tmp-test'); > self.do_test_arm_aspeed_buildroot_start(image_path, '0x0', > - 'Aspeed AST2500 EVB') > + 'ast2500-evb login:') > > exec_command_and_wait_for_pattern(self, > 'echo lm75 0x4d > /sys/class/i2c-dev/i2c-3/device/new_device', > @@ -188,7 +186,8 @@ def test_arm_ast2600_evb_buildroot(self): > 'ds1338,bus=aspeed.i2c.bus.3,address=0x32'); > self.vm.add_args('-device', > 'i2c-echo,bus=aspeed.i2c.bus.3,address=0x42'); > - self.do_test_arm_aspeed_buildroot_start(image_path, '0xf00', 'Aspeed AST2600 EVB') > + self.do_test_arm_aspeed_buildroot_start(image_path, '0xf00', > + 'ast2600-evb login:') > > exec_command_and_wait_for_pattern(self, > 'echo lm75 0x4d > /sys/class/i2c-dev/i2c-3/device/new_device', > @@ -210,7 +209,6 @@ def test_arm_ast2600_evb_buildroot(self): > 'echo slave-24c02 0x1064 > /sys/bus/i2c/devices/i2c-3/new_device', > 'i2c i2c-3: new_device: Instantiated device slave-24c02 at 0x64'); > exec_command(self, 'i2cset -y 3 0x42 0x64 0x00 0xaa i'); Could we please wait for the shell prompt here now? i.e.: exec_command_and_wait_for_pattern(self, 'i2cset -y 3 0x42 0x64 0x00 0xaa i', '#') or something similar? With such a fix included: Reviewed-by: Thomas Huth > - time.sleep(0.1) > exec_command_and_wait_for_pattern(self, > 'hexdump /sys/bus/i2c/devices/3-1064/slave-eeprom', > '0000000 ffaa ffff ffff ffff ffff ffff ffff ffff');