From: Reinette Chatre <reinette.chatre@intel.com>
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
<fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
<yanjiewtw@gmail.com>, <kim.phillips@amd.com>,
<lukas.bulwahn@gmail.com>, <seanjc@google.com>,
<jmattson@google.com>, <leitao@debian.org>, <jpoimboe@kernel.org>,
<rick.p.edgecombe@intel.com>, <kirill.shutemov@linux.intel.com>,
<jithu.joseph@intel.com>, <kai.huang@intel.com>,
<kan.liang@linux.intel.com>, <daniel.sneddon@linux.intel.com>,
<pbonzini@redhat.com>, <sandipan.das@amd.com>,
<ilpo.jarvinen@linux.intel.com>, <peternewman@google.com>,
<maciej.wieczor-retman@intel.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <eranian@google.com>,
<james.morse@arm.com>
Subject: Re: [PATCH v5 05/20] x86/resctrl: Introduce resctrl_file_fflags_init() to initialize fflags
Date: Fri, 12 Jul 2024 15:04:42 -0700 [thread overview]
Message-ID: <c304fc0e-63bf-490e-980e-960520a3ecfc@intel.com> (raw)
In-Reply-To: <9176ca716368fb433c956ae72d70f0f16278248a.1720043311.git.babu.moger@amd.com>
Hi Babu,
On 7/3/24 2:48 PM, Babu Moger wrote:
> thread_throttle_mode_init() and mbm_config_rftype_init() both initialize
> fflags for resctrl files.
>
> Adding new files will involve adding another function to initialize
> the fflags. This can be simplified by adding a new function
> resctrl_file_fflags_init() and passing the file name and flags
> to be initialized.
>
> Consolidate fflags initialization into resctrl_file_fflags_init() and
> remove thread_throttle_mode_init() and mbm_config_rftype_init().
>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2024-07-12 22:05 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:48 [PATCH v5 00/20] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2024-07-03 21:48 ` [PATCH v5 01/20] x86/cpufeatures: Add support for " Babu Moger
2024-07-12 21:55 ` Reinette Chatre
2024-07-15 18:36 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 02/20] x86/resctrl: Add ABMC feature in the command line options Babu Moger
2024-07-03 21:48 ` [PATCH v5 03/20] x86/resctrl: Consolidate monitoring related data from rdt_resource Babu Moger
2024-07-12 21:57 ` Reinette Chatre
2024-07-15 19:05 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 04/20] x86/resctrl: Detect Assignable Bandwidth Monitoring feature details Babu Moger
2024-07-12 22:04 ` Reinette Chatre
2024-07-15 20:04 ` Moger, Babu
2024-07-16 15:11 ` Reinette Chatre
2024-07-03 21:48 ` [PATCH v5 05/20] x86/resctrl: Introduce resctrl_file_fflags_init() to initialize fflags Babu Moger
2024-07-12 22:04 ` Reinette Chatre [this message]
2024-07-03 21:48 ` [PATCH v5 06/20] x86/resctrl: Add support to enable/disable AMD ABMC feature Babu Moger
2024-07-12 22:05 ` Reinette Chatre
2024-07-16 15:13 ` Moger, Babu
2024-07-16 17:51 ` Reinette Chatre
2024-07-16 18:48 ` Moger, Babu
2024-07-16 20:41 ` Reinette Chatre
2024-07-18 21:11 ` Moger, Babu
2024-08-16 16:29 ` James Morse
2024-07-03 21:48 ` [PATCH v5 07/20] x86/resctrl: Introduce the interface to display monitor mode Babu Moger
2024-07-12 22:06 ` Reinette Chatre
2024-07-16 16:51 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 08/20] x86/resctrl: Introduce interface to display number of monitoring counters Babu Moger
2024-07-03 21:48 ` [PATCH v5 09/20] x86/resctrl: Initialize monitor counters bitmap Babu Moger
2024-07-12 22:07 ` Reinette Chatre
2024-07-16 17:59 ` Moger, Babu
2024-07-26 22:48 ` Peter Newman
2024-07-26 23:53 ` Moger, Babu
2024-08-01 21:05 ` Reinette Chatre
2024-07-03 21:48 ` [PATCH v5 10/20] x86/resctrl: Introduce mbm_total_cfg and mbm_local_cfg Babu Moger
2024-07-12 22:08 ` Reinette Chatre
2024-07-16 19:21 ` Moger, Babu
2024-07-16 20:42 ` Reinette Chatre
2024-07-16 22:43 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 11/20] x86/resctrl: Remove MSR reading of event configuration value Babu Moger
2024-07-12 22:10 ` Reinette Chatre
2024-07-16 19:34 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 12/20] x86/resctrl: Add data structures and definitions for ABMC assignment Babu Moger
2024-07-12 22:13 ` Reinette Chatre
2024-07-16 20:24 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 13/20] x86/resctrl: Add the interface to assign hardware counter Babu Moger
2024-07-12 22:09 ` Reinette Chatre
2024-07-16 20:45 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 14/20] x86/resctrl: Add the interface to unassign " Babu Moger
2024-07-03 21:48 ` [PATCH v5 15/20] x86/resctrl: Assign/unassign counters by default when ABMC is enabled Babu Moger
2024-07-12 22:10 ` Reinette Chatre
2024-07-16 20:58 ` Moger, Babu
2024-07-26 23:22 ` Peter Newman
2024-07-26 23:57 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 16/20] x86/resctrl: Report "Unassigned" for MBM events in ABMC mode Babu Moger
2024-07-12 22:13 ` Reinette Chatre
2024-07-16 21:04 ` Moger, Babu
2024-07-13 20:26 ` Markus Elfring
2024-07-03 21:48 ` [PATCH v5 17/20] x86/resctrl: Introduce the interface switch between monitor modes Babu Moger
2024-07-12 22:14 ` Reinette Chatre
2024-07-16 22:46 ` Moger, Babu
2024-07-13 7:15 ` Markus Elfring
2024-07-03 21:48 ` [PATCH v5 18/20] x86/resctrl: Enable AMD ABMC feature by default when supported Babu Moger
2024-07-12 22:15 ` Reinette Chatre
2024-07-16 23:23 ` Moger, Babu
2024-07-26 0:16 ` Moger, Babu
2024-08-01 21:40 ` Reinette Chatre
2024-07-03 21:48 ` [PATCH v5 19/20] x86/resctrl: Introduce interface to list monitor states of all the groups Babu Moger
2024-07-12 22:16 ` Reinette Chatre
2024-07-17 15:22 ` Moger, Babu
2024-08-01 21:37 ` Reinette Chatre
2024-08-02 16:10 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 20/20] x86/resctrl: Introduce interface to modify assignment states of " Babu Moger
2024-07-12 22:17 ` Reinette Chatre
2024-07-17 16:22 ` Moger, Babu
2024-07-25 0:03 ` Peter Newman
2024-07-25 1:22 ` Moger, Babu
2024-07-25 17:11 ` Peter Newman
2024-07-25 17:28 ` Moger, Babu
2024-08-01 18:56 ` Reinette Chatre
2024-08-01 19:40 ` Moger, Babu
2024-07-12 22:03 ` [PATCH v5 00/20] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Reinette Chatre
2024-07-17 17:19 ` Moger, Babu
2024-08-01 21:49 ` Reinette Chatre
2024-08-01 22:45 ` Peter Newman
2024-08-02 16:13 ` Reinette Chatre
2024-08-02 18:49 ` Moger, Babu
2024-08-02 19:13 ` Peter Newman
2024-08-02 20:23 ` Moger, Babu
2024-08-02 18:49 ` Peter Newman
2024-08-02 20:38 ` Moger, Babu
2024-08-02 20:55 ` Reinette Chatre
2024-08-02 22:50 ` Peter Newman
2024-08-14 17:37 ` Reinette Chatre
2024-08-15 23:06 ` Peter Newman
2024-08-16 1:45 ` Reinette Chatre
2024-08-03 0:49 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c304fc0e-63bf-490e-980e-960520a3ecfc@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=jithu.joseph@intel.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.