From: Markus Elfring <Markus.Elfring@web.de>
To: "Al Viro" <viro@zeniv.linux.org.uk>,
virtualization@lists.linux.dev, kvm@vger.kernel.org,
netdev@vger.kernel.org, "Eugenio Pérez" <eperezma@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get_config()
Date: Thu, 26 Sep 2024 08:04:06 +0200 [thread overview]
Message-ID: <c32f24e8-9e4e-4ee5-9b5d-276dc99ace9f@web.de> (raw)
In-Reply-To: <20240925205005.GL3550746@ZenIV>
>> Assign the return value from a copy_to_user() call to an additional
>> local variable so that a kvfree() call and return statement can be
>> omitted accordingly.
>
> Ugly and unidiomatic.
>
>> This issue was detected by using the Coccinelle software.
>
> What issue?
Opportunities for the reduction of duplicate source code.
Regards,
Markus
prev parent reply other threads:[~2024-09-26 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:48 [PATCH] vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get_config() Markus Elfring
2024-09-25 20:50 ` Al Viro
2024-09-26 6:04 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32f24e8-9e4e-4ee5-9b5d-276dc99ace9f@web.de \
--to=markus.elfring@web.de \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.