All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhishek Sahu <absahu@codeaurora.org>
To: "Christ, Austin" <austinwc@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	David Brown <david.brown@linaro.org>,
	Sricharan R <sricharan@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] i2c: qup: reorganization of driver code to remove polling for qup v2
Date: Mon, 12 Mar 2018 19:28:55 +0530	[thread overview]
Message-ID: <c339f16e2459a7a2d757d6ca75691908@codeaurora.org> (raw)
In-Reply-To: <a5257c10-c6f1-13e6-2281-977698793158@codeaurora.org>

<snip>

>>   static void qup_i2c_set_blk_event(struct qup_i2c_dev *qup, bool 
>> is_rx)
>>   {
>>   	qup->cur_blk_events = 0;
>> @@ -1442,13 +1155,452 @@ static int qup_i2c_xfer(struct i2c_adapter 
>> *adap,
>>   	return ret;
>>   }
>>   +/*
>> + * Function to configure registers related with reconfiguration 
>> during run
>> + * and will be done before each I2C sub transfer.
>> + */
> Consider changing comment style to remove the word "Function" and
> state the operation in simple present tense.
> 
> "Function to configure ..." would be "Configure ..."
> 
> Same comment for all comments of this style below.
> 


  Thanks Austin.

  I have done the changes for comments styles in v2

  https://lkml.org/lkml/2018/3/12/421

  Regards,
  Abhishek

      reply	other threads:[~2018-03-12 13:58 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-03  7:58 [PATCH 00/12] Major code reorganization to make all i2c transfers working Abhishek Sahu
2018-02-03  7:58 ` [PATCH 01/12] i2c: qup: fixed releasing dma without flush operation completion Abhishek Sahu
2018-02-08 14:03   ` Sricharan R
2018-02-19 10:24     ` Abhishek Sahu
2018-02-27 21:46   ` Christ, Austin
2018-02-27 22:24   ` Andy Gross
2018-02-03  7:58 ` [PATCH 02/12] i2c: qup: minor code reorganization for use_dma Abhishek Sahu
2018-02-27 21:48   ` Christ, Austin
2018-02-27 22:26   ` Andy Gross
2018-02-03  7:58 ` [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count Abhishek Sahu
2018-02-09  2:16   ` Sricharan R
2018-02-19 10:26     ` Abhishek Sahu
2018-02-27 21:51   ` Christ, Austin
2018-02-27 22:28   ` Andy Gross
2018-02-03  7:58 ` [PATCH 04/12] i2c: qup: schedule EOT and FLUSH tags at the end of transfer Abhishek Sahu
2018-02-15 14:31   ` Sricharan R
2018-02-19 10:34     ` Abhishek Sahu
2018-02-27 22:36   ` Andy Gross
2018-03-08 13:40     ` Abhishek Sahu
2018-02-03  7:58 ` [PATCH 05/12] i2c: qup: fix the transfer length for BAM rx EOT FLUSH tags Abhishek Sahu
2018-02-27 22:38   ` Andy Gross
2018-02-03  7:58 ` [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode Abhishek Sahu
2018-02-16  4:33   ` Sricharan R
2018-02-27 22:00   ` Christ, Austin
2018-02-27 22:58   ` Andy Gross
2018-03-12 12:34     ` Abhishek Sahu
2018-02-03  7:58 ` [PATCH 07/12] i2c: qup: use the complete transfer length to choose DMA mode Abhishek Sahu
2018-02-16  4:35   ` Sricharan R
2018-02-19 10:49     ` Abhishek Sahu
2018-02-27 22:01   ` Christ, Austin
2018-02-27 22:59   ` Andy Gross
2018-02-03  7:58 ` [PATCH 08/12] i2c: qup: change completion timeout according to transfer length Abhishek Sahu
2018-02-16  4:48   ` Sricharan R
2018-02-19 10:56     ` Abhishek Sahu
2018-02-27 23:05       ` Andy Gross
2018-02-03  7:58 ` [PATCH 09/12] i2c: qup: fix buffer overflow for multiple msg of maximum xfer len Abhishek Sahu
2018-02-16  5:21   ` Sricharan R
2018-02-19 11:24     ` Abhishek Sahu
2018-02-27 22:06   ` Christ, Austin
2018-03-12 13:55     ` Abhishek Sahu
2018-02-27 23:15   ` Andy Gross
2018-03-12 12:28     ` Abhishek Sahu
2018-02-03  7:58 ` [PATCH 10/12] i2c: qup: send NACK for last read sub transfers Abhishek Sahu
2018-02-16  5:39   ` Sricharan R
2018-02-27 22:07   ` Christ, Austin
2018-02-27 23:17   ` Andy Gross
2018-02-03  7:58 ` [PATCH 11/12] i2c: qup: reorganization of driver code to remove polling for qup v1 Abhishek Sahu
2018-02-05 23:03   ` kbuild test robot
2018-02-05 23:03     ` kbuild test robot
2018-02-16  7:44   ` Sricharan R
2018-02-19 13:21     ` Abhishek Sahu
2018-02-20  4:32       ` Sricharan R
2018-02-03  7:58 ` [PATCH 12/12] i2c: qup: reorganization of driver code to remove polling for qup v2 Abhishek Sahu
2018-02-16 11:23   ` Sricharan R
2018-02-19 14:08     ` Abhishek Sahu
2018-02-27 23:24   ` Christ, Austin
2018-03-12 13:58     ` Abhishek Sahu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c339f16e2459a7a2d757d6ca75691908@codeaurora.org \
    --to=absahu@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=austinwc@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=sricharan@codeaurora.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.