From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66CCC306768 for ; Wed, 29 Jul 2026 01:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785289267; cv=none; b=fVqkAtAkRlx2BHrMyAFLMawo/MMyW1O4Cj5Qmkw2vzrxDLP3uIvOEH5nXT1WfWfXjX42d1OssOoC6m8ClbtS82404mAW30vyTPRTz9qKrdOUpAdXv9eBu4EgSDIo0CWhy4vj7jIq4HG/l9il6lKy8yKEm14HfRuKKv4Vvamek9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785289267; c=relaxed/simple; bh=4C2QnvxvaRO2l9zCru75rbjXH21xX9Xdq14ne3kNWgM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=K3jWho2K4ljUyxcUsYzpaoqvIBtW04pUnTTENyZ7nvX9z6YFlC8p+DYUA7ob8I9IYs/Tc9yufrN2LLKEJcHCXfVej3Y3TYt8mcl8p/0RcJk5i81i1EYVSGBB9ocAEE+Ia1AZDPrKezXPIDp/Fej7IOTNSh07S++V/mYW5zXtg30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M0peHaNK; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M0peHaNK" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-845c92bc464so380964b3a.2 for ; Tue, 28 Jul 2026 18:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785289266; x=1785894066; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=4C2QnvxvaRO2l9zCru75rbjXH21xX9Xdq14ne3kNWgM=; b=M0peHaNK/ZNhGUX1doLvXtKm3p8TaE+EA/7qkBjJr4f83+r1+i8pEbHKL4uLWZBGlp BEIf7QD1DVTSLkwy1kU7H49YLlmRUoXXIrKpkz+224w9GHUCy0tEdLDS1rRQ7zansPPa eT73YaVu8KSPWjr1RzvmHspETgGqTVMbeWaM4LLiyeO1Rz2WnToXf1K+H3+3YhFSUjhc ElBJyDzOd7BGFItD5Ox2Cb2oty7XB07lkw4LWFVOCQgBst4B5iA6HvPTfY25Z/dmnYeF Fkk7WyOODPuKbSf0xZTq8adObUMSMEG6Cl+nblxk98ok39wOtswMVCX3usSGfTFkE9Pd QQrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785289266; x=1785894066; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4C2QnvxvaRO2l9zCru75rbjXH21xX9Xdq14ne3kNWgM=; b=pETOWZL/IhrGzjBYo8c9oaGR4e13YzUs6mTzqA0syH4GEeEaJWVRIqeDkJ7+SXdPjd x+ff48Pp5I35sRZQM1Tygiw6+Xq1SrdpEhXY1pbKroVxNODIqSv5qLw+5ZokjImh8V3D imfBJUlH86bY8TGTbiXEogpG9W2+1FoO/i+BA7WYQbs3YaCKp5H+RNpb+N8b6LSrKJ23 RO9yvKh1P2HSNdPaQ+UNin5Ug9KRNsXLp/q6MLhuy4NUIscX0ZsoIyTmK8zI4OEeZ8TP hhe/8VjU1li4daxcyOu7Nvywej6FNKnEBqhvwYqq5aqgDx/rtl6YwwBSwHE/pNmnLMrH VCoA== X-Forwarded-Encrypted: i=1; AHgh+Rrm4bDSlCCIpHyJmhoo2MEPZU6bbqPnC8e055XfxOZu1hYnNnVThAg2SjZ3flIlRHYh8/U=@vger.kernel.org X-Gm-Message-State: AOJu0YzHpVac474oCvbP8BaE7aKIvB0UZAKZuXE16vsRay78dbvOTa/1 5C4jp2s8PG9m296qqq88WgYT7JfJnaOUnzEqmd0pAJ9ra7qk6MEe0l/J X-Gm-Gg: AR+sD13nVX3MOwpkfEw+QxlucrvtqRG8KE9MYaef+hwsDllIsSi1uTclpHwASHkdkOW VdrdneDBUG9UeIqBSqW9+Q1CFdYSnzi/wgJEsOvXyuWKWy2IL3aDJDh4V8NuPbs2h47nW66dsnW R8P/d/mZw71+NCZwlq0pKcgRwK3YJ5x1L6/TGh/ExzNFsEN6UOudAdqeU9+atX89jywSqMrlZLb TTU1hNhJSK6OlcViU4cmFIUQBWwUZHYj7vj2NGPvRhRxsM5gTN2NMAwpcfhZWJ8yo0nVMSPoTik Zo96WrlOZ05VX4UDLRDsv7oZPkgw0CQ6Mjk9+yQ6MkZTPLIpJI7A6CLf0NfS2rrFW8V7IwE6CiN 8lWFzgkIGcosNAIzLb7Iz8zrSp3NnU/taQ2xfSlrWsTqY1Eh+sPYxdyxiI4DiZQtK+ZG64t7ial E39dXVBN+sMoNCkV7A47OwiCaNjuGyvp85JI3QcaW38OaKskvwSrmpY2/3p6HAvaAMA6nZT83Hw W5N5JBdKd5eU4922mrI66whl749dclvVfpLEY8Bjkacfyynt9OoOtZyzZ+3iuU= X-Received: by 2002:a05:6a00:178b:b0:848:42a7:1854 with SMTP id d2e1a72fcca58-84e93256a18mr4906859b3a.39.1785289265641; Tue, 28 Jul 2026 18:41:05 -0700 (PDT) Received: from ?IPv6:2605:8d80:58a5:c474:f5cf:239:70ad:a743? ([2605:8d80:58a5:c474:f5cf:239:70ad:a743]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbdba447107sm194328a12.21.2026.07.28.18.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 18:41:05 -0700 (PDT) Message-ID: Subject: Re: [PATCH bpf-next v1 8/8] resolve_btfids: Enforce consistent kfunc flags across BTF ID sets From: Eduard Zingerman To: Ihor Solodrai , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Kumar Kartikeya Dwivedi Cc: Benjamin Tissoires , Jiri Kosina , Emil Tsalapatis , Jiri Olsa , bpf@vger.kernel.org, linux-input@vger.kernel.org, kernel-team@meta.com Date: Tue, 28 Jul 2026 18:40:46 -0700 In-Reply-To: <20260722233518.778854-9-ihor.solodrai@linux.dev> References: <20260722233518.778854-1-ihor.solodrai@linux.dev> <20260722233518.778854-9-ihor.solodrai@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 eOn Wed, 2026-07-22 at 16:35 -0700, Ihor Solodrai wrote: > A kfunc may be listed in several BTF ID sets, which is expected > because different kfuncs are available to BPF programs depending on > their type. >=20 > However kfunc flags across different BTF ID sets must be consistent [1]. > The flags should be considered a part of the kfunc declaration, > because they influence its BTF representation and verifier handling. >=20 > Enforce the kfunc flag consistency in resolve_btifds by hard failing > on error and blocking kernel (or module) build. >=20 > [1] https://lore.kernel.org/bpf/9b2196dd-443b-4632-ae11-030cdbdc59b4@linu= x.dev/ >=20 > Signed-off-by: Ihor Solodrai > --- Reviewed-by: Eduard Zingerman ...