From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C006CCDB479 for ; Tue, 23 Jun 2026 13:46:25 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1344296.1603395 (Exim 4.92) (envelope-from ) id 1wc1SC-00033I-F4; Tue, 23 Jun 2026 13:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1344296.1603395; Tue, 23 Jun 2026 13:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wc1SC-00033B-C1; Tue, 23 Jun 2026 13:46:16 +0000 Received: by outflank-mailman (input) for mailman id 1344296; Tue, 23 Jun 2026 13:46:14 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wc1SA-000334-JH for xen-devel@lists.xenproject.org; Tue, 23 Jun 2026 13:46:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wc1SA-00EWVM-09 for xen-devel@lists.xenproject.org; Tue, 23 Jun 2026 15:46:14 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a3a8e23-e002-0a2a0a5209dd-0a2a4509b9d8-4 for ; Tue, 23 Jun 2026 15:46:13 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.0) (envelope-from ) id 6a3a8e25-4999-0a2a45090019-d1558031c885-3 for ; Tue, 23 Jun 2026 15:46:13 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490a76757e5so35755715e9.2 for ; Tue, 23 Jun 2026 06:46:13 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fe7b359sm363298205e9.9.2026.06.23.06.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 06:46:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782222373; x=1782827173; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/0/1yboZ9+2i88mjtfHYubEpuWxYl3dEnFK3kI0Tmyk=; b=XT3TWIanxOXIPhueirXcb8866PzWW8HR5ZzLKpKLTTQZIrZg9BOED7o+0c0IHmj1VE rCAqWRFQPtte14v5GfyMrJnjp3vIVFWpE34fWpikxP+8n3hVAtNItCo+2Rwh/QaLmHoe Z3GFzhrbWRua07aL42u/j31OD4MhlLWpFDftnY6CZHmdZckJe3Eihr3C4r1DA6MP183I hRaWsPHy4NOP2iCeVJX4k0pwevVUDjEiu+QXoQTZuV6yg0oT/wq1SrfxcXoo7bSZGF1g JO4t7eGNuuidSN8BBn4tiio/TNh0A1teFLzMMoY48vB3eYeXRdHz87u3cU4ppGZ9BM3b at8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782222373; x=1782827173; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/0/1yboZ9+2i88mjtfHYubEpuWxYl3dEnFK3kI0Tmyk=; b=IAs6TMBcwlYM3ll/8egCHL7hgv7zqgw/bGXIvdB9DVAYO/nLcZLvAF2Mx5Y0vv5Qbz QkEPfPHo03EZ034qsMa+QM+u3yYpowLMYoLaR34uzg3YDV+HF/PfZ1UcAeCcTLZeBSqV FgMQL1gAv4+VCp0cODgFMQga10qeYOexUXZxxU2Im01aRyZEHav9qCIJknGT9o/yPtFS WTYaJ4Hv+8IT+GQItMjfZvY3skKH+5hwAMSxO+Cc3hndUulEFybQQ2xDQx9jPq5GOvpK wVXBRNkZVLTdhZHsXjN4L/tsoVLcmJdT1vtUxLLUvOFo8r73CMfp7rwQqwjqay2UbS4M vAdA== X-Forwarded-Encrypted: i=1; AFNElJ9J/rYHnKRjek18X27B4q0ChwQ+3hq61uD6pQEtA6TfeFOwgil42+Td3pg8vdvYRiwiRVifI3SWRr4=@lists.xenproject.org X-Gm-Message-State: AOJu0Ywc0pDsrNkH5uernpvaO40yyVK0TXFyH/vjE5FOTUeOusaJY5vO LHZ0KSIS6wqi7nh8TL9TyzunNbkUUBe9gJrVyMu7K7GWpvwHsp8i9sdnYlLPDZo6gQ== X-Gm-Gg: AfdE7ck7SvKh6kWhMahzA9Pe2YPHk1GAgBHaELh5r66awPWl3mP3Ml9eH+uBHUZh+OD ieFGu3w0uwJ7rQT/qr9OhUYkJl78bjQtjZunTJZfBjyX9OmwhLC0lWjhSnKnizQuQM2t1UgUQ3U s1jKfQUlumn9aBqiT+VIYAie06tHgSLlIf4qHRdgLuvcaR5vkr74hf/YTVfgTbAA8jHGhVeprOs GvMwZLgz0Q/qy3FqQNkzx0Wmog+j8WY899IVr4sdlJxYs5Pi/ebfGkVxq6ebpyn2pI/z6OHm5L+ moYJSu+cen6ZVXBx6rzmdMNH+M3HExlUHurmfJSTGLtbWzQUrM+8z1Z3sxAVTF0DzHrQqLcDJ6D 6SZitDTNXRIsgYtdfWcg65LguPZ24qmElGh67NbarTGBaJUIdiIFWef++7aKn5yjlpPdYgUuP1k OVM6pkChIEcy4QkESTdkESZ7TMIbvdDcj5Mc80RVPYG7KvvzhByXTjboZDLLaecbYPpGkAT50nh Cxx X-Received: by 2002:a05:600c:e556:10b0:490:c2a2:b1d4 with SMTP id 5b1f17b1804b1-4925b3bc8f2mr29630355e9.35.1782222373326; Tue, 23 Jun 2026 06:46:13 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 15:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-4.22] char/ns16550: bound execution time of ns16550_interrupt() To: Oleksii Kurochko Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini , Roger Pau Monne , xen-devel@lists.xenproject.org References: <20260623103145.76383-1-roger.pau@citrix.com> <20161bd5-a081-4562-a1d9-14dbdba109f3@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20161bd5-a081-4562-a1d9-14dbdba109f3@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1782222373-73BEE744-AF4F0501/0/0 X-purgate-type: clean X-purgate-size: 1185 On 23.06.2026 15:36, Oleksii Kurochko wrote: > On 6/23/26 12:31 PM, Roger Pau Monne wrote: >> The current logic in ns16550_interrupt() will loop until the device sets >> the NOINT in IIR. At least on the Lenovo ThinkSystem SR630 V4 the flow >> control of the serial-over-lan emulated UART seems to be broken, as it >> doesn't set the NOINT bit consistently. The Transmitter Holding Register >> Empty in LSR also seems to not be properly signaled, as even with it set >> writes to the transmit register take ~6ms. This leads to the watchdog >> triggering very easily on such system. >> >> Introduce an upper bound on the execution time of ns16550_interrupt(), this >> is currently set as 4x the polling interval, which is calculated as the >> time to fill RX FIFO and/or empty TX FIFO. The current maximum is 5ms. >> Once the timeout triggers the interrupt is disabled and the uart is >> switched to polling mode. > > Don't you mmiss Fixes: tag? Fixes: "SoL on Lenovo ThinkSystem SR630 V4" you mean? I think there's nothing wrong with our pre-existing code, and the changes here instead are a workaround for some (apparently) badly implemented SoL. Jan