From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eqXtT-0007vp-S9 for ath10k@lists.infradead.org; Tue, 27 Feb 2018 05:33:41 +0000 MIME-Version: 1.0 Date: Tue, 27 Feb 2018 11:03:25 +0530 From: Maharaja Kennadyrajan Subject: Re: [PATCH v2] ath10k: debugfs support to get final TPC stats for 10.4 variants In-Reply-To: References: <1519634437-6672-1-git-send-email-mkenna@codeaurora.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Joshua Zhao Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOC0wMi0yNyAxOjE5IGFtLCBKb3NodWEgWmhhbyB3cm90ZToKPiBhcyB5b3Ugc2FpZDoK PiAgICAgICAgIFRoZSBleGlzdGluZyB0cGNfc3RhdHMgZGVidWdmcyBmaWxlIHByb3ZpZGVzIHRo ZSBkdW1wIHdoaWNoIGlzCj4gbWluaW11bSBvZiB0YXJnZXQgcG93ZXIgYW5kIHJlZ3VsYXRvcnkg ZG9tYWluLgo+ICAgICAgICAgICAgICAgICAgICAgICAgIGNhdCAKPiAvc3lzL2tlcm5lbC9kZWJ1 Zy9pZWVlODAyMTEvcGh5WC9hdGgxMGsvdHBjX3N0YXRzCj4gCj4gSeKAmW0gY3VyaW91cyB3aGF0 4oCZcyBleGFjdCBkaWZmZXJlbmNlIHcvIHRoaXMgbmV3IGFkZGl0aW9uOgo+ICAgICAgICAgRXhw b3J0IHRoZSBmaW5hbCBUcmFuc21pdCBQb3dlciBDb250cm9sIChUUEMpIHZhbHVlLCB3aGljaCBp cwo+IHRoZSBtaW5pbXVtIG9mIGNvbnRyb2wgcG93ZXIgYW5kIGV4aXN0aW5nIFRQQyB2YWx1ZSB0 byB1c2VyIHNwYWNlIHZpYQo+IGEgbmV3IGRlYnVnZnMgZmlsZSAidHBjX3N0YXRzX2ZpbmFsIiB0 byBoZWxwIHdpdGggZGVidWdnaW5nLgo+IAo+IENhbiB5b3UgY2xhcmlmeSBvciBnaXZlIGV4YW1w bGVzIG9uIHRoZSBkaWZmZXJlbmNlPwo+IAo+IFRoYW5rcyEKClRoZSBleGlzdGluZyB0cGNfc3Rh dHMgaXMgdGhlIG1pbmltdW0gb2YgInRhcmdldCBwb3dlciBhbmQgcmVndWxhdG9yeSAKZG9tYWlu Ii4KVGhlIG5ldyBhZGRpdGlvbiBpcyB0aGUgbWluaW11bSBvZiAiZXhpc3RpbmcgdHBjX3N0YXRz IGFuZCBjb250cm9sIApwb3dlciIgd2hpY2ggbWVhbnMgbWluaW11bSBvZiAiY29udHJvbCBwb3dl ciwgdGFyZ2V0IHBvd2VyIGFuZCAKcmVndWxhdG9yeSBkb21haW4iLgoKLS0gClJlZ2FyZHMsCk1h aGEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEw ayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41452 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937AbeB0Fd0 (ORCPT ); Tue, 27 Feb 2018 00:33:26 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Tue, 27 Feb 2018 11:03:25 +0530 From: Maharaja Kennadyrajan To: Joshua Zhao Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] ath10k: debugfs support to get final TPC stats for 10.4 variants In-Reply-To: References: <1519634437-6672-1-git-send-email-mkenna@codeaurora.org> Message-ID: (sfid-20180227_063329_896213_5CE833DF) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-02-27 1:19 am, Joshua Zhao wrote: > as you said: > The existing tpc_stats debugfs file provides the dump which is > minimum of target power and regulatory domain. > cat > /sys/kernel/debug/ieee80211/phyX/ath10k/tpc_stats > > I’m curious what’s exact difference w/ this new addition: > Export the final Transmit Power Control (TPC) value, which is > the minimum of control power and existing TPC value to user space via > a new debugfs file "tpc_stats_final" to help with debugging. > > Can you clarify or give examples on the difference? > > Thanks! The existing tpc_stats is the minimum of "target power and regulatory domain". The new addition is the minimum of "existing tpc_stats and control power" which means minimum of "control power, target power and regulatory domain". -- Regards, Maha