From: Sibi Sankar <sibis@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: bjorn.andersson@linaro.org, p.zabel@pengutronix.de,
robh+dt@kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
ohad@wizery.com, mark.rutland@arm.com, sricharan@codeaurora.org,
akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org,
tsoni@codeaurora.org
Subject: Re: [PATCH v2 3/6] dt-bindings: remoteproc: Remove additional definition tag
Date: Wed, 29 Aug 2018 22:08:52 +0530 [thread overview]
Message-ID: <c3e417189c150114b67af9e5ded668b6@codeaurora.org> (raw)
In-Reply-To: <20180828004422.GZ160295@google.com>
Hi Matthias,
Thanks for the review!
On 2018-08-28 06:14, Matthias Kaehlcke wrote:
> Hi Sibi,
>
> Subject: dt-bindings: remoteproc: Remove additional definition tag
>
> nit: the subject is a bit generic, you probably should at least add
> 'qcom: ' to the 'path'.
>
Will add
> On Fri, Aug 24, 2018 at 06:48:57PM +0530, Sibi Sankar wrote:
>> Remove the additional definition tag declared for WCSS sub-system
>> under reset-names.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> index 601dd9f389aa..c45e4c131fa2 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> @@ -58,7 +58,7 @@ on the Qualcomm Hexagon core.
>> Usage: required
>> Value type: <stringlist>
>> Definition: must be "mss_restart" for the modem sub-system
>> - Definition: must be "wcss_aon_reset", "wcss_reset", "wcss_q6_reset"
>> + must be "wcss_aon_reset", "wcss_reset", "wcss_q6_reset"
>> for the wcss syb-system
>
> Since you are already at it you might also want to fix the typo in
> 'wcss syb-system'.
>
nice catch, will correct it.
I missed your query in the other thread, APPS refers to the pdc_sync
reset line for the Application processor.
> Other than the nits:
>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-08-29 16:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 13:18 [PATCH v2 0/6] Add support for PDC Global on SDM845 SoCs Sibi Sankar
2018-08-24 13:18 ` [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for " Sibi Sankar
2018-08-28 0:33 ` Bjorn Andersson
2018-08-28 0:38 ` Matthias Kaehlcke
2018-08-28 6:08 ` sibis
2018-08-28 17:11 ` Matthias Kaehlcke
2018-08-29 0:43 ` Rob Herring
2018-08-29 0:43 ` Rob Herring
2018-08-29 0:43 ` Rob Herring
2018-08-24 13:18 ` [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller Sibi Sankar
2018-08-28 0:22 ` Matthias Kaehlcke
2018-08-28 3:02 ` Bjorn Andersson
2018-08-28 7:11 ` Sibi Sankar
2018-08-28 16:56 ` Matthias Kaehlcke
2018-08-24 13:18 ` [PATCH v2 3/6] dt-bindings: remoteproc: Remove additional definition tag Sibi Sankar
2018-08-28 0:44 ` Matthias Kaehlcke
2018-08-29 16:38 ` Sibi Sankar [this message]
2018-08-24 13:18 ` [PATCH v2 4/6] dt-bindings: remoteproc: Add PDC reset binding for Q6V5 PIL Sibi Sankar
2018-08-29 0:44 ` Rob Herring
2018-08-29 0:44 ` Rob Herring
2018-08-29 0:44 ` Rob Herring
2018-08-24 13:18 ` [PATCH v2 5/6] remoteproc: qcom: q6v5-pil: Explicitly get mss_restart line Sibi Sankar
2018-08-24 13:19 ` [PATCH v2 6/6] remoteproc: qcom: q6v5-pil: Add PDC reset for modem on SDM845 SoCs Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3e417189c150114b67af9e5ded668b6@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sricharan@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.