From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f8JG9-0006VS-8B for mharc-grub-devel@gnu.org; Tue, 17 Apr 2018 01:34:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8JG7-0006UB-96 for grub-devel@gnu.org; Tue, 17 Apr 2018 01:34:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8JG6-0004ml-7A for grub-devel@gnu.org; Tue, 17 Apr 2018 01:34:27 -0400 Received: from mail-pg0-x233.google.com ([2607:f8b0:400e:c05::233]:38851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8JG5-0004kW-Vt for grub-devel@gnu.org; Tue, 17 Apr 2018 01:34:26 -0400 Received: by mail-pg0-x233.google.com with SMTP id b5so3800538pgv.5 for ; Mon, 16 Apr 2018 22:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iDecf5ahqeM33MC5QDwZT4MbBf9swqcPkJ/lBCyqC6Y=; b=ArNGzKHo93m2MdI4hU6sbuP6uiMLhtCGN9xjfSMKQghAAOLi8RvU5Frg7Ytqq2hffk YEjh48JjF7alqUT9scBBfi4EmgSn3UZKsh/gPdFbghs1rOcdhqk4nmJAXVSKkp2N2l9G lLlEwY9nbTAcFzV7VdM7i1J9wdHpAu0k6eZkn6oiqInAwWO18uD2u3ljpfnp7suxTaeJ 8Ov/sHgd5HPo2MLqtOsJ5ifYFShrs7NyCr4ap2hhnBp/eJphog+E4EYbP7dCFKPIscbl ++rhNCrLyqhgqaaY6u3K7wWDxnUNLEngjPUV48bUGWFt89lbuEExltHShoLn4bVyOA0K 7JAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=iDecf5ahqeM33MC5QDwZT4MbBf9swqcPkJ/lBCyqC6Y=; b=aav++cr/HKExHG5jFpG1FV7S7qRTwZHJB8ae3AZUmrazL9v8B5w/g93dAzTCNLR1ea +Fjv2ZHm7broLj+kUkDA8W1bMTgPrBiNdQpSvcimhRPncLsdK34dv1VLd46eNlE68FRQ jRYgMOGaSjCNgXFMZEIqsZtw/+O/EDdmHFx7PCiKxl6Y0lzHG68gdS00sJTO2baFSQPJ 0rkp67pkdLSc6ZMNbxMNjQ25mgtBRGwUexESXkXnbBhJ9jc66bkTej5wTaJS5wDiocM2 QHfO4g8jLsl7BgUYUCXsP0eSb5I97hMjDjUwoWnYX0wFn3za2Ldzz9TJPvy85Yik7xU3 D8JA== X-Gm-Message-State: ALQs6tC+LrqTlV3R15iYJIE8ymOSygqf3RNBgPvf0xH29Fg+zu1GrakC MjjXnh9kCq39Kx6nKYyZd13fLA== X-Google-Smtp-Source: AIpwx4+71HzzsgwHb73gEL0NuUJkdXvrAdQZlHJPibVI26dIs53Ny10BTF21glRyGR6Oz3iNTApasw== X-Received: by 10.99.43.70 with SMTP id r67mr666197pgr.422.1523943264203; Mon, 16 Apr 2018 22:34:24 -0700 (PDT) Received: from ?IPv6:2601:602:9c01:e86a:2ec2:3a19:cd81:76ab? ([2601:602:9c01:e86a:2ec2:3a19:cd81:76ab]) by smtp.googlemail.com with ESMTPSA id b3sm23458001pfi.54.2018.04.16.22.34.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 22:34:23 -0700 (PDT) Subject: Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files To: Daniel Kiper Cc: grub-devel@gnu.org References: <215c48d12d36aec6c8c2c48a4be325fc743d764c.1523131110.git.nvinson234@gmail.com> <20180410205228.GB25917@router-fw-old.local.net-space.pl> <25902d38-4c37-9c9a-19b0-aeda756c8613@gmail.com> <20180411083138.GB2642@router-fw-old.local.net-space.pl> <5e568894-74eb-1fa8-b518-256fd1ba79af@gmail.com> <20180416114752.GA21283@router-fw-old.local.net-space.pl> From: Nick Vinson Openpgp: preference=signencrypt Autocrypt: addr=nvinson234@gmail.com; prefer-encrypt=mutual; keydata= xsFNBFnVpFMBEADS003mH2zUUvhUJ6Ba6C28YrABQF63AyPrOyS1LggaigZ4yYhgHDToxYEm QE7micAiN/J8/8qaLou12wXGdV0GmuIQlAeIp4Tbv5id0LOWNc2NxYbSyGywc9Y8RSJJpcnb 93ltKive1Z/ID4V2spggX3QAQKPdz1lAWgfUovfcDrWUL+hrdlBq6G9hB6bm3Fjgn9nzIgia fE0RDoRXizc44ylGA9zAn98QnDFfRp+il3UzVCktay9uoifRUtnCh4f8UTrn050Z/VYZ6Q30 8HEpnxVbVqm5bew570F3cN0UAedEnn24Ji32q+doroRMt9/+5jJGWwhmPUrCXOzS/YRMI4ki BEEv40u3Dn54bxXQq59f79Cy+UZe59HLU3OtKfSt2cCroFMxj6SuMZRr6xROAM0CGEoaZZ4C V8Eo7TDAcCHPfyhoGWkMSlsWmi3en01ScsRqVAlxYFq2lhJeoDK5gfezKzZvQ7J/4Nh3dhSY rpXRiASCCFjeGZWOMwBDbzC8WtOf7Zl9NFCIMHut4OWZAjhxzoyQiblob3plIDJknIoRo79l NgLYWdbXLFTq1H5aLIz4AkHKpGzQLxfLXytghyvodOhrlBkGt9e0sgOIl+Z6CH4lbQ6IcGeP xn2Ham5xLlr5tp+FCrrv9dS86Yk3hVXjUyuP8Dzzr25JqQtibwARAQABzSZOaWNob2xhcyBW aW5zb24gPG52aW5zb24yMzRAZ21haWwuY29tPsLBlAQTAQgAPhYhBBysOVcZY1PxNox1ZcLF v5XS9tmCBQJZ1aRTAhsDBQkDwmcABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEMLFv5XS 9tmCFBIQAIGG0Ew6sJtqZIFPCaK1sAIY1HyGq5Y8imM6bAIYtpqArla6fqPqY8stygDOBewj nYHEHRY9rYe+xQ9k3Qx0VVa+amXWN26Wc4EdgAXU3pWAGN5mHENxLdwIwIZuSL+BNr4lbUlA lh94jRWsRWHwDnmyESHorsWzGYObqRramUJ5PuyTpHENdEhRbJpB6+LXYsYfMWZJMUWP6Smm UYC6ie7EVjWB95D6r9jfuUf0jrmvBAhBYEAYltLp2cJPJgwasPi3b8QH3K5cP/VMIA6u/ASU tucb8Mq/aiDX2IV3EqfEbVpUIIPo3RREOSxvveK1gktiomDl55cwlc4XnpixiOeGiMf9tzSX 1eD6wD9y5RI6M+XRjlkPRjNxN/Diua0pynwoRMv6LyXNDB19bahfIP7h6i6yh+n/AlgUr3IO hrig5skYO7Y0sq+EbwyTIkjq3OhjI1mdVkZ5tNx3/7381968pisIYUOtWFCmf3rQYftCAgnH nkleBgFEmIWjQbpQyN3qakzYwbvCc3zuZDFIPpc5p5vcAfumSHS6gmugD+AcuuOfE6B4nbFy /Lbst+PZv1GBSWFDBb9vZzxR5mu21VoQUv5zx50iFinKrSs/niUDbP/sO38ptif4e3jYUaqp 5CvvllC804BWb+i+QRs0H4+Q6fLF+d5nK/l314WduuBzzsFNBFnVpJUBEADevEpE8EzXiTuV G9oBqxlQQHTIYjY8/zUoA/VYGotURc8IzX42ZXB8QQAdYJky2G1Pu9kxyTYiSgKK6lt2c3Ds AOOCpVA2WeMLTKmyejRaMoSMV2YVm88TM4UI0y27NYUFUoH2l03W/Ak7kVMdoEJXiVvt4CSe /P+hZmw4aq+YOskFK8LGBOA8Ml8fAUqe/5LCgXxbzyXTn89e+IIMt1qswGpYYGX7AxUkucSH FNpiKsuQZXWKyKoNnS+47vspB4IysAU5OdP7djZriEEEu1xWqkOcJr7XYib7CQAzSUxXI3Um iHPt5NPpwpLmkcJCV7bfnKvL7YTlVy0y8gkoH2Kb9sTMqDIPQUcgFoDW7UTCbnJnWNmHHhgQ fExwjshK562/6uiMgArwxvBZHKJ+9H7Tr1Qtz611lWHMeI9l0sYUdEK1s2qrREO9Z/dywYsm Xt1+PTJPqsEbP5oBrsOFoHLj+jcDRIsJwEi8MdN7djVFC5Pyyb2zKolmYilZi9epVOfe2cab 7yNg7f263P8rC24gwGsSuNSHWdgOSgw8WQJ4EbJxef+REixLyx+Ptigo+1R/obJme4RLqBXQ 5dLIGkLg2MB/Wq9OufSGxAtiv5I1su8emLtlzoM+WT0t76d9OqAU9emBLoHHsLsiLgqydfkN 4Ghfo5seV/z4JXGfZv9xUQARAQABwsF8BBgBCAAmFiEEHKw5VxljU/E2jHVlwsW/ldL22YIF AlnVpJUCGwwFCQPCZwAACgkQwsW/ldL22YJpKA//Uf2Qaw9bmDtsXWING/74PioKStHwGrDF +EOkOl9S++BJSQKnBnmeSvkrzz7F9ZLAE/AXZyz8jrY4IqwwMZfFXv+cqh0EXZEPSDMeMzho mzDH8SMCdKa3x8gVMtRpLtmNRbwp90LVm/KYYsar4t7eZgn/8mgxxego2dcFYlwIj/fw+WGH j7TAhOS3vSQzKhzSqlHPWgxZpAirgIbWRyfhBJloQ28gSzWST0bms7+HNw9a3Sgf2+FXVZIH t6LoHybWbVW4kibtHIukRToUJPOg9wbrm+hJjYW7JHMZLb7ph+X3a+5Zv8iPWReVv9Ez/y6M vb0qpqFCxBBaHFXUtmj3uKG0O3OlJ2Elq6ugBk+apwd3/bbsVCQMiFyNchH3iYSK48xupj0j XDCF77BgUgh61co9p9dj7XB3HcGS2gZAe5XCmcZJJnhmUhUnAQZ24wHrEzhNAGa6/UOykCid D1gmrd6FcS2gtojMKXUIO5+ZOfoxLjqkb+OErQ7pcnPUrnzyMvWm/eRF4w3XEPvgSSHPoIra 2IrxGy/HeWijDCO4wrkkfKA7w3venaNa6Fsr9gDjaTLKB/TPXnPasYwQ0pDhptyGO6AvFW+D npOA7iLGtQVLE9RWrLiJniSuAZOvAntAjj05fJpwnxJXAArhPPiaTzGsGN9o25VeiEheHBs5 xHE= Message-ID: Date: Mon, 16 Apr 2018 22:34:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180416114752.GA21283@router-fw-old.local.net-space.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 05:34:28 -0000 On 04/16/2018 04:47 AM, Daniel Kiper wrote: > On Wed, Apr 11, 2018 at 07:45:01AM -0700, Nick Vinson wrote: >> On 04/11/2018 01:31 AM, Daniel Kiper wrote: >>> On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: >>>> On 04/10/2018 01:52 PM, Daniel Kiper wrote: >>>>> On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: >>>>>> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >>>>>> partuuid target. Update grub.texi documentation. The following table >>>>>> shows how GRUB_DISABLE_LINUX_UUID, GRUB_DISABLE_LINUX_PARTUUID, and >>>>>> initramfs detection interact: >>>>>> >>>>>> Initramfs GRUB_DISABLE_LINUX_PARTUUID GRUB_DISABLE_LINUX_UUID Linux Root >>>>>> detected Set Set ID Method >>>>>> >>>>>> False False False part UUID >>>>>> False False True part UUID >>>>>> False True False dev name >>>>>> False True True dev name >>>>>> True False False fs UUID >>>>>> True False True part UUID >>>>>> True True False fs UUID >>>>>> True True True dev name >>>>> >>>>> What will happen if GRUB_DISABLE_LINUX_PARTUUID and/or GRUB_DISABLE_LINUX_UUID >>>>> are not set? I think that you can avoid that by setting defaults. You do that >>>>> for GRUB_DISABLE_LINUX_PARTUUID in next patch but GRUB_DISABLE_LINUX_UUID >>>>> does not have any default. >>>>> >>>> >>>> If they're not set, then that's the same as them being set to 'False'. >>>> I should have worded my table above a bit differently and used Yes/No >>>> instead of True/False as that is really what it is trying to convey. >>> >>> IMO it will be more confusing. I think that I would use lowercase >>> false/true as it is used in the script and below the table I would >>> add a note that == false or something like that. >> >> Ack. I will update the commit comment. > > Thanks. May I ask you to put similar table into docs/grub.texi? Done. Thanks, Nicholas Vinson > > Daniel >