Re: [PATCH v3 1/3] cxl: Move mailbox related bits to the same context

[Dan Carpenter <dan.carpenter@linaro.org>]

Hi Dave,

kernel test robot noticed the following build warnings:

https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dave-Jiang/cxl-Move-mailbox-related-bits-to-the-same-context/20240904-080307
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20240904000020.1686611-2-dave.jiang%40intel.com
patch subject: [PATCH v3 1/3] cxl: Move mailbox related bits to the same context
config: i386-randconfig-141-20240904 (https://download.01.org/0day-ci/archive/20240905/202409051031.WY4y1MhJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202409051031.WY4y1MhJ-lkp@intel.com/

smatch warnings:
drivers/cxl/core/mbox.c:1429 cxl_mailbox_init() error: we previously assumed 'cxl_mbox' could be null (see line 1426)

vim +/cxl_mbox +1429 drivers/cxl/core/mbox.c

1390c0beea9575 Dave Jiang       2024-09-03  1424  int cxl_mailbox_init(struct cxl_mailbox *cxl_mbox, struct device *host)
1390c0beea9575 Dave Jiang       2024-09-03  1425  {
1390c0beea9575 Dave Jiang       2024-09-03 @1426  	if (!cxl_mbox && !host)

s/&&/||/

1390c0beea9575 Dave Jiang       2024-09-03  1427  		return -EINVAL;
1390c0beea9575 Dave Jiang       2024-09-03  1428  
1390c0beea9575 Dave Jiang       2024-09-03 @1429  	cxl_mbox->host = host;
1390c0beea9575 Dave Jiang       2024-09-03  1430  	mutex_init(&cxl_mbox->mbox_mutex);
1390c0beea9575 Dave Jiang       2024-09-03  1431  	rcuwait_init(&cxl_mbox->mbox_wait);
1390c0beea9575 Dave Jiang       2024-09-03  1432  
1390c0beea9575 Dave Jiang       2024-09-03  1433  	return 0;
1390c0beea9575 Dave Jiang       2024-09-03  1434  }

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki