Re: [PATCH v4 3/7] hw/boards: Rename no_sdcard -> auto_create_sdcard

[Thomas Huth <thuth@redhat.com>]

On 04/02/2025 21.09, Philippe Mathieu-Daudé wrote:
> Invert the 'no_sdcard' logic, renaming it as the more explicit
> "auto_create_sdcard". Machines are supposed to create a SD Card
> drive when this flag is set. In many cases it doesn't make much
> sense (as boards don't expose SD Card host controller), but this
> is patch only aims to expose that nonsense; so no logical change
> intended (mechanical patch using gsed).
> 
> Most of the changes are:
> 
>    -    mc->no_sdcard = ON_OFF_AUTO_OFF;
>    +    mc->auto_create_sdcard = true;
> 
> Except in
>   . hw/core/null-machine.c
>   . hw/arm/xilinx_zynq.c
>   . hw/s390x/s390-virtio-ccw.c
> where the disabled option is manually removed (since default):
> 
>    -    mc->no_sdcard = ON_OFF_AUTO_ON;
>    +    mc->auto_create_sdcard = false;

You might want to remove that "+" line now, since you remove the setting now 
instead of setting it to "false"

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>