From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/6] drm/i915: Retire requests along rings Date: Wed, 25 Apr 2018 10:30:51 +0100 Message-ID: References: <20180424131415.15102-1-chris@chris-wilson.co.uk> <20180424131415.15102-2-chris@chris-wilson.co.uk> <5b44e046-3d10-2cc4-d1dc-12c4842560c9@linux.intel.com> <152458186886.12387.2392365728240433294@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E09DC6E584 for ; Wed, 25 Apr 2018 09:30:57 +0000 (UTC) In-Reply-To: <152458186886.12387.2392365728240433294@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI0LzA0LzIwMTggMTU6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA0LTI0IDE1OjQ2OjQ5KQo+Pgo+PiBPbiAyNC8wNC8yMDE4IDE0OjE0 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBJbiB0aGUgbmV4dCBwYXRjaCwgcmluZ3MgYXJlIHRo ZSBjZW50cmFsIHRpbWVsaW5lIGFzIHJlcXVlc3RzIG1heSBqdW1wCj4+PiBiZXR3ZWVuIGVuZ2lu ZXMuIFRoZXJlZm9yZSBpbiB0aGUgZnV0dXJlIGFzIHdlIHJldGlyZSBpbiBvcmRlciBhbG9uZyB0 aGUKPj4+IGVuZ2luZSB0aW1lbGluZSwgd2UgbWF5IHJldGlyZSBvdXQtb2Ytb3JkZXIgd2l0aGlu IGEgcmluZyAoYXMgdGhlIHJpbmcgbm93Cj4+PiBvY2N1cnMgYWxvbmcgbXVsdGlwbGUgZW5naW5l cyksIGxlYWRpbmcgdG8gbXVjaCBoaWxhcml0eSBpbiBtaXNjb21wdXRpbmcKPj4+IHRoZSBwb3Np dGlvbiBvZiByaW5nLT5oZWFkLgo+Pj4KPj4+IEFzIGFuIGFkZGVkIGJvbnVzLCByZXRpcmluZyBh bG9uZyB0aGUgcmluZyByZWR1Y2VzIHRoZSBwZW5hbHR5IG9mIGhhdmluZwo+Pj4gb25lIGV4ZWNs aXN0cyBjbGllbnQgZG8gY2xlYW51cCBmb3IgYW5vdGhlciAob2xkIGxlZ2FjeSBzdWJtaXNzaW9u Cj4+PiBzaGFyZXMgYSByaW5nIGJldHdlZW4gYWxsIGNsaWVudHMpLiBUaGUgZG93bnNpZGUgaXMg dGhhdCBzbG93IGFuZAo+Pj4gaXJyZWd1bGFyIChvZmYgdGhlIGNyaXRpY2FsIHBhdGgpIHByb2Nl c3Mgb2YgY2xlYW5pbmcgdXAgc3RhbGUgcmVxdWVzdHMKPj4+IGFmdGVyIHVzZXJzcGFjZSBiZWNv bWVzIGEgbW9kaWN1bSBsZXNzIGVmZmljaWVudC4KPj4+Cj4+PiBJbiB0aGUgbG9uZyBydW4sIGl0 IHdpbGwgYmVjb21lIGFwcGFyZW50IHRoYXQgdGhlIG9yZGVyZWQKPj4+IHJpbmctPnJlcXVlc3Rf bGlzdCBtYXRjaGVzIHRoZSByaW5nLT50aW1lbGluZSwgYSBmdW4gY2hhbGxlbmdlIGZvciB0aGUK Pj4+IGZ1dHVyZSB3aWxsIGJlIHVuaWZ5aW5nIHRoZSB0d28gbGlzdHMgdG8gYXZvaWQgZHVwbGlj YXRpb24hCj4+Pgo+Pj4gdjI6IFdlIG5lZWQgYm90aCBlbmdpbmUtb3JkZXIgYW5kIHJpbmctb3Jk ZXIgcHJvY2Vzc2luZyB0byBtYWludGFpbiBvdXIKPj4+IGtub3dsZWRnZSBvZiB3aGVyZSBpbmRp dmlkdWFsIHJpbmdzIGhhdmUgY29tcGxldGVkIHVwdG8gYXMgd2VsbCBhcwo+Pj4ga25vd2luZyB3 aGF0IHdhcyBsYXN0IGV4ZWN1dGluZyBvbiBhbnkgZW5naW5lLiBBbmQgZmluYWxseSBieSBkZWNv dXBsaW5nCj4+PiByZXRpcmluZyB0aGUgY29udGV4dHMgb24gdGhlIGVuZ2luZSBhbmQgdGhlIHRp bWVsaW5lcyBhbG9uZyB0aGUgcmluZ3MsCj4+PiB3ZSBkbyBoYXZlIHRvIGtlZXAgYSByZWZlcmVu Y2UgdG8gdGhlIGNvbnRleHQgb24gZWFjaCByZXF1ZXN0Cj4+PiAocHJldmlvdXNseSBpdCB3YXMg Z3VhcmFudGVlZCBieSB0aGUgY29udGV4dCBiZWluZyBwaW5uZWQpLgo+Pj4KPj4+IFNpZ25lZC1v ZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+Pj4gQ2M6IFR2 cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+IEBAIC0z MjIsOSArMzI1LDkgQEAgc3RhdGljIHZvaWQgYWR2YW5jZV9yaW5nKHN0cnVjdCBpOTE1X3JlcXVl c3QgKnJlcXVlc3QpCj4+PiAgICAgICAgfSBlbHNlIHsKPj4+ICAgICAgICAgICAgICAgIHRhaWwg PSByZXF1ZXN0LT5wb3N0Zml4Owo+Pj4gICAgICAgIH0KPj4+IC0gICAgIGxpc3RfZGVsKCZyZXF1 ZXN0LT5yaW5nX2xpbmspOwo+Pj4gKyAgICAgbGlzdF9kZWxfaW5pdCgmcmVxdWVzdC0+cmluZ19s aW5rKTsKPj4KPj4gV2h5IHRoZSBfaW5pdCBmbGF2b3VyPyBUaGVyZSBhcmUgdHdvIGxpc3QgaGVh ZHMgZm9yIGJlaW5nIG9uIHR3bwo+PiBzZXBhcmF0ZSBsaXN0cywgYnV0IGFyZSBlaXRoZXIgcGF0 aCByZWFjaGFibGUgYWZ0ZXIgYmVpbmcgcmVtb3ZlZCBmcm9tCj4+IHRoZSByZXNwZWN0aXZlIGxp c3RzPyAoSSBtYXkgZmluZCB0aGUgYW5zd2VyIGFzIEkgcmVhZCBvbi4pCj4gCj4gWWVzLiBycSBh cmUgaGVsZCBlbHNld2hlcmUgYW5kIG1heSBlbmQgdXAgYmVpbmcgaW5kaXZpZHVhbGx5IHJldGly ZWQKPiAodmlhIHRoZSByZXRpcmVfdXB0byBwYXRocykgbXVsdGlwbGUgdGltZXMuIGk5MTVfcmVx dWVzdF9yZXRpcmUoKSBzaG91bGQKPiBvbmx5IGJlIGNhbGxlZCBvbmNlIChvdGhlcndpc2UgYXNz ZXJ0cykuCj4gCj4gU28gaW5pdCArIGxpc3RfZW1wdHkoKSBpcyBiZWluZyB1c2VkIHRvIHByZXZl bnQgcmV0aXJpbmcgdGhlIHNhbWUKPiByZXF1ZXN0IG11bHRpcGxlIHRpbWVzLgo+IAo+Pj4gLSAg ICAgaWYgKGVuZ2luZS0+bGFzdF9yZXRpcmVkX2NvbnRleHQpCj4+PiAtICAgICAgICAgICAgIGVu Z2luZS0+Y29udGV4dF91bnBpbihlbmdpbmUsIGVuZ2luZS0+bGFzdF9yZXRpcmVkX2NvbnRleHQp Owo+Pj4gLSAgICAgZW5naW5lLT5sYXN0X3JldGlyZWRfY29udGV4dCA9IHJlcXVlc3QtPmN0eDsK Pj4+IC0KPj4+IC0gICAgIHNwaW5fbG9ja19pcnEoJnJlcXVlc3QtPmxvY2spOwo+Pj4gLSAgICAg aWYgKCF0ZXN0X2JpdChETUFfRkVOQ0VfRkxBR19TSUdOQUxFRF9CSVQsICZyZXF1ZXN0LT5mZW5j ZS5mbGFncykpCj4+PiAtICAgICAgICAgICAgIGRtYV9mZW5jZV9zaWduYWxfbG9ja2VkKCZyZXF1 ZXN0LT5mZW5jZSk7Cj4+PiAtICAgICBpZiAodGVzdF9iaXQoRE1BX0ZFTkNFX0ZMQUdfRU5BQkxF X1NJR05BTF9CSVQsICZyZXF1ZXN0LT5mZW5jZS5mbGFncykpCj4+PiAtICAgICAgICAgICAgIGlu dGVsX2VuZ2luZV9jYW5jZWxfc2lnbmFsaW5nKHJlcXVlc3QpOwo+Pj4gLSAgICAgaWYgKHJlcXVl c3QtPndhaXRib29zdCkgewo+Pj4gLSAgICAgICAgICAgICBHRU1fQlVHX09OKCFhdG9taWNfcmVh ZCgmcmVxdWVzdC0+aTkxNS0+Z3RfcG0ucnBzLm51bV93YWl0ZXJzKSk7Cj4+PiAtICAgICAgICAg ICAgIGF0b21pY19kZWMoJnJlcXVlc3QtPmk5MTUtPmd0X3BtLnJwcy5udW1fd2FpdGVycyk7Cj4+ PiAtICAgICB9Cj4+PiAtICAgICBzcGluX3VubG9ja19pcnEoJnJlcXVlc3QtPmxvY2spOwo+Pj4g KyAgICAgX19yZXRpcmVfZW5naW5lX3VwdG8ocmVxdWVzdC0+ZW5naW5lLCByZXF1ZXN0KTsKPj4+ ICAgIAo+Pgo+PiBJIGRpZCBub3QgZmlndXJlIG91dCB3aHkgZG8geW91IG5lZWQgdG8gZG8gdGhp cy4gTm9ybWFsbHkgcmV0aXJlbWVudAo+PiBkcml2ZW4gZnJvbSByaW5nIHRpbWVsaW5lcyB3b3Vs ZCByZXRpcmUgcmVxdWVzdHMgb24gdGhlIHNhbWUgZW5naW5lCj4+IGJlbG9uZ2luZyB0byBhIGRp ZmZlcmVudCByaW5nLCBhcyBpdCB3YWxrcyBvdmVyIHJpbmcgdGltZWxpbmVzLgo+IAo+IFJpZ2h0 LCBzbyByZXRpcmluZyBhbG9uZyBhIHJpbmcgZW5kcyB1cCBvdXQgb2Ygb3JkZXIgZm9yIGEgcGFy dGljdWxhcgo+IGVuZ2luZS4KPiAgIAo+PiBPbmx5IGZvciBkaXJlY3QgY2FsbGVycyBvZiBpOTE1 X3JlcXVlc3RfcmV0aXJlIGl0IG1heSBtYWtlIGEgZGlmZmVyZW5jZQo+PiBidXQgSSBkb24ndCB1 bmRlcnN0YW5kIGlzIGl0IGFuIGZ1bmN0aW9uYWwgZGlmZmVyZW5jZSBvciBqdXN0IG9wdGltaXNh dGlvbi4KPiAKPiBJIHdhcyBob3BpbmcgdGhlIEdFTV9CVUdfT04oIWxpc3RfaXNfZmlyc3QoKSk7 IGV4cGxhaW5lZCB0aGUgcmF0aW9uYWxlLgoKVGhhbmtzLCBJIHJlbWVtYmVyZWQgYWZ0ZXIgcHJl c3Npbmcgc2VuZC4KCj4+IFRoaXMgaXMgdGhlbiBmcm9tIHdoZXJlIGxpc3RfZGVsX2luaXQgY29t ZXMgZnJvbSwgc2luY2UgdGhpcyBmdW5jdGlvbgo+PiBjYW4gcmV0aXJlIHdpZGVyIHRoYW4gdGhl IGNhbGxlciB3b3VsZCBleHBlY3QuIEJ1dCB0aGVuIGl0IHJldGlyZXMgb24KPj4gdGhlIGVuZ2lu ZSAodXB0bykgYW5kIHRoZSBjYWxsZXJzIGp1c3Qgd2Fsa3MgdGhlIGxpc3QgYW5kIGNhbGxzIHJl dGlyZQo+PiBvbmx5IHRvIGZpbmQgYWxyZWFkeSB1bmxpbmtlZCBlbGVtZW50cy4gQ291bGQgaXQg anVzdCBhcyB3ZWxsIHRoZW4KPj4gcmV0aXJlIGl0IGNvbXBsZXRlbHk/Cj4gCj4gV2UncmUgc3Rp bGwgdHJ5aW5nIHRvIG9ubHkgZG8gYXMgbGl0dGxlIHdvcmsgYXMgd2UgY2FuIGdldCBhd2F5IHdp dGguCgpJIHdhcyB0aGlua2luZyBhYm91dCBzb21ldGhpbmcgZWxzZSwgYnV0IGl0IHdhcyBhIGZs YXdlZCBpZGVhIHNpbmNlIHR3byAKd2Fsa3MgYXJlIGNydWNpYWwgZm9yIGNvcnJlY3Qgb3JkZXJp bmcgZm9yIGJvdGggZW5naW5lIGFuZCByaW5nIHJldGlyZW1lbnQuCgo+Pj4gLSAgICAgLyogTW92 ZSB0aGUgb2xkZXN0IHJlcXVlc3QgdG8gdGhlIHNsYWItY2FjaGUgKGlmIG5vdCBpbiB1c2UhKSAq Lwo+Pj4gLSAgICAgcnEgPSBsaXN0X2ZpcnN0X2VudHJ5X29yX251bGwoJmVuZ2luZS0+dGltZWxp bmUtPnJlcXVlc3RzLAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHlw ZW9mKCpycSksIGxpbmspOwo+Pj4gKyAgICAgLyogTW92ZSBvdXIgb2xkZXN0IHJlcXVlc3QgdG8g dGhlIHNsYWItY2FjaGUgKGlmIG5vdCBpbiB1c2UhKSAqLwo+Pj4gKyAgICAgcnEgPSBsaXN0X2Zp cnN0X2VudHJ5X29yX251bGwoJnJpbmctPnJlcXVlc3RfbGlzdCwKPj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHR5cGVvZigqcnEpLCByaW5nX2xpbmspOwo+Pgo+PiBUaGlz IGlzIGxlc3MgZWZmaWNpZW50IG5vdyAtIEkgd29uZGVyIGlmIHlvdSBzaG91bGQgc3RpbGwgYmUg bG9va2luZyBhdAo+PiB0aGUgZW5naW5lIHRpbWVsaW5lIGhlcmU/Cj4gCj4gTm8sIGVpdGhlciB3 YXkgeW91IGhhdmUgdG8gd2FsayBhbGwgZW5naW5lLT5yZXF1ZXN0cyB1cHRvIHRoaXMgcG9pbnQs IG9yCj4gYWxsIHJpbmctPnJlcXVlc3RzLiBUbyBrZWVwIHRoZSBpbnRlcmZhY2UgbWFuYWdlYWJs ZSwgcmV0aXJlbWVudCBpcyBpbgo+IHJpbmcgb3JkZXIuCj4gCj4gT24gdGhlIG90aGVyIGhhbmQs IHdlIGRvbid0IHJldGlyZSBhcyBvZnRlbiBpZiB3ZSBjYW4gZ2V0IGF3YXkgd2l0aCBpdC4KPiAx IHN0ZXAgZm9yd2FyZHMsIDEgc3RlcCBiYWNrd2FyZHMuCgpBRkFJUiBhbmQgQUZBSUNTIHRoZSBw b2ludCBvZiB0aGlzIHdhcyB0byBmcmVlIHVwIHRoZSBvbGRlc3QgcmVxdWVzdCAKanVzdCB0byBo ZWxwIHdpdGggcmVxdWVzdCByZWN5Y2xpbmcgYXMgbmV3IG9uZXMgYXJlIGFkZGVkLiBCeSBub3cg CmNoYW5naW5nIGl0IHRvIGJlIG9sZGVzdCBvbiB0aGUgcmluZyB0aW1lbGluZSBpdCBhKSBteSBu b3QgYmUgdmVyeSBvbGQsIApvciBiKSBub3QgZXZlbiBjb21wbGV0ZWQsIHdoaWxlIHRoZXJlIG1p Z2h0IGJlIG11Y2ggb2xkZXIgYW5kIGNvbXBsZXRlZCAKcmVxdWVzdHMgb24gdGhlIHJlc3BlY3Rp dmUgZW5naW5lIHRpbWVsaW5lLgoKSG0sIG9yIGFyZSB5b3Ugc2F5aW5nIHRoYXQgaXQgY291bGQg Y2F1c2Ugb3V0IG9mIG9yZGVyIGZvciB0aGUgcmluZz8gSSAKZ3Vlc3MgaXQgY291bGQgeWVhaC4u IGl0IHdvdWxkIGhhdmUgdG8gdXNlIHRoZSB1cHRvIHZhcmlhbnQuCgpSZWxhdGVkLCB0aGVyZSBj b3VsZCBiZSBwb3RlbnRpYWwgdG8gdW5pZnkgaTkxNV9yZXF1ZXN0X3JldGlyZV91cHRvIGFuZCAK cmluZ19yZXRpcmVfcmVxdWVzdHMuIExhdHRlciBjb3VsZCBwYXNzIGluIE5VTEwgYXMgdGhlIHVw dG8gcmVxdWVzdCwgCmp1c3QgdGhlIGNvbXBsZXRlZCBjaGVjayB3b3VsZCBuZWVkIHRvIGJlIGRp ZmZlcmVudCBkZXBlbmRpbmcgb24gdGhlIG1vZGUuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=