From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010C836BCC4 for ; Mon, 22 Jun 2026 21:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782163790; cv=fail; b=bjkKHBiMiE5+c8LM/Srey/1HkVPSpmQINxgHyL9SEAHvrMjOeWbIx3F0lRKWKmQrvrfXS+qTdf6ngEpD1JGho8Op2m95MXN+4UUQtDiUbu/j1kweJ7ZNcbxVj8kl0KuSNg8Fuzk1oeHW0SN7ZQMOG4W3sbWQs56fGuaZDoBGRfg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782163790; c=relaxed/simple; bh=rNYvdY5NY9qHi04aMmU9w8e9923ZEY+hkryU3mKtQh4=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=X9MMGyei8Oqs35nQbhBqFeXeFUPS6ol6UUezJ7gfUH/vSniaUUzT7V+1v/7oDXY+TIgKeFpa9RE22G7OkErgYoChy4LApF8WdL71AzP46cSvqHHsKDbZFeySD325mdmGcNNMkcIjBnmcWFcyIN4DKtdMcVsY7LaMyJ+yDSUXvNk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fNvnygEp; arc=fail smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fNvnygEp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782163789; x=1813699789; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=rNYvdY5NY9qHi04aMmU9w8e9923ZEY+hkryU3mKtQh4=; b=fNvnygEp5ME9FgADCFDFUw2sCZUhOKB1PNuJGOk6z64m3YjrfxK2Avpg xrz8M60gw4uxSNDjaM8/rAETd9dfaHs++vYSaiMbXLRcVeRbDOkoqayBb Qt0okodTawvv9HDPu3LgiQObhh40WTu9PhhtXPzxZjkjzZ6GayBEEBTO3 8etei7Wpm/0A4MOuD33Uox6wIdee76t/B180oTbbZxbGxxlhqL79sK/hJ 7jA6cUrPlZl1LuNNKeT6HXJUHMd3w8ilHjSbjqXKaaAc7QEyFORdnJx0I Qy+l62JgraB/I+2GlK0QjAND74z7N72dVvva+VxAj33HG3uk8YqZilLY4 g==; X-CSE-ConnectionGUID: CNs38pNkSEiTlqoXU0ZnpQ== X-CSE-MsgGUID: yzR3j5OLSJSX44YoNoFIqg== X-IronPort-AV: E=McAfee;i="6800,10657,11825"; a="86592131" X-IronPort-AV: E=Sophos;i="6.24,219,1774335600"; d="scan'208";a="86592131" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 14:29:48 -0700 X-CSE-ConnectionGUID: 8BPk3axqT/+BSOjor2p8Jg== X-CSE-MsgGUID: zE3FtyC+Rq6XkdS2lTRBGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,219,1774335600"; d="scan'208";a="249194093" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 14:29:48 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 22 Jun 2026 14:29:48 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 22 Jun 2026 14:29:48 -0700 Received: from BL2PR02CU003.outbound.protection.outlook.com (52.101.52.53) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 22 Jun 2026 14:29:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hyhEhggRE0rEaZSgK0c6uFMdDMLxabEpQtDpwZQwm88V48PvLtXy85Z9hkPQg/3gyegd7FtXqKIlQnZa2CSsLg2zakiZk36RwFK5VsJRR/m+SgsOdTk6Gk3tL1xc6ITvpx7XKqzj02j7ewhFdl8prP+6/l1M4T7RCbZ6Z3mfVVUvprfkFmmx9xG/a5qNkQo8yKqZk9HOxW75wKYiLg3kJYP+Fl0zjLp90YpkJCoM6swTPuiLKq8nGM4/S4r+wGr4xqlGetN8VRBAUmhfZDiyJbCh1esaNPA5N/3ReDCgBCLyTRHlXaCcRQX2RkMRi/2zdtkfq6CW4R7sYe58blij2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9y6pzTEsEfWp1WRd+ZTYohcUgFZmtqG2VJHRLjFFhEk=; b=sAvHwM+4ouHCkKhuVWzU+Fsai6I8PgZWLscfLKGRaeHSatvXXkoQ8h9FqR2UWqcP39R9v0gLBSlbSVOqiEQtCbW7ildRApw7fDVplUc7bN6mAMKUpe6EocV8WGYqLxIjeNwmDAZ07mR1aotO7V4CHRc3q4wL5Uo84H8xb4qETZIiw+hpUJkoYWHu3Gdlqj8CjS/XOL2g68rLhwaMDMjEtlkmjT665VcqxLeAMfNqS8nKxWmTfzZcVFERnm+aAgEeDHqU7a4GTD8QIdkPPFfYxvIlDaI0eD+NZDuCKOGxF9HN0+0fBK6nv09ikKBPWi/d8JT0aQzbLNli5BR6wllAqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by DS4PPF2F49754B6.namprd11.prod.outlook.com (2603:10b6:f:fc02::1a) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 21:29:44 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0139.018; Mon, 22 Jun 2026 21:29:44 +0000 Message-ID: Date: Mon, 22 Jun 2026 14:29:43 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] x86/resctrl: Rename prev_msr to prev_mon_val To: "Chen, Yu C" CC: , , , , , , , , , , , , References: <2e9bd6a1a012b937e9205908ab6bbb09a21e0f71.1781332698.git.yu.c.chen@intel.com> <3ee018f0-689d-4175-bfd2-dda62a4aa45b@intel.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR04CA0363.namprd04.prod.outlook.com (2603:10b6:303:81::8) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|DS4PPF2F49754B6:EE_ X-MS-Office365-Filtering-Correlation-Id: 8578cdca-45d7-4f34-30e6-08ded0a560cf X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|7416014|376014|18002099003|22082099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: o4VcbMl40k5m8QDF3/f3i2GR+zCkPuSOuIhH3WNwAUaFd3lXPDD/SRfxou/XNF/iFYgbsqTF6UhkJEJ1K9V8iZ12Yte+HMP6d1yjEzZ0xLF2jnmERvFf2LuTk4Kn7/t5UG9ZiScxtY0vhIeRytswjnkFJIfxPwpMFEuZMyy6PoiFwv19+ogNGLnAbHy+FzoFjNd+Q3qtAkFmCKH3tyAbERF4pn4e+XlQOtXOVUxq964COagIFpT5uw9+GI4HpCq7zWFirLzI31mvZ8WzvvRrscx8bVfwPe+iP73wWz9PMmz3/1fdFwkD2EjQ1TAwCJ7bvsQxBr7E/G+HJWeN3vOeKn28cg8Muwli6qRPxIV+rArGKEnsbRJtlANlOMlUm6RqqW4+z2ev/BGnuNmsGP5N5T+Yb53+QA4mg/VTProVTJ6lBmWlKoL0NlP9bXOThU0qHy8+r+9TOQ4xiv2IrzDlqfgeF0eqx3TBCiqPH0Go1Viny1fjixWQAA3kBtOjfPPfOW0WdjdvaOFTydGcIeMR0DSdnjFldv2yTDxwf9PklG+nXhMw1dTRz0bFNG7YTpfoLVHO+dIxu0mxuiCRDdWP/roOtP7ezhydZy0g+/jG9pIXwraGGhpYEWIeY8gNNmHjNxQBM1jPmuAxsOQyi/zt/p/G9TSXYKa5ckp8jRuatiw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(7416014)(376014)(18002099003)(22082099003)(4143699003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2VVQ0JrWUVSN2lMUFpHM3BVWmVBNlBxcXFhdXFLajlXZUVva3pvTlVQVmpP?= =?utf-8?B?QldoSDhEWnVTMFYxcjVZbGVCbjlVaHV5M1Z5b3Zaa0NVcU5YejBNdzJpcHdq?= =?utf-8?B?dXRlSE1FanZFc2xLb2dWNUpVTjBNdFlyQUtLWmt0UUM4RDFBdWdVOEo3Y0d0?= =?utf-8?B?K0pObHh4bytNdUIxbUZKbU8vWFQyOUdTdWFVdUdOM0VrOEFOK1Q0Z1JQY0NP?= =?utf-8?B?ZEFVMGtGSnBUYUIrM3FIaENUNnRVS3FRTy9oRFVRb1h0OGdrb3lBOXhuelBP?= =?utf-8?B?TVQra25IZlZGWjJjcW9IUEhkNk01aXVScjh2VGg5T01tLzgxR1hFeWtyS081?= =?utf-8?B?d2g2dTE4RlJUZFluVnNzMzlYZmJwMm1PdFNrV0JJYVRuNWV2L0NNSlg3c1RO?= =?utf-8?B?V0NuSWQvWWFRbC9UTWFCVkRKUmNhak1WOXhnZFJaVEdWWmRDdlp1R1dnVzZR?= =?utf-8?B?YzJsWGpWNXJBcGhUWEdpTU9LMlpJQjIyZXhPZHRWempONFJNY0hNNFRhSjFh?= =?utf-8?B?U3dTaVAwb3plZGxVQXFkalRvZnhTMkdOQVFWQWdEN0gySmtMd3B0WW51VUJO?= =?utf-8?B?T2c2OTMyNDJ6TGtKYlBPYndHQUtNRHEyUHRGUGIzVGJUclM1aUlqQ085U2xk?= =?utf-8?B?OTRab1Yxd2JpWmVab2NGVkJSM2VXb1pBMmFWbEZEQy9sZjFaWXNlZDBFUTNP?= =?utf-8?B?aVZVc0l4cmFBQWZEb1lEaW4zYW9USFZyM2QxcFQwakNWTkdRSzA4TzNUeUJo?= =?utf-8?B?SjVMb1lzTWh3NHVHaDdHZVlHTnlrNjludVNvSHNoZ3cvWUx0TDYzQmhJZE84?= =?utf-8?B?M0lnTnRoS1BMTmxUUXJMTGsyU21jZ1lUemFTUU0vWjM0dW1aajNZNVN3RmxF?= =?utf-8?B?dXJodVVQd1QwL3o0K1ErZlUrYjI2b3NZNytFQmdxckQrNGFsSWRLQ1VTbnhy?= =?utf-8?B?NldoWWJFNkdWS2tsb2daRTBObFlvVU52TVljRUIyN1lzaUdJZlhFNFkwdE1t?= =?utf-8?B?RysvaUNFNEY2Y2owa1BIcnZVckJ1TmxySkcxMFVnS2djQXBNYXZvdVhxZmI0?= =?utf-8?B?Z3JCZThIajZPLzIxMlplanlFQVpHWFhNRlBhMjFvMSt3cUZoZGNiclRPSkM0?= =?utf-8?B?M1o2Q0pwSUx1ZlpYdnpWMCt2d04vSUZkRlh0bFhNVGJJNlE5YTV6L054aUs0?= =?utf-8?B?U1BldTlPMjMvVHFzMFhVTFdOcmxVZGZhbUVOTjZ1TDRDei9zbEJiZDI0MEl5?= =?utf-8?B?NVNmWnZQMHAxcGNIVTJmZ1hmNmZOUGJYYU02VjZWSmI3Y3EyUmtFbGpmMW9O?= =?utf-8?B?bzNmVHJVcVFsYllxY2dKaW1DelBuNEFJd0JpSW5RWlpiN0gyVmlNcVJkblBa?= =?utf-8?B?VjhienJCRStJK09MaUoxa1NPWmxVOG10WDdSZ1A0ZHEyR0lXRmNZVmdEUGRO?= =?utf-8?B?OXVLTzVOaktVYnowUDZ3QklFeTNFSzR5M1FmZkVsNEloSHNEYS9wV0RRcDQ1?= =?utf-8?B?MFhjS0FFQ3FWbGR1SFFMNnZDOEl2RXE4dzN1R0R6a3R5Rit5NDhlSXM2dXRG?= =?utf-8?B?OWNKbFNFWFVkR084MjhyMTA2RzdmVnY5alV3cVBiKys0c1RWUkRXcnY0VGxh?= =?utf-8?B?cG1BNjhEVDA5a1lvaWthaWlVNXdrRUVZc2w0dFZFTURJelhIVXRqT0YxeVFk?= =?utf-8?B?VnZsajRBVTJGQUhVMkd3MGpGNDJYQW1zaFJUenM0aE5yWnh0VDE1eUYwaHhp?= =?utf-8?B?YnBBMHV1WlpNbUhQS0lOVkxtTFp0YkxOcStwZ1VEdFBDN0JuRjZGQ2tCMWxI?= =?utf-8?B?VUo3cUg2V2Y5VFZyQ05zbUNSaUJZa2ttOUlzYiszbHNwVnloSGNDRlZsTGF1?= =?utf-8?B?bTVaQjBkRXFyNnNCa21JK1ltZmNXaVpBSkp2QVpHNElaZk9nMm9Db3p6U2pj?= =?utf-8?B?R1lyNXV4WEh1MDJxcUE0MFk4Z0oxNjFpTGJKUlBWT2F4QTVrQ0huTzc5dGMw?= =?utf-8?B?NjBleTFpb2NFWnFKR0x5VmNzdFJkUlN1MndVMElHQTJZWFIvelJRV3FnYkpl?= =?utf-8?B?VXNHOUx4SjBCeTd0b3QvMWRXTEJBb2lvTkZIbW1acUV0cnB2Z1hmSDYzUVl1?= =?utf-8?B?Qk9VMXV5VzhWdGZnMjNqd1Y3L2dnUUtod0w1YUorRFE2eGV6bGw4d1NRbkhG?= =?utf-8?B?ZFg3UTd0RnRtcGlDVklWUmlmS3hNLzV0bFowVEdRWVdQQmxZVTNEcE9VK1Fa?= =?utf-8?B?Y2xvMTVoalRlYXpzTDVYaGlLREk4NzN2UTNWREdvTHpreldnYUcwd25TN2NE?= =?utf-8?B?WnFwaGRVZTNJVk1oU2lDMldBeEpIU3FJWnozSkhZWTV5VnlJK3VvaEZzdTFJ?= =?utf-8?Q?hTm5imb3zHi+ryOA=3D?= X-Exchange-RoutingPolicyChecked: Cze52G0rQEFTY7IJ/kETFAUVSQgto8bLhU1HVqEb0sdx0bfoGQqSdFOBCt3CLkQiJKWZYx8mCiwUDKaZ5Y0sQYzaxRH4IozJHoTMPxE74G4nJPOSpUck7Q15mRXBC4zqr6A4o6oYsyIKoBNZn/A5uK5vFc5uSy1U3D6KabXVQPMhV4ASwTooN56RVR7GC/ae7bO2JRxE65/J8Wd+25BLipxi5hP2VVGVaIURy6DVHN/r5pXBJY9oIDNBrFsWcYxv39KiNiogWkHljPIh12nG0nYqwOSpQ8iJDyyUyIbKr7hn+NH6waAo1we/nb2rV8dK6FUXEKivQQNAMlIQS6143w== X-MS-Exchange-CrossTenant-Network-Message-Id: 8578cdca-45d7-4f34-30e6-08ded0a560cf X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 21:29:44.6753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jj9ahsZy4LtD2tJLRRE8QVp4m7szry28kjBY35IrvCeLqJgLMawtp17c1jd7FX8FWmGnH6MqQ3i+3mG7aJJAwCuV9ZNHoatuMa4hBfCI388= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF2F49754B6 X-OriginatorOrg: intel.com Hi Chenyu, On 6/22/26 5:42 AM, Chen, Yu C wrote: > Hi Reinette, > > On 6/19/2026 7:39 AM, Reinette Chatre wrote: >> Hi Chenyu, >> >> On 6/13/26 12:57 AM, Chen Yu wrote: >>> Rename the prev_msr field in struct arch_mbm_state to prev_mon_val. >> >> This change as described seems out of place when considering the following >> from cover letter: >>   This patch set focuses on the first part: enabling MMIO-based access for >>   Cache Monitoring Technology (CMT), *while CAT/MBM/MBA are still using MSR*. >> >> It is thus confusing to find a change related to switching MBM to use MSR >> in a series that claims that it does not do this. >> >> The patch looks fine but reading the changelog and the first few hunks makes >> this patch look out of place. Could you please update the changelog to be >> accurate about what this patch does? >> > > OK, let me change it to: > > x86/resctrl: Rename prev_msr to prev_mon_val > > Rename the prev_msr field in struct arch_mbm_state to prev_mon_val > to decouple the field name from the specific access method. This patch changes many more names to support this switch to MMIO yet the changelog only highlights one of the changes which is the struct member specific to MBM while the work explicitly states that MBM monitoring is not impacted by this series. Consider for comparison a more generic (just a draft to present an idea, please do not just copy&paste): x86/resctrl: Replace "msr" in monitoring data identifiers Monitoring data is only consumed via MSR and many identifiers handling the monitoring data contains "msr" as part of their names, for example "msr_val". Replace "msr" in monitoring data identifiers as appropriate to support their use for monitoring data accessed via MMIO. > > Use a generic name for the stored previous monitoring counter value > so that the field remains accurate regardless of whether the value > is read through an MSR or another interface in the future. > > No functional change. > > thanks, > Chenyu