All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Felipe Balbi <balbi@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 2/2] dt-bindings: usb: snps,dwc3: Add the compatible name 'snps,dwc3-rtk-soc'
Date: Tue, 2 May 2023 10:37:39 +0000	[thread overview]
Message-ID: <c44baa9fae5c445c90103cd2e129ab0b@realtek.com> (raw)
In-Reply-To: <f51b4dc9-e1da-7c9c-1e39-c8510569db9d@linaro.org>

Hi Krzysztof,

> >>>> On 02/05/2023 07:04, Stanley Chang wrote:
> >>>>> Add a new compatible name 'snps,dwc3-rtk-soc' of DT for realtek
> >>>>> dwc3 core to adjust the global register start address
> >>>>>
> >>>>> The RTK DHC SoCs were designed, the global register address offset
> >>>>> at
> >>>>
> >>>> What are: "RTK" and "DHC"? These are manufactured by Synopsys as
> >>>> you suggest in the patch?
> >>>
> >>> RTK is Realtek.
> >>> DHC is the department name in Realtek and the abbreviation of the
> >>> Digital
> >> Home Center.
> >>> The USB controller of RTK DHC SoCs used the DWC3 IP of Synopsys.
> >>
> >> Then entire compatible is not correct. Vendor is Realtek not Synopsys.
> >> DHC is not even device name. Use real device names.
> >
> > So, can we use the compatible name as 'realtek,dwc3' ?
> 
> dwc3 is not a real device name for Realtek.

We still use dwc3 IP in Realtek's SoC. Why is the name "dwc3" inappropriate?

Should compatibility names use the SoC name?
For example, our SoC name
RTD129x, RTD139x, RTD161x, RTD161xB, etc.
Should we use these names in compatible names?
"realtek, rtd129x", "realtek, rtd139x", "realtek, rtd161x"...etc.

Thanks,
Stanley

  reply	other threads:[~2023-05-02 10:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02  5:04 [PATCH v4 1/2] usb: dwc3: core: add support for RTK SoC custom's global register start address Stanley Chang
2023-05-02  5:04 ` [PATCH v4 2/2] dt-bindings: usb: snps,dwc3: Add the compatible name 'snps,dwc3-rtk-soc' Stanley Chang
2023-05-02  7:40   ` Krzysztof Kozlowski
2023-05-02  8:05     ` Stanley Chang[昌育德]
2023-05-02  8:44       ` Krzysztof Kozlowski
2023-05-02  8:56         ` Stanley Chang[昌育德]
2023-05-02 10:15           ` Krzysztof Kozlowski
2023-05-02 10:37             ` Stanley Chang[昌育德] [this message]
2023-05-02 19:27               ` Krzysztof Kozlowski
2023-05-03  3:14                 ` Stanley Chang[昌育德]
2023-05-02 22:36 ` [PATCH v4 1/2] usb: dwc3: core: add support for RTK SoC custom's global register start address Thinh Nguyen
2023-05-02 22:39   ` Thinh Nguyen
2023-05-03  3:08   ` Stanley Chang[昌育德]
2023-05-03 22:37     ` Thinh Nguyen
2023-05-04  3:28       ` Stanley Chang[昌育德]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c44baa9fae5c445c90103cd2e129ab0b@realtek.com \
    --to=stanley_chang@realtek.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.