All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Pardeep Kaur <pardeep.kaur@oss.qualcomm.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
	Hariharan Ramanathan <hariharan.ramanathan@oss.qualcomm.com>
Subject: Re: [PATCH ath-next 6/8] wifi: ath12k: track per-ring RX sent-to-stack count
Date: Sun, 26 Jul 2026 09:11:30 -0700	[thread overview]
Message-ID: <c455a465-254c-48e6-9183-7b67d4b76dc1@oss.qualcomm.com> (raw)
In-Reply-To: <20260723125448.922361-7-pardeep.kaur@oss.qualcomm.com>

On 7/23/2026 5:54 AM, Pardeep Kaur wrote:
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c b/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c
> index b203513d63cc..33c4c89eefb5 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c
> @@ -651,7 +651,10 @@ ath12k_wifi7_dp_rx_process_received_packets(struct ath12k_dp *dp,
>  			dev_kfree_skb_any(msdu);
>  			continue;
>  		}
> -
> +		if (likely(ring_id < DP_REO_DST_RING_MAX))
> +			partner_dp->device_stats.sent_to_stack[ring_id]++;

My review agent had the following finding which I did not try to validate:

sent_to_stack[] is incremented on partner_dp but reo_rx[] is on dp — this
splits correlated stats across two devices' debugfs files in MLO

In a 2-device MLO group, ath12k_wifi7_dp_rx_process_received_packets()
increments partner_dp->device_stats.sent_to_stack[ring_id] (the msdu's
originating device), while ath12k_wifi7_dp_rx_process() increments
dp->device_stats.reo_rx[ring_id][device_id] (the ring owner).

Reading /sys/kernel/debug/.../device0/device_dp_stats shows reo_rx[ring0]=N
but sent_to_stack[ring0]=0; device1's file shows the reverse. The two counters
meant to track the same traffic path cannot be compared from a single file.


> +		else
> +			WARN_ON_ONCE(1);
>  		ath12k_dp_rx_deliver_msdu(dp_pdev, napi, msdu, &rx_info);
>  	}
>  



  reply	other threads:[~2026-07-26 16:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 12:54 [PATCH ath-next 0/8] wifi: ath12k: extend device DP stats for TX and RX observability Pardeep Kaur
2026-07-23 12:54 ` [PATCH ath-next 1/8] wifi: ath12k: fix out-of-bounds access on TX stats arrays Pardeep Kaur
2026-07-23 12:54 ` [PATCH ath-next 2/8] wifi: ath12k: rename wbm_status to htt_status in HTT TX completion Pardeep Kaur
2026-07-23 12:54 ` [PATCH ath-next 3/8] wifi: ath12k: add TCL ring TX buffer allocation failure counter Pardeep Kaur
2026-07-26 15:42   ` Jeff Johnson
2026-07-23 12:54 ` [PATCH ath-next 4/8] wifi: ath12k: add device DP stats reset support via debugfs Pardeep Kaur
2026-07-23 12:54 ` [PATCH ath-next 5/8] wifi: ath12k: add WBM RX error drop statistics Pardeep Kaur
2026-07-26 16:00   ` Jeff Johnson
2026-07-28 12:22     ` Pardeep Kaur
2026-07-23 12:54 ` [PATCH ath-next 6/8] wifi: ath12k: track per-ring RX sent-to-stack count Pardeep Kaur
2026-07-26 16:11   ` Jeff Johnson [this message]
2026-07-28 12:24     ` Pardeep Kaur
2026-07-23 12:54 ` [PATCH ath-next 7/8] wifi: ath12k: fix 1-based ring index in REO Rx Received debugfs output Pardeep Kaur
2026-07-23 12:54 ` [PATCH ath-next 8/8] wifi: ath12k: add WBM SW desc fallback counter Pardeep Kaur
  -- strict thread matches above, loose matches on Subject: below --
2026-08-06 10:06 [PATCH ath-next 0/8] wifi: ath12k: extend device DP stats for TX and RX observability Pardeep Kaur
2026-08-06 10:07 ` [PATCH ath-next 6/8] wifi: ath12k: track per-ring RX sent-to-stack count Pardeep Kaur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c455a465-254c-48e6-9183-7b67d4b76dc1@oss.qualcomm.com \
    --to=jeff.johnson@oss.qualcomm.com \
    --cc=ath12k@lists.infradead.org \
    --cc=hariharan.ramanathan@oss.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pardeep.kaur@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.