From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
Rasesh Mody <rmody@marvell.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Anoob Joseph <anoobj@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>,
Igor Russkikh <irusskikh@marvell.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: release port upon close
Date: Wed, 30 Sep 2020 09:28:42 +0100 [thread overview]
Message-ID: <c4727bc7-1579-84cb-faab-e817daef9c40@intel.com> (raw)
In-Reply-To: <CALBAE1NQw69gNce8szPyNbazNufzKaqN7SaZyoCk0i=9pYm4mg@mail.gmail.com>
On 9/29/2020 7:20 PM, Jerin Jacob wrote:
> On Mon, Sep 28, 2020 at 4:07 AM Rasesh Mody <rmody@marvell.com> wrote:
>>
>> Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources
>> for the port can be freed by rte_eth_dev_close(). With this change the
>> private port resources are released in the .dev_close callback.
>>
>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>
>
> It looks like it has ICC compiler errors in this patch[1]. I don't
> think, it is introduced by this patch. It is from CPT crypto driver.
>
> [1]
> http://mails.dpdk.org/archives/test-report/2020-September/155058.html
>
These patches seems pulled to the Thomas' "cleanup ethdev close operation" patchset:
[v3,17/29] net/qede: release port upon close (https://patches.dpdk.org/patch/79083/)
[v3,06/29] net/bnx2x: release port upon close
(https://patches.dpdk.org/patch/79072/)
Can you please review the patches in that patchset? And they can be merged with
the whole patchset.
I will mark this set as superseded.
Btw, agree that compile error looks unrelated.
prev parent reply other threads:[~2020-09-30 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 22:36 [dpdk-dev] [PATCH] net/bnx2x: release port upon close Rasesh Mody
2020-09-27 22:36 ` [dpdk-dev] [PATCH] net/qede: " Rasesh Mody
2020-09-29 18:20 ` [dpdk-dev] [PATCH] net/bnx2x: " Jerin Jacob
2020-09-30 8:28 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4727bc7-1579-84cb-faab-e817daef9c40@intel.com \
--to=ferruh.yigit@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=irusskikh@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=rmody@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.