From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72DD23AE6FA for ; Thu, 30 Jul 2026 06:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785392682; cv=none; b=irj8XASYRKqRHzTJ7JkcZHPB6phG31jSHSDyGANkq3GIwbQOeCYnoEs8BQTMmCDFDXCtYcGijMiHEckL6Ogz8J34ZfoOdyzD8cuJK9Cejp6DyVDefiZiKE6+I6w55EoyvwSAxvk6WywbdMgERmzIpkDtbzqM5EPeqVoiMaXPxAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785392682; c=relaxed/simple; bh=C3AKDqMOcScupHwMTToPCH83CNLnmc5x7T8pxyF+xgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CiDg5K40Qt8+qREzSGU4taAE3xD4d4CfgKN7DeatYa+v9IDBPdtB0TUDzGvePGAOXSyttot9gsxNkJ9tWrXfSTrZ+5yMCvkOThsSGJSOSmodjujF6UyLSkQCPREKKac8nepsMm72sTL8SaQzoyfdliKUa9ZIMaBjZM9Yri30ubo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PGIrya//; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PGIrya//" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B72461F000E9; Thu, 30 Jul 2026 06:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785392681; bh=SwccytV2B70zPPZl28k2aY6iXbyDzW4BAwGCPpYWraI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=PGIrya//QF7IX3sHsPiXwclfRw3PBTpbH/JETP8D0lvfOQBPj6BZy/ijonWy+ucYU +v6ksmApE0eGxbyclb2NRrP2mCyfX+LZe6mH1Em0DCPJqZr1R5ftXZzUBNn2E+dtSd 3E3VwG8vpM/vBBjodrFYF0QtqH+ppeBpjmf1j5H5jVaaFRbIPcqWY8++zAwAKJffcE fewO4854xgKvQ0Gv5VM38De+0uzMwrLjVL4JyXqNjDRjkyvZOI1SEUPEOjsRlRKRI2 LwdWSw3lsBtm7GRVoXuxh95LDSBq/CvNpZT5dePnqDa2VewWqS9DzfclAtCyxdBYcP 3wkzQ6L7zylvA== Message-ID: Date: Thu, 30 Jul 2026 08:24:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?Q?Re=3A_=5BPATCH_2/2=5D_powerpc/sstep=3A_Don=E2=80=99t_defi?= =?UTF-8?Q?ne_variables_we_won=E2=80=99t_be_using?= To: Link Mauve , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Madhavan Srinivasan , techflashYT , Ash Logan , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Michael Ellerman , Nicholas Piggin References: <20260729204958.755143-1-linkmauve@linkmauve.fr> <20260729204958.755143-3-linkmauve@linkmauve.fr> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260729204958.755143-3-linkmauve@linkmauve.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 29/07/2026 à 22:49, Link Mauve a écrit : > It seems this function has only compiled without warnings on PPC64, not > on PowerPC, so before this commit it would fail with: > ``` > ../arch/powerpc/lib/sstep.c: In function 'analyse_instr': > ../arch/powerpc/lib/sstep.c:1350:28: error: variable 'suffix' set but not used [-Werror=unused-but-set-variable] > 1350 | unsigned int word, suffix; > | ^~~~~~ > ../arch/powerpc/lib/sstep.c:1346:38: error: variable 'rc' set but not used [-Werror=unused-but-set-variable] > 1346 | unsigned int opcode, ra, rb, rc, rd, spr, u; > | ^~ > cc1: all warnings being treated as errors > ``` > I'm surprised we still have this issue. I remember seeing it reported several times allthough I've not been able to spot when. By the way on my side it happens only when I do a W=1 build. Same as previous patch, I'd prefer using CONFIG_PPC64 instead of __powerpc64__ > Signed-off-by: Link Mauve > --- > arch/powerpc/lib/sstep.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c > index 597a0d841fe8..c866e4337f94 100644 > --- a/arch/powerpc/lib/sstep.c > +++ b/arch/powerpc/lib/sstep.c > @@ -1342,16 +1342,20 @@ int analyse_instr(struct instruction_op *op, const struct pt_regs *regs, > { > #ifdef __powerpc64__ > unsigned int suffixopcode, prefixtype, prefix_r; > + unsigned int rc; > + unsigned int suffix; A single line would be enough: unsigned int rc, suffix; > #endif > - unsigned int opcode, ra, rb, rc, rd, spr, u; > + unsigned int opcode, ra, rb, rd, spr, u; > unsigned long int imm; > unsigned long int val, val2; > unsigned int mb, me, sh; > - unsigned int word, suffix; > + unsigned int word; > long ival; > > word = ppc_inst_val(instr); > +#ifdef __powerpc64__ > suffix = ppc_inst_suffix(instr); > +#endif > > op->type = COMPUTE; > > @@ -1469,7 +1473,9 @@ int analyse_instr(struct instruction_op *op, const struct pt_regs *regs, > rd = (word >> 21) & 0x1f; > ra = (word >> 16) & 0x1f; > rb = (word >> 11) & 0x1f; > +#ifdef __powerpc64__ > rc = (word >> 6) & 0x1f; > +#endif > > switch (opcode) { > #ifdef __powerpc64__