From: dkota@codeaurora.org
To: Doug Anderson <dianders@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Mark Brown <broonie@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
devicetree@vger.kernel.org,
Girish Mahadevan <girishm@codeaurora.org>
Subject: Re: [PATCH V3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP
Date: Mon, 10 Sep 2018 09:27:09 +0530 [thread overview]
Message-ID: <c4982ce3fde57c86387cc906332f6d48@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=VzYYyive--RzN=_OCQnFT-wgHwbUy1Vao2-8GADxHDLw@mail.gmail.com>
>> I see there is no need of taking the spinlock as timeout will be
>> handled
>> after the calculated time as per data size and speed.
>> There is 99.9% less chances of interrupt during the timeout handler.
>>>
>>>
>>>
>>> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1201081
>
> The thing is, we want it to be 100% reliable, not 99.9% reliable. Is
> it somehow wrong to add the spinlock? ...or are you noticing
> performance problems with the spinlock there? It's just nice not to
> have to think about it.
As I said, timeout will be handled after the calculated time as per data
size and speed. Enough time is given for interrupt, there is no chance
of interrupt occurrence during the handle_fifo_timeout(). So there is no
need of spinlock.
next prev parent reply other threads:[~2018-09-10 3:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 10:42 [PATCH V3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP Dilip Kota
2018-08-25 5:21 ` kbuild test robot
2018-08-25 5:21 ` kbuild test robot
2018-08-25 6:14 ` kbuild test robot
2018-08-25 6:14 ` kbuild test robot
2018-08-29 0:25 ` Rob Herring
2018-08-29 11:19 ` dkota
2018-08-30 0:30 ` Rob Herring
2018-08-31 0:49 ` Stephen Boyd
2018-08-31 0:49 ` Stephen Boyd
2018-09-02 5:06 ` Doug Anderson
2018-09-02 5:06 ` Doug Anderson
2018-09-07 10:00 ` dkota
2018-09-07 10:14 ` dkota
2018-09-07 16:19 ` Doug Anderson
2018-09-07 16:19 ` Doug Anderson
2018-09-10 3:57 ` dkota [this message]
2018-09-10 11:26 ` Mark Brown
2018-09-10 14:24 ` dkota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4982ce3fde57c86387cc906332f6d48@codeaurora.org \
--to=dkota@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=girishm@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.