From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75FD8E57F; Wed, 8 May 2024 17:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715189791; cv=none; b=VXym42hgxWsFHsZ45CWS8ASaDA6ingDD3pVKM8ei5gsP6wkxKZG1IjH4nZo5ymZnfO8m2L0T769EUGaNEG9sWPYOq52bTYESHUc/xi8MjAmD4bHm43y6ybuiBJNG8K0jLOhJoTCWo4iacFdSYjEeEnr6dQE3aPL4gRhY3OBbnZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715189791; c=relaxed/simple; bh=WvGRDpFnU7bdvexiQnVTby+Q8hc/HiA1N+1bPXgNymI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bu36QB4TNbQ4opj4AXLDDsCY7/PdI+HNIwuPuQj7XuTHryB1eSF7arMXk1xV1q/DCpCHDFTlbUHQG5Z1pssDo3CmGTWdF5AbA1kNZJ5LFKrDSW54btOFqGHhRWokD8c3QEOYESIyxrjVK+FMgpDIewd8uZJQlsD2QLo6gW3oxug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=2QUxa6go; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2QUxa6go" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IJWHD6fJD+RTBbtpWt6pxNfFmH4N0xHA3T0EGF6awZY=; b=2QUxa6goXrmd7mthrh8ujrZ590 +3ABIjgJ/XwGcyAuqlsvFjwD7XKCu2xvBKAFb/JJQnYFqiyXaj6I/Y7pVCMqtPJ89ojccc3lbS3ep J2L2+9mcoOn120iQVHIrHPA6PICHVYsDVIL+Q01EVP5CVarRztYx2Qr6+FQDbr5eDwI0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s4lDF-00Eyhb-Qb; Wed, 08 May 2024 19:36:17 +0200 Date: Wed, 8 May 2024 19:36:17 +0200 From: Andrew Lunn To: Geert Uytterhoeven Cc: Niklas =?iso-8859-1?Q?S=F6derlund?= , Yoshihiro Shimoda , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [net-next,v2] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN Message-ID: References: <20240507201839.1763338-1-niklas.soderlund+renesas@ragnatech.se> <4970fd77-504c-4fb3-9c47-e4185d03e74a@lunn.ch> <20240508105831.GB1385281@ragnatech.se> <20240508125557.GG1385281@ragnatech.se> <51b6a4f8-ef48-400f-acb6-fd20e661802d@lunn.ch> <20240508151043.GH1385281@ragnatech.se> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > While explicit clock management works, please use pm_runtime_*() > instead, as the device is part of a Clock Domain. Also, the TSN > block may be reused on a different SoC, where it is part of a real > power domain, and manual clock management won't be sufficient. Please document this in the commit message. It was not obvious to me at least that pm_runtime without callbacks can effect clocks. Andrew