From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B50D228EA; Thu, 21 Nov 2024 04:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732162592; cv=none; b=gyT+C5AoMHPHfLQySlkLBbsTYr80WqvM+6I0heqbOL0Am4OgXeb6m4FNnR7+38QTivUBgXvDqqVZomsY8D7PlYoMCffBfVKNE9OemE8TAifQJaJyHwpmJFvpZzYj9sGBHAJs3rrkcrH+IOzHghvBim17AcT1/zZRqLKEHBDT1sE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732162592; c=relaxed/simple; bh=Y+/X5y+yOOcp+eDwa/X5cH1NJiN6/TPYFLkSwME5Pj8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=WxX5lNZSL/NmnW3FD5QL5G45c12+IliL0aszK2BZx6UGrNeZJDUzzqEZVmYin/SJ60X02xEuxQGPJbH3Hc8sw90gWkPSnwa7p+5r8wAdmfcmdH6bMMNueZoT5WtuKYsnu/Qnf3rJKTwL81nU+ije8+7tFahXYUet4jhq9n+lvI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=ndoCggms; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="ndoCggms" Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DBBC189650; Thu, 21 Nov 2024 05:16:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1732162583; bh=0UnkVnltLG3gtKs1MUzm4I6PyPNWkwlXSmfZHQuFfgQ=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=ndoCggmsvv8eO0/3DCC7mFyFaabjhnTYuVsZPSrTG0UODUfK5xphPnOtd2jwx01yL 7MgOBm6kIxIZqYNsVJgL6pIppZ+Jb7jcn1tsogiu89XD+MYhrWdCpcTWP/Ukp7+959 IBznUbMpWtrH+mSNk8/G4IDzNrIithOnZBF+KcjD8zCxQW2sGej9IrCFk7bKqmwEy3 LtJs+jTyh4k2UIFkad1SqFMn8RqJv63HrAC1+V2f7FU+85nw6nFchV8YZ3umKQAlZG csSKpwY/45SNIsI01Los1ct6iaQSobFZUDKnGADXlVB9XOQ8eyd9djMfUUeKFOhBQt 0BMPNqGVwmg6A== Message-ID: Date: Thu, 21 Nov 2024 02:39:40 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: wilc1000: Rework bus locking From: Marek Vasut To: Ajay.Kathat@microchip.com, alexis.lothore@bootlin.com, linux-wireless@vger.kernel.org Cc: davem@davemloft.net, adham.abozaeid@microchip.com, claudiu.beznea@tuxon.dev, conor+dt@kernel.org, edumazet@google.com, kuba@kernel.org, kvalo@kernel.org, krzk+dt@kernel.org, pabeni@redhat.com, robh@kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20241022013855.284783-1-marex@denx.de> <8e28ba76-ecfa-49b6-89b5-1edabb22129d@denx.de> <5e2a5056-78ac-4be0-83ca-4aa55f524535@denx.de> <880baad9-be3d-41b2-bea3-620f915ca397@microchip.com> <9d20b408-72a4-49f0-aca6-108dfdd65f99@denx.de> <16e5c8d7-64ac-424e-9430-b683ae16a34e@denx.de> <9888f605-ee68-4bd3-8d1d-aeef247d23d0@microchip.com> <260a505e-53ec-4f1d-94fe-2b71af48f1b7@denx.de> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 11/16/24 8:57 PM, Marek Vasut wrote: > On 11/15/24 9:04 PM, Ajay.Kathat@microchip.com wrote: > > Hello Ajay, > >>>>>> Can you explain how to prevent that or shall we disable uAPSD >>>>>> altogether ? >>>>> >>>>> Could you please share the test procedure and logs. I am occupied >>>>> at the >>>>> moment but I shall make some time to look into it and get a better >>>>> understanding. >>>> >>>> The simplest test procedure is this: >>>> >>>> $ while true ; do ifconfig wlan0 up ; ifconfig wlan0 down ; done >>>> >>>> As for the logs, MMCI controller sporadically reports either Command or >>>> Data CRC error, so likely the SDIO response (from WILC to Host) is >>>> corrupted. >>> >>> Are there any news ? >> >> I did test the same procedure in my setup, but I couldn't reproduce >> this issue >> even after running it for a long duration. In my test setup, I used the >> sama5d27-som1-ek1 host and wilc3000 firmware version 16.3. >> >> I think this issue could be related to the host MMCI controller driver. >> Normally, the wilc SDIO bus failures are captured by driver logs with >> an error >> code (e.g., timeout), but if the MMCI controller is outputting the >> warning >> message, then the error could be related to it. Does the MMCI >> controller error >> point to any specific function? > > Either CMD52 or CMD53 errors out with CRC error, this is recognized by > the controller. That points to sporadic CRC error during SDIO transfer. > >> Which host was used to test this scenario, and >> is it possible to test with different host or different configuration >> on the >> same host > > I am observing sporadic command and data CRC errors on STM32MP157F > system with SDIO WILC3000. > > , like disabling power save on the host? > I already tested disabling power save. > > Can you explain why does uAPSD (iw ...set power_save off) adversely > affect SDIO bus stability ? > > Can you explain how to prevent that or shall we disable uAPSD altogether ? > > Is there any way to make the WILC firmware produce debug output , so we > can figure out what is going on "on the other side" ? > > Are you able to provide me (maybe off-list) some debug firmware build ? > (or can I get firmware sources and build and debug my own WILC firmware > on the Cortus CPU?) > > I can trigger the SDIO errors even without being connected to any AP , > so this is something between the WILC and the SDIO host, the radio is > likely not involved , right ? Any news ?