All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Andryuk <jandryuk@gmail.com>
To: reinette chatre <reinette.chatre@intel.com>
Cc: Samuel Ortiz <samuel@sortiz.org>,
	Tomas Winkler <tomasw@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: kernel BUG at drivers/net/wireless/iwlwifi/iwl3945-base.c:3127!
Date: Thu, 12 Mar 2009 23:31:04 -0400	[thread overview]
Message-ID: <c4d76b3b0903122031o7baea17ay5704df428ea2fced@mail.gmail.com> (raw)
In-Reply-To: <1236742805.6267.9.camel@rainbow>

On Tue, Mar 10, 2009 at 11:40 PM, Jason Andryuk <jandryuk@gmail.com> wr=
ote:
>> You log below has a new error (similar to what you note in your next
>> email). "Unsupported interface type 515". This is very strange and
>> really looks like some corruption as this value is initialized with =
a
>> macro during probe. Could you enable mac and info debugging also (ad=
d
>> 0x3 to your current debug flags)? This code has also changed a bit s=
ince
>> commit bb64785ad94d575fe4f5f9e69f4f6c0b24e9905d.
>>
>> You can also put a dump_stack() in iwl3945_connection_init_rx_config=
 to
>> see where the call comes from and then trace the value of mode to se=
e
>> where it is set to 515 ... it is supposed to be 2
>> (NL80211_IFTYPE_STATION).
>
> See logs below. =A0I ran with debug=3D0x40003. =A0This is on commit
> "ff5010c3e12f1d0da27a5f871c2e3d5333dfbe2f iwl3945: sync tx queue data
> structure with iwlagn" with my patches to make it somewhat usable.
>
>> I am finding it hard to keep track of things as what works and what =
does
>> not work appears to shift. I did install a 64bit system in the hopes=
 of
>> reproducing your issue but could not with a basic open connect. How =
do
>> you connect to the AP? Please provide details that you think will en=
able
>> me to reproduce.
>
> The problem is that as I try older commits to find which one introduc=
ed
> the original error, I find other problems that need to be solved.
> Hopefully I have finally tracked down the commit,
> "ff5010c3e12f1d0da27a5f871c2e3d5333dfbe2f iwl3945: sync tx queue data
> structure with iwlagn", that introduced the Microcode SW errors.

Looking at ff5010c3e12f1d0da27a5f871c2e3d5333dfbe2f, I found the call
to iwl_reset_qos corrupts priv->iw_mode.  It is 2 before the call and
515 after.

I dumped priv for 32 bytes starting at &priv->last_beacon_time and saw =
this.
iwl data: 00000000: 00 0f 00 ff 03 02 00 00 00 0f 00 ff 03 02 00 00
=2E...............
iwl data: 00000010: 00 0f 00 ff 03 02 00 00 00 0f 00 ff 03 02 00 00
=2E...............

515 =3D 0x0203 =3D 03 02 little endian

We have

struct iwl_ac_qos {
        __le16 cw_min;
        __le16 cw_max;
        u8 aifsn;
        u8 reserved1;
        __le16 edca_txop;
} __attribute__ ((packed));

and

	priv->qos_data.def_qos_parm.ac[0].cw_min =3D cpu_to_le16(cw_min);
	priv->qos_data.def_qos_parm.ac[0].cw_max =3D cpu_to_le16(cw_max);
        priv->qos_data.def_qos_parm.ac[0].aifsn =3D aifs;
        priv->qos_data.def_qos_parm.ac[0].edca_txop =3D 0;
        priv->qos_data.def_qos_parm.ac[0].reserved1 =3D 0;

and
	u16 cw_min =3D 15;      // 0x000f
        u16 cw_max =3D 1023; // 0x03ff
        u8 aifs =3D 2;                //0x02

Which corresponds to the dump and what is showing up in iw_mode.

I don't know why things are going wrong though.

One problem I see is the check of staging_rxon instead of
staging39_rxon in iwl_reset_qos.
(priv->staging_rxon.flags & RXON_FLG_SHORT_SLOT_MSK) =3D=3D 0)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-03-13  3:31 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18  0:06 kernel BUG at drivers/net/wireless/iwlwifi/iwl3945-base.c:3127! Deuce
2009-01-18 17:41 ` Deuce
2009-01-26 11:44 ` Samuel Ortiz
2009-01-27  3:13   ` Jason Andryuk
2009-01-27  3:35     ` Jason Andryuk
2009-01-27 16:24       ` Samuel Ortiz
2009-01-27 23:31         ` Jason Andryuk
2009-01-28  7:12           ` Tomas Winkler
2009-01-28 11:37             ` Samuel Ortiz
2009-01-28 11:52               ` Tomas Winkler
2009-01-28 12:12                 ` Samuel Ortiz
2009-02-20  4:17                   ` Jason Andryuk
2009-02-20 19:49                     ` reinette chatre
2009-02-23  0:10                       ` Jason Andryuk
2009-02-23  4:37                         ` Jason Andryuk
2009-02-23 19:21                           ` reinette chatre
2009-02-23 22:28                           ` reinette chatre
2009-02-24  3:02                             ` Jason Andryuk
2009-02-24  0:15                           ` reinette chatre
2009-02-24  2:47                             ` Jason Andryuk
2009-03-02  3:37               ` Jason Andryuk
2009-03-04  4:32                 ` Jason Andryuk
2009-03-04 19:19                   ` reinette chatre
2009-03-04 19:47                     ` Jason Andryuk
2009-03-05  0:04                       ` reinette chatre
2009-03-05 23:50                         ` Jason Andryuk
2009-03-06  0:24                           ` reinette chatre
2009-03-06  4:12                             ` Jason Andryuk
2009-03-06  5:39                               ` reinette chatre
2009-03-10  1:40                                 ` Jason Andryuk
2009-03-10  3:32                                   ` Jason Andryuk
2009-03-10  5:04                                   ` reinette chatre
2009-03-10 13:10                                     ` Jason Andryuk
2009-03-10 18:22                                       ` Abhijeet Kolekar
2009-03-11  3:11                                         ` Jason Andryuk
2009-03-11  2:57                                       ` Jason Andryuk
2009-03-11  3:40                                     ` Jason Andryuk
2009-03-13  3:31                                       ` Jason Andryuk [this message]
2009-03-16 12:10                                         ` Jason Andryuk
2009-03-17  1:44                                           ` Jason Andryuk
2009-03-19  1:52                                             ` Jason Andryuk
2009-03-20  1:22                                               ` Jason Andryuk
2009-03-20 20:39                                                 ` Abhijeet Kolekar
2009-03-22 17:29                                                   ` Jason Andryuk
2009-03-23  0:37                                                     ` Jason Andryuk
2009-03-27 16:28                                                       ` reinette chatre
2009-03-31 22:22                                                       ` reinette chatre
2009-04-01  1:28                                                         ` Jason Andryuk
2009-04-21  1:41                                                         ` Jason Andryuk
2009-04-21 15:42                                                           ` reinette chatre
  -- strict thread matches above, loose matches on Subject: below --
2009-01-09  3:28 Deuce
2009-01-09 19:12 ` reinette chatre
2009-01-09 23:07   ` Deuce
2009-01-12 18:38     ` Samuel Ortiz
2009-01-13  3:12       ` Deuce
2009-01-13  4:37         ` Deuce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4d76b3b0903122031o7baea17ay5704df428ea2fced@mail.gmail.com \
    --to=jandryuk@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=samuel@sortiz.org \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.