From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jammy Huang Date: Mon, 25 Oct 2021 18:07:18 +0800 Subject: [PATCH v2] media: aspeed: add debugfs In-Reply-To: References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Dear Paul, Sure, no problem. On 2021/10/25 ?? 05:34, Paul Menzel wrote: > Dear Jammy, > > > On 29.09.21 11:00, Jammy Huang wrote: >> To show video real-time information as below: > Please list the path for that file containing the information below. > >> Caputre: > Capture > >> Signal : Unlock >> Width : 1920 >> Height : 1080 >> FRC : 30 >> >> Performance: >> Frame# : 0 >> Frame Duration : >> Now : 0 >> Min : 0 >> Max : 0 >> FPS(ms) : 0 > > Kind regards, > > Paul > > >> Change-Id: I483740c4df6db07a9261c18440472a0356512bb7 >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed-video.c | 101 ++++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 8b3939b8052d..c5c413844441 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -21,6 +21,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> #include >> #include >> @@ -203,6 +205,14 @@ struct aspeed_video_buffer { >> struct list_head link; >> }; >> >> +struct aspeed_video_perf { >> + ktime_t last_sample; >> + u32 totaltime; >> + u32 duration; >> + u32 duration_min; >> + u32 duration_max; >> +}; >> + >> #define to_aspeed_video_buffer(x) \ >> container_of((x), struct aspeed_video_buffer, vb) >> >> @@ -241,6 +251,8 @@ struct aspeed_video { >> unsigned int frame_left; >> unsigned int frame_right; >> unsigned int frame_top; >> + >> + struct aspeed_video_perf perf; >> }; >> >> #define to_aspeed_video(x) container_of((x), struct aspeed_video, v4l2_dev) >> @@ -444,6 +456,16 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> readl(video->base + reg)); >> } >> >> +static void update_perf(struct aspeed_video_perf *p) >> +{ >> + p->duration = >> + ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> + p->totaltime += p->duration; >> + >> + p->duration_max = max(p->duration, p->duration_max); >> + p->duration_min = min(p->duration, p->duration_min); >> +} >> + >> static int aspeed_video_start_frame(struct aspeed_video *video) >> { >> dma_addr_t addr; >> @@ -482,6 +504,8 @@ static int aspeed_video_start_frame(struct aspeed_video *video) >> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >> VE_INTERRUPT_COMP_COMPLETE); >> >> + video->perf.last_sample = ktime_get(); >> + >> aspeed_video_update(video, VE_SEQ_CTRL, 0, >> VE_SEQ_CTRL_TRIG_CAPTURE | VE_SEQ_CTRL_TRIG_COMP); >> >> @@ -600,6 +624,8 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> u32 frame_size = aspeed_video_read(video, >> VE_JPEG_COMP_SIZE_READ_BACK); >> >> + update_perf(&video->perf); >> + >> spin_lock(&video->lock); >> clear_bit(VIDEO_FRAME_INPRG, &video->flags); >> buf = list_first_entry_or_null(&video->buffers, >> @@ -760,6 +786,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >> det->width = MIN_WIDTH; >> det->height = MIN_HEIGHT; >> video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; >> + memset(&video->perf, 0, sizeof(video->perf)); >> >> do { >> if (tries) { >> @@ -1450,6 +1477,8 @@ static int aspeed_video_start_streaming(struct vb2_queue *q, >> struct aspeed_video *video = vb2_get_drv_priv(q); >> >> video->sequence = 0; >> + video->perf.duration_max = 0; >> + video->perf.duration_min = 0xffffffff; >> >> rc = aspeed_video_start_frame(video); >> if (rc) { >> @@ -1517,6 +1546,72 @@ static const struct vb2_ops aspeed_video_vb2_ops = { >> .buf_queue = aspeed_video_buf_queue, >> }; >> >> +#ifdef CONFIG_DEBUG_FS >> +static int aspeed_video_debugfs_show(struct seq_file *s, void *data) >> +{ >> + struct aspeed_video *v = s->private; >> + >> + seq_puts(s, "\n"); >> + >> + seq_printf(s, " %-20s:\t%s\n", "Signal", >> + v->v4l2_input_status ? "Unlock" : "Lock"); >> + seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); >> + seq_printf(s, " %-20s:\t%d\n", "Height", v->pix_fmt.height); >> + seq_printf(s, " %-20s:\t%d\n", "FRC", v->frame_rate); >> + >> + seq_puts(s, "\n"); >> + >> + seq_puts(s, "Performance:\n"); >> + seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); >> + seq_printf(s, " %-20s:\n", "Frame Duration"); >> + seq_printf(s, " %-18s:\t%d\n", "Now", v->perf.duration); >> + seq_printf(s, " %-18s:\t%d\n", "Min", v->perf.duration_min); >> + seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); >> + seq_printf(s, " %-20s:\t%d\n", "FPS(ms)", 1000/(v->perf.totaltime/v->sequence)); >> + >> + >> + return 0; >> +} >> + >> +int aspeed_video_proc_open(struct inode *inode, struct file *file) >> +{ >> + return single_open(file, aspeed_video_debugfs_show, inode->i_private); >> +} >> + >> +static struct file_operations aspeed_video_debugfs_ops = { >> + .owner = THIS_MODULE, >> + .open = aspeed_video_proc_open, >> + .read = seq_read, >> + .llseek = seq_lseek, >> + .release = single_release, >> +}; >> + >> +static struct dentry *debugfs_entry; >> + >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) >> +{ >> + debugfs_remove_recursive(debugfs_entry); >> + debugfs_entry = NULL; >> +} >> + >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, >> + video, >> + &aspeed_video_debugfs_ops); >> + if (!debugfs_entry) >> + aspeed_video_debugfs_remove(video); >> + >> + return debugfs_entry == NULL ? -EIO : 0; >> +} >> +#else >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + return 0; >> +} >> +#endif /* CONFIG_DEBUG_FS */ >> + >> static int aspeed_video_setup_video(struct aspeed_video *video) >> { >> const u64 mask = ~(BIT(V4L2_JPEG_CHROMA_SUBSAMPLING_444) | >> @@ -1708,6 +1803,10 @@ static int aspeed_video_probe(struct platform_device *pdev) >> return rc; >> } >> >> + rc = aspeed_video_debugfs_create(video); >> + if (rc) >> + dev_err(video->dev, "debugfs create failed\n"); >> + >> return 0; >> } >> >> @@ -1719,6 +1818,8 @@ static int aspeed_video_remove(struct platform_device *pdev) >> >> aspeed_video_off(video); >> >> + aspeed_video_debugfs_remove(video); >> + >> clk_unprepare(video->vclk); >> clk_unprepare(video->eclk); >> >> -- -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB841C433EF for ; Mon, 25 Oct 2021 10:08:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63CDC61029 for ; Mon, 25 Oct 2021 10:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63CDC61029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hd9dp6n0Dz2yQw for ; Mon, 25 Oct 2021 21:08:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=jammy_huang@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hd9cY4797z2yQK; Mon, 25 Oct 2021 21:07:41 +1100 (AEDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 19P9j0dD003000; Mon, 25 Oct 2021 17:45:00 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Oct 2021 18:07:18 +0800 Message-ID: Date: Mon, 25 Oct 2021 18:07:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] media: aspeed: add debugfs Content-Language: en-US To: Paul Menzel References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 19P9j0dD003000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW , "linux-aspeed@lists.ozlabs.org" , "andrew@aj.id.au" , "openbmc@lists.ozlabs.org" , "eajames@linux.ibm.com" , "linux-kernel@vger.kernel.org" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Dear Paul, Sure, no problem. On 2021/10/25 下午 05:34, Paul Menzel wrote: > Dear Jammy, > > > On 29.09.21 11:00, Jammy Huang wrote: >> To show video real-time information as below: > Please list the path for that file containing the information below. > >> Caputre: > Capture > >> Signal : Unlock >> Width : 1920 >> Height : 1080 >> FRC : 30 >> >> Performance: >> Frame# : 0 >> Frame Duration : >> Now : 0 >> Min : 0 >> Max : 0 >> FPS(ms) : 0 > > Kind regards, > > Paul > > >> Change-Id: I483740c4df6db07a9261c18440472a0356512bb7 >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed-video.c | 101 ++++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 8b3939b8052d..c5c413844441 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -21,6 +21,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> #include >> #include >> @@ -203,6 +205,14 @@ struct aspeed_video_buffer { >> struct list_head link; >> }; >> >> +struct aspeed_video_perf { >> + ktime_t last_sample; >> + u32 totaltime; >> + u32 duration; >> + u32 duration_min; >> + u32 duration_max; >> +}; >> + >> #define to_aspeed_video_buffer(x) \ >> container_of((x), struct aspeed_video_buffer, vb) >> >> @@ -241,6 +251,8 @@ struct aspeed_video { >> unsigned int frame_left; >> unsigned int frame_right; >> unsigned int frame_top; >> + >> + struct aspeed_video_perf perf; >> }; >> >> #define to_aspeed_video(x) container_of((x), struct aspeed_video, v4l2_dev) >> @@ -444,6 +456,16 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> readl(video->base + reg)); >> } >> >> +static void update_perf(struct aspeed_video_perf *p) >> +{ >> + p->duration = >> + ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> + p->totaltime += p->duration; >> + >> + p->duration_max = max(p->duration, p->duration_max); >> + p->duration_min = min(p->duration, p->duration_min); >> +} >> + >> static int aspeed_video_start_frame(struct aspeed_video *video) >> { >> dma_addr_t addr; >> @@ -482,6 +504,8 @@ static int aspeed_video_start_frame(struct aspeed_video *video) >> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >> VE_INTERRUPT_COMP_COMPLETE); >> >> + video->perf.last_sample = ktime_get(); >> + >> aspeed_video_update(video, VE_SEQ_CTRL, 0, >> VE_SEQ_CTRL_TRIG_CAPTURE | VE_SEQ_CTRL_TRIG_COMP); >> >> @@ -600,6 +624,8 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> u32 frame_size = aspeed_video_read(video, >> VE_JPEG_COMP_SIZE_READ_BACK); >> >> + update_perf(&video->perf); >> + >> spin_lock(&video->lock); >> clear_bit(VIDEO_FRAME_INPRG, &video->flags); >> buf = list_first_entry_or_null(&video->buffers, >> @@ -760,6 +786,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >> det->width = MIN_WIDTH; >> det->height = MIN_HEIGHT; >> video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; >> + memset(&video->perf, 0, sizeof(video->perf)); >> >> do { >> if (tries) { >> @@ -1450,6 +1477,8 @@ static int aspeed_video_start_streaming(struct vb2_queue *q, >> struct aspeed_video *video = vb2_get_drv_priv(q); >> >> video->sequence = 0; >> + video->perf.duration_max = 0; >> + video->perf.duration_min = 0xffffffff; >> >> rc = aspeed_video_start_frame(video); >> if (rc) { >> @@ -1517,6 +1546,72 @@ static const struct vb2_ops aspeed_video_vb2_ops = { >> .buf_queue = aspeed_video_buf_queue, >> }; >> >> +#ifdef CONFIG_DEBUG_FS >> +static int aspeed_video_debugfs_show(struct seq_file *s, void *data) >> +{ >> + struct aspeed_video *v = s->private; >> + >> + seq_puts(s, "\n"); >> + >> + seq_printf(s, " %-20s:\t%s\n", "Signal", >> + v->v4l2_input_status ? "Unlock" : "Lock"); >> + seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); >> + seq_printf(s, " %-20s:\t%d\n", "Height", v->pix_fmt.height); >> + seq_printf(s, " %-20s:\t%d\n", "FRC", v->frame_rate); >> + >> + seq_puts(s, "\n"); >> + >> + seq_puts(s, "Performance:\n"); >> + seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); >> + seq_printf(s, " %-20s:\n", "Frame Duration"); >> + seq_printf(s, " %-18s:\t%d\n", "Now", v->perf.duration); >> + seq_printf(s, " %-18s:\t%d\n", "Min", v->perf.duration_min); >> + seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); >> + seq_printf(s, " %-20s:\t%d\n", "FPS(ms)", 1000/(v->perf.totaltime/v->sequence)); >> + >> + >> + return 0; >> +} >> + >> +int aspeed_video_proc_open(struct inode *inode, struct file *file) >> +{ >> + return single_open(file, aspeed_video_debugfs_show, inode->i_private); >> +} >> + >> +static struct file_operations aspeed_video_debugfs_ops = { >> + .owner = THIS_MODULE, >> + .open = aspeed_video_proc_open, >> + .read = seq_read, >> + .llseek = seq_lseek, >> + .release = single_release, >> +}; >> + >> +static struct dentry *debugfs_entry; >> + >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) >> +{ >> + debugfs_remove_recursive(debugfs_entry); >> + debugfs_entry = NULL; >> +} >> + >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, >> + video, >> + &aspeed_video_debugfs_ops); >> + if (!debugfs_entry) >> + aspeed_video_debugfs_remove(video); >> + >> + return debugfs_entry == NULL ? -EIO : 0; >> +} >> +#else >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + return 0; >> +} >> +#endif /* CONFIG_DEBUG_FS */ >> + >> static int aspeed_video_setup_video(struct aspeed_video *video) >> { >> const u64 mask = ~(BIT(V4L2_JPEG_CHROMA_SUBSAMPLING_444) | >> @@ -1708,6 +1803,10 @@ static int aspeed_video_probe(struct platform_device *pdev) >> return rc; >> } >> >> + rc = aspeed_video_debugfs_create(video); >> + if (rc) >> + dev_err(video->dev, "debugfs create failed\n"); >> + >> return 0; >> } >> >> @@ -1719,6 +1818,8 @@ static int aspeed_video_remove(struct platform_device *pdev) >> >> aspeed_video_off(video); >> >> + aspeed_video_debugfs_remove(video); >> + >> clk_unprepare(video->vclk); >> clk_unprepare(video->eclk); >> >> -- -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43490C433F5 for ; Mon, 25 Oct 2021 10:09:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1394B60240 for ; Mon, 25 Oct 2021 10:09:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1394B60240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fgcpTH3lcnvNxAij1Q+DOjagHL3+ddCjE2qI0OhEk5U=; b=Uc59x2Z8a3FjAW aXAVVdwzStAw87iJBKjnQ9igMmWWF+JHuvXlHPURNe6emdvmecHspQkb8Mpi24VN4QWHs0cGldgoy GUJoPblyyheGk6Ub06SXlGoZABVCifGbCi+IPlMxpsstF38qcTUm94TNmfMA+g9/irptM/fFRzRPs HKdDbZMql7nB384UhadErkWOmVOuPzL1w62PP0aJUVlhsIderIlAyEurXssliIHYhMnLM0Udm3uoW CdOL9Pi/B/n7ZGHN/3UO4PrwVlCB0iPcTGBbjUvHkHoqYn9tbVHYWM37tJmEPO9OacBmP1kCFBx66 MSZQpW3fN6ZaHx7ZN89g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mewtG-00G3Ex-D6; Mon, 25 Oct 2021 10:07:38 +0000 Received: from twspam01.aspeedtech.com ([211.20.114.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mewtC-00G3Eb-97 for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 10:07:36 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 19P9j0dD003000; Mon, 25 Oct 2021 17:45:00 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Oct 2021 18:07:18 +0800 Message-ID: Date: Mon, 25 Oct 2021 18:07:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] media: aspeed: add debugfs Content-Language: en-US To: Paul Menzel CC: BMC-SW , "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 19P9j0dD003000 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_030734_582387_179F9ABD X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RGVhciBQYXVsLAoKU3VyZSwgbm8gcHJvYmxlbS4KCk9uIDIwMjEvMTAvMjUg5LiL5Y2IIDA1OjM0 LCBQYXVsIE1lbnplbCB3cm90ZToKPiBEZWFyIEphbW15LAo+Cj4KPiBPbiAyOS4wOS4yMSAxMTow MCwgSmFtbXkgSHVhbmcgd3JvdGU6Cj4+IFRvIHNob3cgdmlkZW8gcmVhbC10aW1lIGluZm9ybWF0 aW9uIGFzIGJlbG93Ogo+IFBsZWFzZSBsaXN0IHRoZSBwYXRoIGZvciB0aGF0IGZpbGUgY29udGFp bmluZyB0aGUgaW5mb3JtYXRpb24gYmVsb3cuCj4KPj4gQ2FwdXRyZToKPiBDYXB0dXJlCj4KPj4g ICAgIFNpZ25hbCAgICAgICAgICAgICAgOiBVbmxvY2sKPj4gICAgIFdpZHRoICAgICAgICAgICAg ICAgOiAxOTIwCj4+ICAgICBIZWlnaHQgICAgICAgICAgICAgIDogMTA4MAo+PiAgICAgRlJDICAg ICAgICAgICAgICAgICA6IDMwCj4+Cj4+IFBlcmZvcm1hbmNlOgo+PiAgICAgRnJhbWUjICAgICAg ICAgICAgICA6IDAKPj4gICAgIEZyYW1lIER1cmF0aW9uICAgICAgOgo+PiAgICAgICBOb3cgICAg ICAgICAgICAgICA6IDAKPj4gICAgICAgTWluICAgICAgICAgICAgICAgOiAwCj4+ICAgICAgIE1h eCAgICAgICAgICAgICAgIDogMAo+PiAgICAgRlBTKG1zKSAgICAgICAgICAgICA6IDAKPgo+IEtp bmQgcmVnYXJkcywKPgo+IFBhdWwKPgo+Cj4+IENoYW5nZS1JZDogSTQ4Mzc0MGM0ZGY2ZGIwN2E5 MjYxYzE4NDQwNDcyYTAzNTY1MTJiYjcKPj4gU2lnbmVkLW9mZi1ieTogSmFtbXkgSHVhbmcgPGph bW15X2h1YW5nQGFzcGVlZHRlY2guY29tPgo+PiAtLS0KPj4gICAgZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9hc3BlZWQtdmlkZW8uYyB8IDEwMSArKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAg ICAxIGZpbGUgY2hhbmdlZCwgMTAxIGluc2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbWVkaWEvcGxhdGZvcm0vYXNwZWVkLXZpZGVvLmMgYi9kcml2ZXJzL21lZGlhL3BsYXRm b3JtL2FzcGVlZC12aWRlby5jCj4+IGluZGV4IDhiMzkzOWI4MDUyZC4uYzVjNDEzODQ0NDQxIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL2FzcGVlZC12aWRlby5jCj4+ICsr KyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXNwZWVkLXZpZGVvLmMKPj4gQEAgLTIxLDYgKzIx LDggQEAKPj4gICAgI2luY2x1ZGUgPGxpbnV4L3ZpZGVvZGV2Mi5oPgo+PiAgICAjaW5jbHVkZSA8 bGludXgvd2FpdC5oPgo+PiAgICAjaW5jbHVkZSA8bGludXgvd29ya3F1ZXVlLmg+Cj4+ICsjaW5j bHVkZSA8bGludXgvZGVidWdmcy5oPgo+PiArI2luY2x1ZGUgPGxpbnV4L2t0aW1lLmg+Cj4+ICAg ICNpbmNsdWRlIDxtZWRpYS92NGwyLWN0cmxzLmg+Cj4+ICAgICNpbmNsdWRlIDxtZWRpYS92NGwy LWRldi5oPgo+PiAgICAjaW5jbHVkZSA8bWVkaWEvdjRsMi1kZXZpY2UuaD4KPj4gQEAgLTIwMyw2 ICsyMDUsMTQgQEAgc3RydWN0IGFzcGVlZF92aWRlb19idWZmZXIgewo+PiAgICAJc3RydWN0IGxp c3RfaGVhZCBsaW5rOwo+PiAgICB9Owo+PiAgICAKPj4gK3N0cnVjdCBhc3BlZWRfdmlkZW9fcGVy ZiB7Cj4+ICsJa3RpbWVfdCBsYXN0X3NhbXBsZTsKPj4gKwl1MzIgdG90YWx0aW1lOwo+PiArCXUz MiBkdXJhdGlvbjsKPj4gKwl1MzIgZHVyYXRpb25fbWluOwo+PiArCXUzMiBkdXJhdGlvbl9tYXg7 Cj4+ICt9Owo+PiArCj4+ICAgICNkZWZpbmUgdG9fYXNwZWVkX3ZpZGVvX2J1ZmZlcih4KSBcCj4+ ICAgIAljb250YWluZXJfb2YoKHgpLCBzdHJ1Y3QgYXNwZWVkX3ZpZGVvX2J1ZmZlciwgdmIpCj4+ ICAgIAo+PiBAQCAtMjQxLDYgKzI1MSw4IEBAIHN0cnVjdCBhc3BlZWRfdmlkZW8gewo+PiAgICAJ dW5zaWduZWQgaW50IGZyYW1lX2xlZnQ7Cj4+ICAgIAl1bnNpZ25lZCBpbnQgZnJhbWVfcmlnaHQ7 Cj4+ICAgIAl1bnNpZ25lZCBpbnQgZnJhbWVfdG9wOwo+PiArCj4+ICsJc3RydWN0IGFzcGVlZF92 aWRlb19wZXJmIHBlcmY7Cj4+ICAgIH07Cj4+ICAgIAo+PiAgICAjZGVmaW5lIHRvX2FzcGVlZF92 aWRlbyh4KSBjb250YWluZXJfb2YoKHgpLCBzdHJ1Y3QgYXNwZWVkX3ZpZGVvLCB2NGwyX2RldikK Pj4gQEAgLTQ0NCw2ICs0NTYsMTYgQEAgc3RhdGljIHZvaWQgYXNwZWVkX3ZpZGVvX3dyaXRlKHN0 cnVjdCBhc3BlZWRfdmlkZW8gKnZpZGVvLCB1MzIgcmVnLCB1MzIgdmFsKQo+PiAgICAJCXJlYWRs KHZpZGVvLT5iYXNlICsgcmVnKSk7Cj4+ICAgIH0KPj4gICAgCj4+ICtzdGF0aWMgdm9pZCB1cGRh dGVfcGVyZihzdHJ1Y3QgYXNwZWVkX3ZpZGVvX3BlcmYgKnApCj4+ICt7Cj4+ICsJcC0+ZHVyYXRp b24gPQo+PiArCQlrdGltZV90b19tcyhrdGltZV9zdWIoa3RpbWVfZ2V0KCksICBwLT5sYXN0X3Nh bXBsZSkpOwo+PiArCXAtPnRvdGFsdGltZSArPSBwLT5kdXJhdGlvbjsKPj4gKwo+PiArCXAtPmR1 cmF0aW9uX21heCA9IG1heChwLT5kdXJhdGlvbiwgcC0+ZHVyYXRpb25fbWF4KTsKPj4gKwlwLT5k dXJhdGlvbl9taW4gPSBtaW4ocC0+ZHVyYXRpb24sIHAtPmR1cmF0aW9uX21pbik7Cj4+ICt9Cj4+ ICsKPj4gICAgc3RhdGljIGludCBhc3BlZWRfdmlkZW9fc3RhcnRfZnJhbWUoc3RydWN0IGFzcGVl ZF92aWRlbyAqdmlkZW8pCj4+ICAgIHsKPj4gICAgCWRtYV9hZGRyX3QgYWRkcjsKPj4gQEAgLTQ4 Miw2ICs1MDQsOCBAQCBzdGF0aWMgaW50IGFzcGVlZF92aWRlb19zdGFydF9mcmFtZShzdHJ1Y3Qg YXNwZWVkX3ZpZGVvICp2aWRlbykKPj4gICAgCWFzcGVlZF92aWRlb191cGRhdGUodmlkZW8sIFZF X0lOVEVSUlVQVF9DVFJMLCAwLAo+PiAgICAJCQkgICAgVkVfSU5URVJSVVBUX0NPTVBfQ09NUExF VEUpOwo+PiAgICAKPj4gKwl2aWRlby0+cGVyZi5sYXN0X3NhbXBsZSA9IGt0aW1lX2dldCgpOwo+ PiArCj4+ICAgIAlhc3BlZWRfdmlkZW9fdXBkYXRlKHZpZGVvLCBWRV9TRVFfQ1RSTCwgMCwKPj4g ICAgCQkJICAgIFZFX1NFUV9DVFJMX1RSSUdfQ0FQVFVSRSB8IFZFX1NFUV9DVFJMX1RSSUdfQ09N UCk7Cj4+ICAgIAo+PiBAQCAtNjAwLDYgKzYyNCw4IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBhc3Bl ZWRfdmlkZW9faXJxKGludCBpcnEsIHZvaWQgKmFyZykKPj4gICAgCQl1MzIgZnJhbWVfc2l6ZSA9 IGFzcGVlZF92aWRlb19yZWFkKHZpZGVvLAo+PiAgICAJCQkJCQkgICBWRV9KUEVHX0NPTVBfU0la RV9SRUFEX0JBQ0spOwo+PiAgICAKPj4gKwkJdXBkYXRlX3BlcmYoJnZpZGVvLT5wZXJmKTsKPj4g Kwo+PiAgICAJCXNwaW5fbG9jaygmdmlkZW8tPmxvY2spOwo+PiAgICAJCWNsZWFyX2JpdChWSURF T19GUkFNRV9JTlBSRywgJnZpZGVvLT5mbGFncyk7Cj4+ICAgIAkJYnVmID0gbGlzdF9maXJzdF9l bnRyeV9vcl9udWxsKCZ2aWRlby0+YnVmZmVycywKPj4gQEAgLTc2MCw2ICs3ODYsNyBAQCBzdGF0 aWMgdm9pZCBhc3BlZWRfdmlkZW9fZ2V0X3Jlc29sdXRpb24oc3RydWN0IGFzcGVlZF92aWRlbyAq dmlkZW8pCj4+ICAgIAlkZXQtPndpZHRoID0gTUlOX1dJRFRIOwo+PiAgICAJZGV0LT5oZWlnaHQg PSBNSU5fSEVJR0hUOwo+PiAgICAJdmlkZW8tPnY0bDJfaW5wdXRfc3RhdHVzID0gVjRMMl9JTl9T VF9OT19TSUdOQUw7Cj4+ICsJbWVtc2V0KCZ2aWRlby0+cGVyZiwgMCwgc2l6ZW9mKHZpZGVvLT5w ZXJmKSk7Cj4+ICAgIAo+PiAgICAJZG8gewo+PiAgICAJCWlmICh0cmllcykgewo+PiBAQCAtMTQ1 MCw2ICsxNDc3LDggQEAgc3RhdGljIGludCBhc3BlZWRfdmlkZW9fc3RhcnRfc3RyZWFtaW5nKHN0 cnVjdCB2YjJfcXVldWUgKnEsCj4+ICAgIAlzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2aWRlbyA9IHZi Ml9nZXRfZHJ2X3ByaXYocSk7Cj4+ICAgIAo+PiAgICAJdmlkZW8tPnNlcXVlbmNlID0gMDsKPj4g Kwl2aWRlby0+cGVyZi5kdXJhdGlvbl9tYXggPSAwOwo+PiArCXZpZGVvLT5wZXJmLmR1cmF0aW9u X21pbiA9IDB4ZmZmZmZmZmY7Cj4+ICAgIAo+PiAgICAJcmMgPSBhc3BlZWRfdmlkZW9fc3RhcnRf ZnJhbWUodmlkZW8pOwo+PiAgICAJaWYgKHJjKSB7Cj4+IEBAIC0xNTE3LDYgKzE1NDYsNzIgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCB2YjJfb3BzIGFzcGVlZF92aWRlb192YjJfb3BzID0gewo+PiAg ICAJLmJ1Zl9xdWV1ZSA9ICBhc3BlZWRfdmlkZW9fYnVmX3F1ZXVlLAo+PiAgICB9Owo+PiAgICAK Pj4gKyNpZmRlZiBDT05GSUdfREVCVUdfRlMKPj4gK3N0YXRpYyBpbnQgYXNwZWVkX3ZpZGVvX2Rl YnVnZnNfc2hvdyhzdHJ1Y3Qgc2VxX2ZpbGUgKnMsIHZvaWQgKmRhdGEpCj4+ICt7Cj4+ICsJc3Ry dWN0IGFzcGVlZF92aWRlbyAqdiA9IHMtPnByaXZhdGU7Cj4+ICsKPj4gKwlzZXFfcHV0cyhzLCAi XG4iKTsKPj4gKwo+PiArCXNlcV9wcmludGYocywgIiAgJS0yMHM6XHQlc1xuIiwgIlNpZ25hbCIs Cj4+ICsJCSAgIHYtPnY0bDJfaW5wdXRfc3RhdHVzID8gIlVubG9jayIgOiAiTG9jayIpOwo+PiAr CXNlcV9wcmludGYocywgIiAgJS0yMHM6XHQlZFxuIiwgIldpZHRoIiwgdi0+cGl4X2ZtdC53aWR0 aCk7Cj4+ICsJc2VxX3ByaW50ZihzLCAiICAlLTIwczpcdCVkXG4iLCAiSGVpZ2h0Iiwgdi0+cGl4 X2ZtdC5oZWlnaHQpOwo+PiArCXNlcV9wcmludGYocywgIiAgJS0yMHM6XHQlZFxuIiwgIkZSQyIs IHYtPmZyYW1lX3JhdGUpOwo+PiArCj4+ICsJc2VxX3B1dHMocywgIlxuIik7Cj4+ICsKPj4gKwlz ZXFfcHV0cyhzLCAiUGVyZm9ybWFuY2U6XG4iKTsKPj4gKwlzZXFfcHJpbnRmKHMsICIgICUtMjBz Olx0JWRcbiIsICJGcmFtZSMiLCB2LT5zZXF1ZW5jZSk7Cj4+ICsJc2VxX3ByaW50ZihzLCAiICAl LTIwczpcbiIsICJGcmFtZSBEdXJhdGlvbiIpOwo+PiArCXNlcV9wcmludGYocywgIiAgICAlLTE4 czpcdCVkXG4iLCAiTm93Iiwgdi0+cGVyZi5kdXJhdGlvbik7Cj4+ICsJc2VxX3ByaW50ZihzLCAi ICAgICUtMThzOlx0JWRcbiIsICJNaW4iLCB2LT5wZXJmLmR1cmF0aW9uX21pbik7Cj4+ICsJc2Vx X3ByaW50ZihzLCAiICAgICUtMThzOlx0JWRcbiIsICJNYXgiLCB2LT5wZXJmLmR1cmF0aW9uX21h eCk7Cj4+ICsJc2VxX3ByaW50ZihzLCAiICAlLTIwczpcdCVkXG4iLCAiRlBTKG1zKSIsIDEwMDAv KHYtPnBlcmYudG90YWx0aW1lL3YtPnNlcXVlbmNlKSk7Cj4+ICsKPj4gKwo+PiArCXJldHVybiAw Owo+PiArfQo+PiArCj4+ICtpbnQgYXNwZWVkX3ZpZGVvX3Byb2Nfb3BlbihzdHJ1Y3QgaW5vZGUg Kmlub2RlLCBzdHJ1Y3QgZmlsZSAqZmlsZSkKPj4gK3sKPj4gKwlyZXR1cm4gc2luZ2xlX29wZW4o ZmlsZSwgYXNwZWVkX3ZpZGVvX2RlYnVnZnNfc2hvdywgaW5vZGUtPmlfcHJpdmF0ZSk7Cj4+ICt9 Cj4+ICsKPj4gK3N0YXRpYyBzdHJ1Y3QgZmlsZV9vcGVyYXRpb25zIGFzcGVlZF92aWRlb19kZWJ1 Z2ZzX29wcyA9IHsKPj4gKwkub3duZXIgICA9IFRISVNfTU9EVUxFLAo+PiArCS5vcGVuICAgID0g YXNwZWVkX3ZpZGVvX3Byb2Nfb3BlbiwKPj4gKwkucmVhZCAgICA9IHNlcV9yZWFkLAo+PiArCS5s bHNlZWsgID0gc2VxX2xzZWVrLAo+PiArCS5yZWxlYXNlID0gc2luZ2xlX3JlbGVhc2UsCj4+ICt9 Owo+PiArCj4+ICtzdGF0aWMgc3RydWN0IGRlbnRyeSAqZGVidWdmc19lbnRyeTsKPj4gKwo+PiAr c3RhdGljIHZvaWQgYXNwZWVkX3ZpZGVvX2RlYnVnZnNfcmVtb3ZlKHN0cnVjdCBhc3BlZWRfdmlk ZW8gKnZpZGVvKQo+PiArewo+PiArCWRlYnVnZnNfcmVtb3ZlX3JlY3Vyc2l2ZShkZWJ1Z2ZzX2Vu dHJ5KTsKPj4gKwlkZWJ1Z2ZzX2VudHJ5ID0gTlVMTDsKPj4gK30KPj4gKwo+PiArc3RhdGljIGlu dCBhc3BlZWRfdmlkZW9fZGVidWdmc19jcmVhdGUoc3RydWN0IGFzcGVlZF92aWRlbyAqdmlkZW8p Cj4+ICt7Cj4+ICsJZGVidWdmc19lbnRyeSA9IGRlYnVnZnNfY3JlYXRlX2ZpbGUoREVWSUNFX05B TUUsIDA0NDQsIE5VTEwsCj4+ICsJCQkJCQkgICB2aWRlbywKPj4gKwkJCQkJCSAgICZhc3BlZWRf dmlkZW9fZGVidWdmc19vcHMpOwo+PiArCWlmICghZGVidWdmc19lbnRyeSkKPj4gKwkJYXNwZWVk X3ZpZGVvX2RlYnVnZnNfcmVtb3ZlKHZpZGVvKTsKPj4gKwo+PiArCXJldHVybiBkZWJ1Z2ZzX2Vu dHJ5ID09IE5VTEwgPyAtRUlPIDogMDsKPj4gK30KPj4gKyNlbHNlCj4+ICtzdGF0aWMgdm9pZCBh c3BlZWRfdmlkZW9fZGVidWdmc19yZW1vdmUoc3RydWN0IGFzcGVlZF92aWRlbyAqdmlkZW8pIHsg fQo+PiArc3RhdGljIGludCBhc3BlZWRfdmlkZW9fZGVidWdmc19jcmVhdGUoc3RydWN0IGFzcGVl ZF92aWRlbyAqdmlkZW8pCj4+ICt7Cj4+ICsJcmV0dXJuIDA7Cj4+ICt9Cj4+ICsjZW5kaWYgLyog Q09ORklHX0RFQlVHX0ZTICovCj4+ICsKPj4gICAgc3RhdGljIGludCBhc3BlZWRfdmlkZW9fc2V0 dXBfdmlkZW8oc3RydWN0IGFzcGVlZF92aWRlbyAqdmlkZW8pCj4+ICAgIHsKPj4gICAgCWNvbnN0 IHU2NCBtYXNrID0gfihCSVQoVjRMMl9KUEVHX0NIUk9NQV9TVUJTQU1QTElOR180NDQpIHwKPj4g QEAgLTE3MDgsNiArMTgwMywxMCBAQCBzdGF0aWMgaW50IGFzcGVlZF92aWRlb19wcm9iZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+PiAgICAJCXJldHVybiByYzsKPj4gICAgCX0KPj4g ICAgCj4+ICsJcmMgPSBhc3BlZWRfdmlkZW9fZGVidWdmc19jcmVhdGUodmlkZW8pOwo+PiArCWlm IChyYykKPj4gKwkJZGV2X2Vycih2aWRlby0+ZGV2LCAiZGVidWdmcyBjcmVhdGUgZmFpbGVkXG4i KTsKPj4gKwo+PiAgICAJcmV0dXJuIDA7Cj4+ICAgIH0KPj4gICAgCj4+IEBAIC0xNzE5LDYgKzE4 MTgsOCBAQCBzdGF0aWMgaW50IGFzcGVlZF92aWRlb19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPj4gICAgCj4+ICAgIAlhc3BlZWRfdmlkZW9fb2ZmKHZpZGVvKTsKPj4gICAg Cj4+ICsJYXNwZWVkX3ZpZGVvX2RlYnVnZnNfcmVtb3ZlKHZpZGVvKTsKPj4gKwo+PiAgICAJY2xr X3VucHJlcGFyZSh2aWRlby0+dmNsayk7Cj4+ICAgIAljbGtfdW5wcmVwYXJlKHZpZGVvLT5lY2xr KTsKPj4gICAgCj4+Ci0tIAotLQpCZXN0IFJlZ2FyZHMKSmFtbXkKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E3AAC433F5 for ; Mon, 25 Oct 2021 10:07:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05BA560C40 for ; Mon, 25 Oct 2021 10:07:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232710AbhJYKJp (ORCPT ); Mon, 25 Oct 2021 06:09:45 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:54513 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbhJYKJo (ORCPT ); Mon, 25 Oct 2021 06:09:44 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 19P9j0dD003000; Mon, 25 Oct 2021 17:45:00 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Oct 2021 18:07:18 +0800 Message-ID: Date: Mon, 25 Oct 2021 18:07:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] media: aspeed: add debugfs Content-Language: en-US To: Paul Menzel CC: BMC-SW , "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 19P9j0dD003000 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Dear Paul, Sure, no problem. On 2021/10/25 下午 05:34, Paul Menzel wrote: > Dear Jammy, > > > On 29.09.21 11:00, Jammy Huang wrote: >> To show video real-time information as below: > Please list the path for that file containing the information below. > >> Caputre: > Capture > >> Signal : Unlock >> Width : 1920 >> Height : 1080 >> FRC : 30 >> >> Performance: >> Frame# : 0 >> Frame Duration : >> Now : 0 >> Min : 0 >> Max : 0 >> FPS(ms) : 0 > > Kind regards, > > Paul > > >> Change-Id: I483740c4df6db07a9261c18440472a0356512bb7 >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed-video.c | 101 ++++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 8b3939b8052d..c5c413844441 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -21,6 +21,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> #include >> #include >> @@ -203,6 +205,14 @@ struct aspeed_video_buffer { >> struct list_head link; >> }; >> >> +struct aspeed_video_perf { >> + ktime_t last_sample; >> + u32 totaltime; >> + u32 duration; >> + u32 duration_min; >> + u32 duration_max; >> +}; >> + >> #define to_aspeed_video_buffer(x) \ >> container_of((x), struct aspeed_video_buffer, vb) >> >> @@ -241,6 +251,8 @@ struct aspeed_video { >> unsigned int frame_left; >> unsigned int frame_right; >> unsigned int frame_top; >> + >> + struct aspeed_video_perf perf; >> }; >> >> #define to_aspeed_video(x) container_of((x), struct aspeed_video, v4l2_dev) >> @@ -444,6 +456,16 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> readl(video->base + reg)); >> } >> >> +static void update_perf(struct aspeed_video_perf *p) >> +{ >> + p->duration = >> + ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> + p->totaltime += p->duration; >> + >> + p->duration_max = max(p->duration, p->duration_max); >> + p->duration_min = min(p->duration, p->duration_min); >> +} >> + >> static int aspeed_video_start_frame(struct aspeed_video *video) >> { >> dma_addr_t addr; >> @@ -482,6 +504,8 @@ static int aspeed_video_start_frame(struct aspeed_video *video) >> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >> VE_INTERRUPT_COMP_COMPLETE); >> >> + video->perf.last_sample = ktime_get(); >> + >> aspeed_video_update(video, VE_SEQ_CTRL, 0, >> VE_SEQ_CTRL_TRIG_CAPTURE | VE_SEQ_CTRL_TRIG_COMP); >> >> @@ -600,6 +624,8 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> u32 frame_size = aspeed_video_read(video, >> VE_JPEG_COMP_SIZE_READ_BACK); >> >> + update_perf(&video->perf); >> + >> spin_lock(&video->lock); >> clear_bit(VIDEO_FRAME_INPRG, &video->flags); >> buf = list_first_entry_or_null(&video->buffers, >> @@ -760,6 +786,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >> det->width = MIN_WIDTH; >> det->height = MIN_HEIGHT; >> video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; >> + memset(&video->perf, 0, sizeof(video->perf)); >> >> do { >> if (tries) { >> @@ -1450,6 +1477,8 @@ static int aspeed_video_start_streaming(struct vb2_queue *q, >> struct aspeed_video *video = vb2_get_drv_priv(q); >> >> video->sequence = 0; >> + video->perf.duration_max = 0; >> + video->perf.duration_min = 0xffffffff; >> >> rc = aspeed_video_start_frame(video); >> if (rc) { >> @@ -1517,6 +1546,72 @@ static const struct vb2_ops aspeed_video_vb2_ops = { >> .buf_queue = aspeed_video_buf_queue, >> }; >> >> +#ifdef CONFIG_DEBUG_FS >> +static int aspeed_video_debugfs_show(struct seq_file *s, void *data) >> +{ >> + struct aspeed_video *v = s->private; >> + >> + seq_puts(s, "\n"); >> + >> + seq_printf(s, " %-20s:\t%s\n", "Signal", >> + v->v4l2_input_status ? "Unlock" : "Lock"); >> + seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); >> + seq_printf(s, " %-20s:\t%d\n", "Height", v->pix_fmt.height); >> + seq_printf(s, " %-20s:\t%d\n", "FRC", v->frame_rate); >> + >> + seq_puts(s, "\n"); >> + >> + seq_puts(s, "Performance:\n"); >> + seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); >> + seq_printf(s, " %-20s:\n", "Frame Duration"); >> + seq_printf(s, " %-18s:\t%d\n", "Now", v->perf.duration); >> + seq_printf(s, " %-18s:\t%d\n", "Min", v->perf.duration_min); >> + seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); >> + seq_printf(s, " %-20s:\t%d\n", "FPS(ms)", 1000/(v->perf.totaltime/v->sequence)); >> + >> + >> + return 0; >> +} >> + >> +int aspeed_video_proc_open(struct inode *inode, struct file *file) >> +{ >> + return single_open(file, aspeed_video_debugfs_show, inode->i_private); >> +} >> + >> +static struct file_operations aspeed_video_debugfs_ops = { >> + .owner = THIS_MODULE, >> + .open = aspeed_video_proc_open, >> + .read = seq_read, >> + .llseek = seq_lseek, >> + .release = single_release, >> +}; >> + >> +static struct dentry *debugfs_entry; >> + >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) >> +{ >> + debugfs_remove_recursive(debugfs_entry); >> + debugfs_entry = NULL; >> +} >> + >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, >> + video, >> + &aspeed_video_debugfs_ops); >> + if (!debugfs_entry) >> + aspeed_video_debugfs_remove(video); >> + >> + return debugfs_entry == NULL ? -EIO : 0; >> +} >> +#else >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + return 0; >> +} >> +#endif /* CONFIG_DEBUG_FS */ >> + >> static int aspeed_video_setup_video(struct aspeed_video *video) >> { >> const u64 mask = ~(BIT(V4L2_JPEG_CHROMA_SUBSAMPLING_444) | >> @@ -1708,6 +1803,10 @@ static int aspeed_video_probe(struct platform_device *pdev) >> return rc; >> } >> >> + rc = aspeed_video_debugfs_create(video); >> + if (rc) >> + dev_err(video->dev, "debugfs create failed\n"); >> + >> return 0; >> } >> >> @@ -1719,6 +1818,8 @@ static int aspeed_video_remove(struct platform_device *pdev) >> >> aspeed_video_off(video); >> >> + aspeed_video_debugfs_remove(video); >> + >> clk_unprepare(video->vclk); >> clk_unprepare(video->eclk); >> >> -- -- Best Regards Jammy