From: Jens Axboe <axboe@kernel.dk>
To: Michael Ellerman <mpe@ellerman.id.au>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
Brian J King <bjking1@us.ibm.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage
Date: Tue, 1 Aug 2017 09:26:09 -0600 [thread overview]
Message-ID: <c4fb0293-d0cb-ebff-cddf-a4e301826fbc@kernel.dk> (raw)
In-Reply-To: <877eynu69j.fsf@concordia.ellerman.id.au>
On 08/01/2017 12:55 AM, Michael Ellerman wrote:
> Jens Axboe <axboe@kernel.dk> writes:
> ...
>>
>> Can you try the below fix? Should be more palatable than the previous
>> one. Brian, maybe you can take a look at the IRQ issue mentioned above?
>
> Given the patch from Brian fixed the lockdep warning, do you still want
> me to try and test this one?
Nope, we don't have to do that. I'd much rather just add a WARN_ON()
or similar to make sure we catch buggy users earlier. scsi_run_queue()
needs a
WARN_ON(in_interrupt());
but it might be better to put that in __blk_mq_run_hw_queue().
--
Jens Axboe
prev parent reply other threads:[~2017-08-01 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 5:10 blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage Michael Ellerman
2017-07-27 14:02 ` Jens Axboe
2017-07-27 14:47 ` Bart Van Assche
2017-07-27 14:47 ` Bart Van Assche
2017-07-27 16:26 ` Jens Axboe
2017-07-28 6:19 ` Michael Ellerman
2017-07-28 14:25 ` Jens Axboe
2017-07-28 15:13 ` Bart Van Assche
2017-07-28 15:13 ` Bart Van Assche
2017-07-28 15:18 ` Jens Axboe
2017-07-28 15:17 ` Brian J King
2017-07-28 20:41 ` Brian King
2017-07-31 12:03 ` Michael Ellerman
2017-08-01 6:54 ` Michael Ellerman
2017-08-01 15:21 ` [PATCH] ipr: Fix scsi-mq lockdep issue Brian King
2017-08-07 17:41 ` Martin K. Petersen
2017-08-07 17:41 ` Martin K. Petersen
2017-08-01 6:55 ` blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage Michael Ellerman
2017-08-01 15:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4fb0293-d0cb-ebff-cddf-a4e301826fbc@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@wdc.com \
--cc=bjking1@us.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.