From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 636FD3D45F7 for ; Tue, 11 Aug 2026 15:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786463967; cv=none; b=RXciuELWqTCg6gSzydxcBnubPckqFdmkRUY1zQnDBdU3W3qX3MsTxN9x+Z78G6dKiNyHZDnuO3HuHBB6UWUAeEPKN8XlOXZRbAvJONt5fmxROOOUC6ckpmmjWN0U5JQDkiZYH46vtjymJexPRl8KHiZga5MMehMJ57i0XLoBAAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786463967; c=relaxed/simple; bh=c7XWVPIrtzDy3yNpuL8Ga1a+R1NHWYdnDUUqTNp9KI4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hh3WK5oB107wcR4S06hzUlGdPYzl8R4YO4rWzbUCXROdlG35hubDZzKo/UWLr4N5S4fei/5OhX1H/Ppt9hDTpvPQ9lXXZ/nL3wnL8/76/kgheWJorofE11gzhp7gFj6rljNnVa7G5r0so98J8LzVDTNXUbycXuv9SqvFrvKSQ4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KO/eO+pz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fYIbw8+i; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KO/eO+pz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fYIbw8+i" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67BDWh2t809908 for ; Tue, 11 Aug 2026 15:59:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y6wOPYYtmKIqj95qma0W/5EiM5dJQOCqAMNjkBDRMOY=; b=KO/eO+pznKNcOc/3 s0DGg944VeJxlqt1hAr+TmK55GzAMYD7J5UgiAMkVa8oa9IB1BIKyQQGc61jZmwp qIxl1sy5aAKffdGq9/I0sME1/E52iUPRgMCkYiIOeZs/QaRoj+mb27nP5Sr6mPUJ zty1I0p4g8Sbce7uGcLG3LINng14DYlp1xkb998HszaDwBi13F7xBQlsU5r7x6OG nmO+ATf/7OfgqfGQOGAFB4tVwt2MixVCVZRgUhG7S3Eu6poD9SB0awPZ8QUxjcrP 0Vgnhiljb2GyajF2syApcRw7uvaOWajhB6WRl6SC09KpLih9zRdwimYayhfPPAoc UFOd0g== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g049dgs8w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 11 Aug 2026 15:59:21 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cce14a21faso519295ad.0 for ; Tue, 11 Aug 2026 08:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786463961; x=1787068761; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=y6wOPYYtmKIqj95qma0W/5EiM5dJQOCqAMNjkBDRMOY=; b=fYIbw8+im9CuxNQgYOjTuw90SI8C047hZFvsi1rzF2LvLXaOWM6WSCocAoWHsDkzCn P71LJy/CJoy0kiSNx7RjZMwqnsxGXT354eUlM8XrKjBpekFg1/stfCLiqAdUzhM9oyEC e8btrAhNdsEIWWBC2ShlRxgt8oGV83UcON7VP9ywOBnxIpUHVhDuFzq9uayC+xbmdp9m P5b3ok42ZacuTlj4ehjEG4OGBbEqMTAPuSr9zabUBj8+SbOyeRE1BU8pfTb2s/jpWUJq iLfdQOyXE5AdXtajQFQ8iRmI7vnQuKErWTrkHe2lX6EObVqUmJtWk+QqSlr2ML11IZ/b xb6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786463961; x=1787068761; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y6wOPYYtmKIqj95qma0W/5EiM5dJQOCqAMNjkBDRMOY=; b=Ff1ug7lYUPZwhOyq6PNGtU2aNCalH7hSY8IHRFKGC5yYLS6yBaj7lohWVmRZ6p7DGr AZcUkEjB3/tqSgNrtyF4Wc4MqGzjRbOWOBZ1EX9qQ+L3dzCodxtF8A2LzHPF5r1k+tmW L98rix9bEQSRJF/JiwnENo30Z2K1TIvvQmqiCuGd9AfY426UrL5t2pDS3sH/rshSCJi6 2H23fb4VI9WgxkFPVKubrvmorrvpiXwouDmqiSLuSgWIDihQX7FueBveSdCa5kbBy9Wn pT3meDZiQKFC4fj2DAIiKOCV2A+LyZqARXfFK2zW7MYUGkA0psKJ1kEFQhCTItQTSz7y HoGw== X-Forwarded-Encrypted: i=1; AHgh+RogatTAusqCAJKiNH7Piaq33HxlA+wnSDSf90VcE2uI8Iy+W7imfkegP+omjmBPwR9m9qAXc4Z2ckE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9KHRehDHAmI8kx+LyIzBcm1oy5QIW5hfC5N+niLUd+p94PjQw 42IMmJL/6OlixdwnuwvFKf20DLgAUmauDLr2pVPpR3JAdLCP937Zg7jxzHuB4jvrxQ6gpU5DxrF BKOAxJg/Jd3Iyz4XPCAm/+Y19AwS8ei6qLt71dtHJCcUciufjqUoeNpDH/hRUQFw= X-Gm-Gg: AR+sD10y8N/hfcphVMgxJ894uGlOqIWSPpeBELoxdSGUWeiZphQuSC4AVJTFHeD5sph OyUcfkgbTsgVxWvcgbFj8e7fjn4mMs29AuofpaWQA5Ws//Zskaa1Pz51NXkkicQf/LQzmNYq/IK +DxHruqQqOwp71mW2qsL4KtX48f6SzBaMDi+LURB1gp43Ftl2dS9gCNkPYGA1FsHpIs5sOb/BBs 9RKsUpdyItrstNPDhz5UKMhigSAmoqL1feww99L2k9y23vM3Ko3lCVIxoCfDnbQqYamc61g4jKa Vz/Sulxw6xIPedwSASP+3q6j82CWD9ATOzP4KXfJ+xrJmkZc0AFGtFFft5J73s3HOCq4XQP0WuD yU8fF5IaZLCXFBHWnqgFS2fvbL+tUl7cIt916YEap0gWb X-Received: by 2002:a17:902:d552:b0:2cf:41ba:96c2 with SMTP id d9443c01a7336-2d32e4ed90fmr6535355ad.12.1786463960757; Tue, 11 Aug 2026 08:59:20 -0700 (PDT) X-Received: by 2002:a17:902:d552:b0:2cf:41ba:96c2 with SMTP id d9443c01a7336-2d32e4ed90fmr6534945ad.12.1786463960205; Tue, 11 Aug 2026 08:59:20 -0700 (PDT) Received: from [192.168.1.9] ([122.164.84.216]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d3160ce674sm10523625ad.49.2026.08.11.08.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 08:59:19 -0700 (PDT) Message-ID: Date: Tue, 11 Aug 2026 21:29:13 +0530 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] i2c: qcom-geni: Add I2C frequency table for firmware-based SEs To: Mukesh Savaliya , Viken Dadhaniya , Andi Shyti , Manikanta Mylavarapu , Bjorn Andersson , Konrad Dybcio Cc: Mukesh Kumar Savaliya , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260811-ipq5424_i2c_scl_updates-v1-0-bddcb2ceebda@oss.qualcomm.com> <20260811-ipq5424_i2c_scl_updates-v1-2-bddcb2ceebda@oss.qualcomm.com> <962122da-47cd-4325-9ced-ecbee2281580@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: <962122da-47cd-4325-9ced-ecbee2281580@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDEzMyBTYWx0ZWRfX7IDbvvNoPhte BQqSipHmEUCxrKOQKgEvIC4M8iGh+FNahIH8/cR1iNtwNx0BMUKJJ6+1r3d64Rm5fXmEzmm5ydD 1SlHWQ0Mpng+wFVTalVFe9d7fnCclEE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDEzMyBTYWx0ZWRfXyZzEDQ5jiAbY GRAfNFHE2vtqr0LmwV+1Dgf/MIHrY+cie7L2+vQvRBt5nx2rcCRy3ie7+vQr+AGqIenJqr91nsC Ql28wRZC7l/nVhqKlQZCg75baZCZf61LkK1pQzpqMn46poSoalBGB5U+yXjEJc25V3cy059eotP OvyjpS5JJXYYSxVznF1b60bXcHIZZAIm/PJL7vr3wyoKFPC751mynlFQi55EHUNIElCtdsN0RvT MXztUtNXp6LC4ct0HucLnu8/CkJvU14wLw6TspM6zpNuaIDHd5TJRShjlA8clVU7GPO360T3OyT oeTkSHl3XeuBWZvFYvwUitwGxZW2BM3+XVE5GLc7OlJUX/d/MkQWnfDn3on6ITUwNRBsIfwY4xq Lv+lIOl4Zvo5lxQTc9Ll9FctN4WRpKrWp1zw4CyqccYuDBAfAczxnwkHiHSskeZNapW9x0EQ+xA jBucccrGgtw+8PM0f5w== X-Proofpoint-GUID: e2B_x3GAeoPZGsEqEts2XVZoQiRMZZ9j X-Authority-Analysis: v=2.4 cv=CbA4Irrl c=1 sm=1 tr=0 ts=6a7b46d9 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=0/lRlipvHLU+ZVN6ZkkSUA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=vrlhrcIekUZfEXex-bwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: e2B_x3GAeoPZGsEqEts2XVZoQiRMZZ9j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-11_03,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608110133 On 8/11/2026 6:12 PM, Mukesh Savaliya wrote: > > > On 8/11/2026 2:53 PM, Kathiravan Thirumoorthy wrote: >> On IPQ5424, RTL-based I2C can be supported by both minicore and firmware >> based SEs. For firmware-based SEs, use different SCL settings as >> recommended by the design team. Introduce a separate table for the same. >> >> Identify whether the SE is minicore or firmware-based and select the > what is minicore ? Please Make it upstream specific, RTL hardened or > define minicore first. Ack. >> appropriate frequency table to achieve the desired bus frequencies. >> >> Move geni_i2c_clk_map_idx() from geni_i2c_resources_init() to >> geni_i2c_init() to ensure SE_HW_PARAM_2 is accessed only after the > Reasoning required - why only for 32 MHz ? OR better reasoning for > 32Mhz support related changes. Ack. >> required clocks have been enabled. >> > > I suggest to add 32Mhz support as this is already having 19.2MHz > support. Subject shows generic frequency support sounding like no > support present. Ack. > >> Signed-off-by: Kathiravan Thirumoorthy >> >> --- >>   drivers/i2c/busses/i2c-qcom-geni.c | 23 +++++++++++++++++------ >>   include/linux/soc/qcom/geni-se.h   |  1 + >>   2 files changed, 18 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c >> b/drivers/i2c/busses/i2c-qcom-geni.c >> index 00013b41a6f5..2f3026602c0c 100644 >> --- a/drivers/i2c/busses/i2c-qcom-geni.c >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >> @@ -194,12 +194,21 @@ static const struct geni_i2c_clk_fld >> geni_i2c_clk_map_32mhz[] = { > rename to _minicore ? Ack. >>       {} >>   }; >>   +static const struct geni_i2c_clk_fld >> geni_i2c_clk_map_32mhz_fwcore[] = { >> +    { I2C_MAX_STANDARD_MODE_FREQ, 12, 9, 10, 25 }, >> +    { I2C_MAX_FAST_MODE_FREQ, 4, 3, 9, 18 }, >> +    { I2C_MAX_FAST_MODE_PLUS_FREQ, 1, 6, 15, 29 }, >> +    {} >> +}; >> + >>   static int geni_i2c_clk_map_idx(struct geni_i2c_dev *gi2c) >>   { >>       const struct geni_i2c_clk_fld *itr; >> +    bool is_minicore = FIELD_GET(GEN_USE_MINICORES, >> +                     readl_relaxed(gi2c->se.base + SE_HW_PARAM_2)); >>         if (clk_get_rate(gi2c->se.clk) == 32 * HZ_PER_MHZ) >> -        itr = geni_i2c_clk_map_32mhz; >> +        itr = is_minicore ? geni_i2c_clk_map_32mhz : >> geni_i2c_clk_map_32mhz_fwcore; > _minicore with above table renamed. Ack. >>       else >>           itr = geni_i2c_clk_map_19p2mhz; >>   @@ -1046,6 +1055,13 @@ static int geni_i2c_init(struct geni_i2c_dev >> *gi2c) > [...]