diff for duplicates of <c5331cf8-7295-4e6a-ba39-e0751a2c357e@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 12e7b7f..2dc47a1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,12 +3,12 @@ On 01/05/2024 13:17, Jeremy Kerr wrote: > >>> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi >>> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi ->>> @@ -866,6 +866,13 @@ i2c: bus at 1e78a000 { ->>> ????????????????????????????????ranges = <0 0x1e78a000 0x1000>; ->>> ????????????????????????}; ->>> ? ->>> +???????????????????????i3c: bus at 1e7a0000 { ->>> +???????????????????????????????compatible = "simple-bus"; +>>> @@ -866,6 +866,13 @@ i2c: bus@1e78a000 { +>>> ranges = <0 0x1e78a000 0x1000>; +>>> }; +>>> +>>> + i3c: bus@1e7a0000 { +>>> + compatible = "simple-bus"; >> >> What bus is it? Why is it even needed? If it is i3c, then for sure >> compatible is wrong. @@ -19,24 +19,24 @@ On 01/05/2024 13:17, Jeremy Kerr wrote: > > This is following the existing design for the i2c controllers. > ->>> +???????????????????????????????#address-cells = <1>; ->>> +???????????????????????????????#size-cells = <1>; ->>> +???????????????????????????????ranges = <0 0x1e7a0000 0x8000>; ->>> +???????????????????????}; +>>> + #address-cells = <1>; +>>> + #size-cells = <1>; +>>> + ranges = <0 0x1e7a0000 0x8000>; +>>> + }; >>> + ->>> ????????????????????????fsim0: fsi at 1e79b000 { ->>> ????????????????????????????????compatible = "aspeed,ast2600-fsi-master", "fsi-master"; ->>> ????????????????????????????????reg = <0x1e79b000 0x94>; ->>> @@ -1125,3 +1132,89 @@ i2c15: i2c-bus at 800 { ->>> ????????????????status = "disabled"; ->>> ????????}; ->>> ?}; +>>> fsim0: fsi@1e79b000 { +>>> compatible = "aspeed,ast2600-fsi-master", "fsi-master"; +>>> reg = <0x1e79b000 0x94>; +>>> @@ -1125,3 +1132,89 @@ i2c15: i2c-bus@800 { +>>> status = "disabled"; +>>> }; +>>> }; >>> + >>> +&i3c { >> >> ???? >> ->> That's not how we construct DTS.? Overrides/extends of nodes are for +>> That's not how we construct DTS. Overrides/extends of nodes are for >> boards, not within DTSI. > > The overrides are occurring at the &i3cX labels, not &i3c. Platform diff --git a/a/content_digest b/N1/content_digest index 6e368f6..12b8189 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,9 +2,16 @@ "ref\065af46c3-e48f-4eae-8390-2bc01332ccbf@kernel.org\0" "ref\009ed10182e2282d7e408a4fef7994da010fe058e.camel@codeconstruct.com.au\0" "From\0Krzysztof Kozlowski <krzk@kernel.org>\0" - "Subject\0[PATCH] ARM: dts: aspeed-g6: Add nodes for i3c controllers\0" + "Subject\0Re: [PATCH] ARM: dts: aspeed-g6: Add nodes for i3c controllers\0" "Date\0Wed, 1 May 2024 18:45:43 +0200\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Jeremy Kerr <jk@codeconstruct.com.au>" + " linux-aspeed@lists.ozlabs.org\0" + "Cc\0devicetree@vger.kernel.org" + Andrew Jeffery <andrew@codeconstruct.com.au> + Joel Stanley <joel@jms.id.au> + Conor Dooley <conor+dt@kernel.org> + Rob Herring <robh+dt@kernel.org> + " Krzysztof Kozlowski <krzk+dt@kernel.org>\0" "\00:1\0" "b\0" "On 01/05/2024 13:17, Jeremy Kerr wrote:\n" @@ -12,12 +19,12 @@ "> \n" ">>> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" ">>> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n" - ">>> @@ -866,6 +866,13 @@ i2c: bus at 1e78a000 {\n" - ">>> ????????????????????????????????ranges = <0 0x1e78a000 0x1000>;\n" - ">>> ????????????????????????};\n" - ">>> ?\n" - ">>> +???????????????????????i3c: bus at 1e7a0000 {\n" - ">>> +???????????????????????????????compatible = \"simple-bus\";\n" + ">>> @@ -866,6 +866,13 @@ i2c: bus@1e78a000 {\n" + ">>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ranges = <0 0x1e78a000 0x1000>;\n" + ">>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" + ">>> \302\240\n" + ">>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240i3c: bus@1e7a0000 {\n" + ">>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"simple-bus\";\n" ">>\n" ">> What bus is it? Why is it even needed? If it is i3c, then for sure\n" ">> compatible is wrong.\n" @@ -28,24 +35,24 @@ "> \n" "> This is following the existing design for the i2c controllers.\n" "> \n" - ">>> +???????????????????????????????#address-cells = <1>;\n" - ">>> +???????????????????????????????#size-cells = <1>;\n" - ">>> +???????????????????????????????ranges = <0 0x1e7a0000 0x8000>;\n" - ">>> +???????????????????????};\n" + ">>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#address-cells = <1>;\n" + ">>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#size-cells = <1>;\n" + ">>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ranges = <0 0x1e7a0000 0x8000>;\n" + ">>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" ">>> +\n" - ">>> ????????????????????????fsim0: fsi at 1e79b000 {\n" - ">>> ????????????????????????????????compatible = \"aspeed,ast2600-fsi-master\", \"fsi-master\";\n" - ">>> ????????????????????????????????reg = <0x1e79b000 0x94>;\n" - ">>> @@ -1125,3 +1132,89 @@ i2c15: i2c-bus at 800 {\n" - ">>> ????????????????status = \"disabled\";\n" - ">>> ????????};\n" - ">>> ?};\n" + ">>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240fsim0: fsi@1e79b000 {\n" + ">>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"aspeed,ast2600-fsi-master\", \"fsi-master\";\n" + ">>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0x1e79b000 0x94>;\n" + ">>> @@ -1125,3 +1132,89 @@ i2c15: i2c-bus@800 {\n" + ">>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240status = \"disabled\";\n" + ">>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" + ">>> \302\240};\n" ">>> +\n" ">>> +&i3c {\n" ">>\n" ">> ????\n" ">>\n" - ">> That's not how we construct DTS.? Overrides/extends of nodes are for\n" + ">> That's not how we construct DTS.\302\240 Overrides/extends of nodes are for\n" ">> boards, not within DTSI.\n" "> \n" "> The overrides are occurring at the &i3cX labels, not &i3c. Platform\n" @@ -58,4 +65,4 @@ "Best regards,\n" Krzysztof -bdc73f85fad281fd6c44656718e7636691a7f45daa7c04a69ba4e9ee4fae0a69 +134656e9b8d7bcfc4fa6b187ca40a5ef9d13f8bd72113b042379c2b9eb0167e9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.