From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Date: Wed, 1 May 2024 18:45:43 +0200 Subject: [PATCH] ARM: dts: aspeed-g6: Add nodes for i3c controllers In-Reply-To: <09ed10182e2282d7e408a4fef7994da010fe058e.camel@codeconstruct.com.au> References: <20240501033832.1529340-1-jk@codeconstruct.com.au> <65af46c3-e48f-4eae-8390-2bc01332ccbf@kernel.org> <09ed10182e2282d7e408a4fef7994da010fe058e.camel@codeconstruct.com.au> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 01/05/2024 13:17, Jeremy Kerr wrote: > Hi Krzysztof, > >>> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi >>> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi >>> @@ -866,6 +866,13 @@ i2c: bus at 1e78a000 { >>> ????????????????????????????????ranges = <0 0x1e78a000 0x1000>; >>> ????????????????????????}; >>> ? >>> +???????????????????????i3c: bus at 1e7a0000 { >>> +???????????????????????????????compatible = "simple-bus"; >> >> What bus is it? Why is it even needed? If it is i3c, then for sure >> compatible is wrong. > > This is not the i3c bus, it's the MMIO mapping that allows us to specify > the individual i3c controller mappings as sensible offsets into the main > address space. Did you miss the ranges property there? > > This is following the existing design for the i2c controllers. > >>> +???????????????????????????????#address-cells = <1>; >>> +???????????????????????????????#size-cells = <1>; >>> +???????????????????????????????ranges = <0 0x1e7a0000 0x8000>; >>> +???????????????????????}; >>> + >>> ????????????????????????fsim0: fsi at 1e79b000 { >>> ????????????????????????????????compatible = "aspeed,ast2600-fsi-master", "fsi-master"; >>> ????????????????????????????????reg = <0x1e79b000 0x94>; >>> @@ -1125,3 +1132,89 @@ i2c15: i2c-bus at 800 { >>> ????????????????status = "disabled"; >>> ????????}; >>> ?}; >>> + >>> +&i3c { >> >> ???? >> >> That's not how we construct DTS.? Overrides/extends of nodes are for >> boards, not within DTSI. > > The overrides are occurring at the &i3cX labels, not &i3c. Platform > level dts just connect at those labels to define overrides for each bus: You miss the point. Look how DTS is constructed, read DTS coding style. Your first node is empty and that is not readable. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87712D52F for ; Wed, 1 May 2024 16:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714581949; cv=none; b=K8TCG0SEG6NfLjTxv8b4nFExVsAs+vuoxgh06m8CgnNMEd4ySREn7MxCYeAAc8ZAhmmCCutKEFNwW12j5elT5pRQjHSkDYc0JWWO2IwrNUQC088QRUeenvEek/V5Qj6eGCg/nYvjLgc9EIQg/rkHvi0ZME+NImcDnJNDiRKMFao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714581949; c=relaxed/simple; bh=tJDHpVVjDdwtBugmMlu+otKkhPryPFq5kjkW+kM16fo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X57gE7pkDZcZD9i2vghOufO+SPDcu9j+fzpCEpuhj7R7/Ged0Rg8XU+LkMYaQEOWciKeRCc+WMDOAPP32LbRPSYxAor89jZjqK+If2dDnlEVOQBKifWP5v++5MAft/Q8fdas27NwlgD9XP85pHZVI3oxmWn91tdY0qTis+8Q4sA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b8mrd9b0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b8mrd9b0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 555A3C072AA; Wed, 1 May 2024 16:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714581949; bh=tJDHpVVjDdwtBugmMlu+otKkhPryPFq5kjkW+kM16fo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=b8mrd9b0FP0chojwQ6F/OfJNV7JncPl/lRevy9iVD11urX53OO3oDudKfjpje9nBt yp8c0PRDmoF5u5sZbl+fPqrSU979ni0Mo4TntZZQu2XkDvzQiPabVCd2OY5NeU/vai yCyBmHrjvpiAXa9M9JePHyGYs8nwbUapFDAln6g7KAxsNldWTIOeDo3/0q8CBTOBG5 U3zNT6ni7SgT99dZhM4xkpimIgQVPB/L5svDQpJky89MtJaawFb7/4+XOKUgR9/T/t LB+kkGVI14x+XOxOeYcguk3gUgMm2/z0FaKkzWm3VroqrDSIxhz/2YyKJeJaxZp24O frX7+hzneyltw== Message-ID: Date: Wed, 1 May 2024 18:45:43 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: aspeed-g6: Add nodes for i3c controllers To: Jeremy Kerr , linux-aspeed@lists.ozlabs.org Cc: devicetree@vger.kernel.org, Andrew Jeffery , Joel Stanley , Conor Dooley , Rob Herring , Krzysztof Kozlowski References: <20240501033832.1529340-1-jk@codeconstruct.com.au> <65af46c3-e48f-4eae-8390-2bc01332ccbf@kernel.org> <09ed10182e2282d7e408a4fef7994da010fe058e.camel@codeconstruct.com.au> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <09ed10182e2282d7e408a4fef7994da010fe058e.camel@codeconstruct.com.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 01/05/2024 13:17, Jeremy Kerr wrote: > Hi Krzysztof, > >>> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi >>> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi >>> @@ -866,6 +866,13 @@ i2c: bus@1e78a000 { >>>                                 ranges = <0 0x1e78a000 0x1000>; >>>                         }; >>>   >>> +                       i3c: bus@1e7a0000 { >>> +                               compatible = "simple-bus"; >> >> What bus is it? Why is it even needed? If it is i3c, then for sure >> compatible is wrong. > > This is not the i3c bus, it's the MMIO mapping that allows us to specify > the individual i3c controller mappings as sensible offsets into the main > address space. Did you miss the ranges property there? > > This is following the existing design for the i2c controllers. > >>> +                               #address-cells = <1>; >>> +                               #size-cells = <1>; >>> +                               ranges = <0 0x1e7a0000 0x8000>; >>> +                       }; >>> + >>>                         fsim0: fsi@1e79b000 { >>>                                 compatible = "aspeed,ast2600-fsi-master", "fsi-master"; >>>                                 reg = <0x1e79b000 0x94>; >>> @@ -1125,3 +1132,89 @@ i2c15: i2c-bus@800 { >>>                 status = "disabled"; >>>         }; >>>  }; >>> + >>> +&i3c { >> >> ???? >> >> That's not how we construct DTS.  Overrides/extends of nodes are for >> boards, not within DTSI. > > The overrides are occurring at the &i3cX labels, not &i3c. Platform > level dts just connect at those labels to define overrides for each bus: You miss the point. Look how DTS is constructed, read DTS coding style. Your first node is empty and that is not readable. Best regards, Krzysztof