Re: [PATCH 1/2] vfs: introduce d_mark_tmpfile_name()

[Paulo Alcantara <pc@manguebit.org>]

Matthew Wilcox <willy@infradead.org> writes:

> On Sun, Apr 05, 2026 at 06:18:18PM -0300, Paulo Alcantara wrote:
>> +void d_mark_tmpfile_name(struct file *file, const struct qstr *name)
>> +{
>> +	struct dentry *dentry = file->f_path.dentry;
>> +	char *dname = dentry->d_shortname.string;
>> +
>> +	BUG_ON(dname_external(dentry) ||
>> +	       d_really_is_positive(dentry) ||
>> +	       !d_unlinked(dentry) ||
>> +	       name->len > DNAME_INLINE_LEN - 1);
>
> We tend to prefer each of these to be written out separately.  ie:
>
> 	BUG_ON(dname_external(dentry));
> 	BUG_ON(d_really_is_positive(dentry));
> ...
>
> That way if one triggers, we know which condition is violated.

Makes sense, thanks.  Will fix it in v2.