From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 978D2C02180 for ; Mon, 13 Jan 2025 15:42:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4F5110E6E5; Mon, 13 Jan 2025 15:42:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="BNqboy7d"; dkim-atps=neutral Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7061D10E6E5 for ; Mon, 13 Jan 2025 15:42:54 +0000 (UTC) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736782942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q+onY5bWJ3UEue2WR6kGb2y8tSjvnXFzhPBeSezdlb0=; b=BNqboy7dUqLPiEtmuCOiHGNuELeEfFbytP2xKd+JiAWjx6Ys+SZq2GQVEAF4LDFjzC844n +EkLYo5tCKwHUagkV34Rh2aMQdI5cU1vQptj3Nydnu2ZkFT3Iek2JIA435sDcucQiRR56c zO0xakgHYlb7ZI6Tr3o0TLx1abkkEDA= Date: Mon, 13 Jan 2025 21:12:02 +0530 MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Aradhya Bhatia Subject: Re: [PATCH v6 05/12] drm/bridge: cdns-dsi: Fix the clock variable for mode_valid() To: Dmitry Baryshkov Cc: Tomi Valkeinen , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nishanth Menon , Vignesh Raghavendra , Devarsh Thakkar , Praneeth Bajjuri , Udit Kumar , Jayesh Choudhary , DRI Development List , Linux Kernel List References: <20250111192738.308889-1-aradhya.bhatia@linux.dev> <20250111192738.308889-6-aradhya.bhatia@linux.dev> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/13/25 15:10, Dmitry Baryshkov wrote: > On Sun, Jan 12, 2025 at 12:57:31AM +0530, Aradhya Bhatia wrote: >> From: Aradhya Bhatia >> >> Allow the D-Phy config checks to use mode->clock instead of >> mode->crtc_clock during mode_valid checks, like everywhere else in the >> driver. > > Please describe why, not what. It is unclear why the rest of the code uses mode->crtc_* parameters at all during the non mode validation phase. But during that phase, the crtc_* parameters are not generated (duplicated in this case) from the regular ones, and so the validation fails. The patch prevents that from happening by streamlining with other instances. I will update the commit text with this. Regards Aradhya > >> >> Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") >> Reviewed-by: Tomi Valkeinen >> Signed-off-by: Aradhya Bhatia >> Signed-off-by: Aradhya Bhatia >> --- >> drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c >> index 3b3c45df1399..9c743fde2861 100644 >> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c >> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c >> @@ -568,13 +568,14 @@ static int cdns_dsi_check_conf(struct cdns_dsi *dsi, >> struct phy_configure_opts_mipi_dphy *phy_cfg = &output->phy_opts.mipi_dphy; >> unsigned long dsi_hss_hsa_hse_hbp; >> unsigned int nlanes = output->dev->lanes; >> + int mode_clock = (mode_valid_check ? mode->clock : mode->crtc_clock); >> int ret; >> >> ret = cdns_dsi_mode2cfg(dsi, mode, dsi_cfg, mode_valid_check); >> if (ret) >> return ret; >> >> - phy_mipi_dphy_get_default_config(mode->crtc_clock * 1000, >> + phy_mipi_dphy_get_default_config(mode_clock * 1000, >> mipi_dsi_pixel_format_to_bpp(output->dev->format), >> nlanes, phy_cfg); >> >> -- >> 2.34.1 >> >