From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/2] drm/i915: add debugfs interface to
	control rc6 and rps
Date: Tue, 29 Nov 2011 14:39:14 +0000
Message-ID: <c55c5d$185809@AZSMGA002.ch.intel.com>
References: <1322571305-1939-1-git-send-email-eugeni.dodonov@intel.com>
	<1322571305-1939-2-git-send-email-eugeni.dodonov@intel.com>
	<e0d58a$2dba7q@orsmga002.jf.intel.com>
	<20111129140843.GA5667@phenom.ffwll.local>
	<CAC7LmnsZUr-BZQvTestzL50rOta+kGMxTb6ipB0v3tiLdKx=Ug@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9D335A0BE1
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 29 Nov 2011 06:39:34 -0800 (PST)
In-Reply-To: <CAC7LmnsZUr-BZQvTestzL50rOta+kGMxTb6ipB0v3tiLdKx=Ug@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 29 Nov 2011 12:26:23 -0200, Eugeni Dodonov <eugeni@dodonov.net> wrote:
> For the perf counters, I thought on the following flow of execution with
> this patch:
> 1. prev_val=$(cat /sys/kernel/debug/dri/0/i915_enable_rc6)
> 2. echo 0 > /sys/kernel/debug/dri/0/i915_enable_rc6
> 3. do the perf counters aquisition and testing
> 4. echo $(prev_val) > /sys/kernel/debug/dri/0/i915_enable_rc6
> 
> Comments?

debugfs should never be ABI. Development and debug testing is one thing,
but if we are serious about this, we need to start building an acceptable
user interface elsewhere in /sys.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre