From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 12/43] drm/i915: don't trash the gtt when running out of fences Date: Wed, 14 Dec 2011 15:09:24 +0000 Message-ID: References: <1323867460-5486-1-git-send-email-daniel.vetter@ffwll.ch> <1323867460-5486-12-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D0D29E8AF for ; Wed, 14 Dec 2011 07:09:46 -0800 (PST) In-Reply-To: <1323867460-5486-12-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, 14 Dec 2011 13:57:09 +0100, Daniel Vetter wrote: > With the fence accounting fixed up in the previous commit not finding > enough fences is a fatal error and userspace bug. Trashing the entire > gtt is not gonna turn up that missing fence, so don't to this by > returning another error thatn ENOSPC. > > This has the added benefit that it's easier to distinguish fence > accounting errors from gtt space accounting issues. > > TTM serves as precendence for the EDEADLK error code - it returns it > when the reservation code needs resources already blocked by the > current reservation. > > Signed-Off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre