From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix up locking inconsistency around gem_do_init
Date: Thu, 26 Jan 2012 13:42:02 +0000 [thread overview]
Message-ID: <c55c5d$1pdepe@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1327574471-5677-1-git-send-email-daniel.vetter@ffwll.ch>
On Thu, 26 Jan 2012 11:41:11 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The locking in our setup and teardown paths is rather arbitrary, but
> generally we try to protect gem stuff with dev->struct_mutex. Further,
> the ums/gem ioctl to setup gem _does_ take the look. So fix up this
> benign inconsistency.
It is completely arbitrary and only exists to keep lockdep and various
BUG_ON(mutex_lock) happy. From your reading, we would have a lockdep
warning with ums/gem?
The extra little step towards consistency is likely to save a warning
later, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-01-26 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 10:41 [PATCH] drm/i915: fix up locking inconsistency around gem_do_init Daniel Vetter
2012-01-26 13:42 ` Chris Wilson [this message]
2012-01-26 13:45 ` Daniel Vetter
2012-02-13 19:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c55c5d$1pdepe@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.