From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fix up locking inconsistency around gem_do_init Date: Thu, 26 Jan 2012 13:42:02 +0000 Message-ID: References: <1327574471-5677-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B17BA0AFA for ; Thu, 26 Jan 2012 05:42:16 -0800 (PST) In-Reply-To: <1327574471-5677-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Thu, 26 Jan 2012 11:41:11 +0100, Daniel Vetter wrote: > The locking in our setup and teardown paths is rather arbitrary, but > generally we try to protect gem stuff with dev->struct_mutex. Further, > the ums/gem ioctl to setup gem _does_ take the look. So fix up this > benign inconsistency. It is completely arbitrary and only exists to keep lockdep and various BUG_ON(mutex_lock) happy. From your reading, we would have a lockdep warning with ums/gem? The extra little step towards consistency is likely to save a warning later, so Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre