From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: dump even more into the error_state Date: Sat, 04 Feb 2012 10:45:50 +0000 Message-ID: References: <1328131605-20174-1-git-send-email-daniel.vetter@ffwll.ch> <20120204022309.GA7236@snipes.kumite> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id AE5829E78F for ; Sat, 4 Feb 2012 02:45:54 -0800 (PST) In-Reply-To: <20120204022309.GA7236@snipes.kumite> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Fri, 3 Feb 2012 18:23:10 -0800, Ben Widawsky wrote: > On Wed, Feb 01, 2012 at 10:26:45PM +0100, Daniel Vetter wrote: > > Because the hangs always involved semaphores in one way or another, > > we've tried to dump the mbox registers, but couldn't find any > > inconsistencies. Still, dump them too. > > How about we only do this if semaphores are actually enabled? I think > that will eliminate potential confusion. I suggested that we add the module parameters to the error-state to aide, though even that is not fool proof as they could change between the driver doing an undefined op and it fouling up the GPU. Any sign of conflicting information inside the error-state is meant to be thought provoking. ;-) The idea is to dump as much information as we can about the errors and leave the complex art of interpretation up to userspace. -Chris -- Chris Wilson, Intel Open Source Technology Centre