From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/2] drm/i915: don't always force the
	panel's fixed_mode
Date: Wed, 08 Feb 2012 23:18:32 +0000
Message-ID: <c55c5d$1tk001@AZSMGA002.ch.intel.com>
References: <1328298501-24867-1-git-send-email-przanoni@gmail.com>
	<20120208225310.GF22687@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id DC8579E7EB
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  8 Feb 2012 15:18:41 -0800 (PST)
In-Reply-To: <20120208225310.GF22687@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>, Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 8 Feb 2012 23:53:10 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Feb 03, 2012 at 05:48:21PM -0200, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > 
> > My laptop has two 1440x900 modes: one is the fixed_mode and the other
> > has different timings. If I use xrandr to switch from the fixed mode to
> > the "other" 1440x900 mode, xrandr will tell me the change was
> > successful, but nothing was actually done: I'm still using the
> > fixed_mode. This patch allows us to use other modes if hdisplay and
> > vdisplay are the same.
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Hm, I've thought we should only use this to dynamically switch between a
> mode with high refresh rate and one with a low one.

I hesitated for the same reason. Except that by filtering out all modes
except for the one true mode, we prevent the user from being able to
make a choice. They'll invariably make the wrong choice and file a bug,
but nevertheless... ;-)

I also don't think this is the way we want to approach this. The overrides
required for fake LVDS headers would seem to be a superset of this
functionality.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre