From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: use semaphores for the display plane Date: Thu, 22 Mar 2012 16:18:54 +0000 Message-ID: References: <1332375553-7174-1-git-send-email-ben@bwidawsk.net> <1332375553-7174-3-git-send-email-ben@bwidawsk.net> <20120322090709.59f3f5f2@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id B4DCEA0DEB for ; Thu, 22 Mar 2012 09:18:58 -0700 (PDT) In-Reply-To: <20120322090709.59f3f5f2@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 22 Mar 2012 09:07:09 -0700, Ben Widawsky wrote: > On Thu, 22 Mar 2012 09:56:07 +0000 > Chris Wilson wrote: > > > On Wed, 21 Mar 2012 17:19:13 -0700, Ben Widawsky > > wrote: > > > * For the display plane, we want to be in the GTT but out of any > > > write > > > - * domains. So in many ways this looks like set_to_gtt_domain() > > > apart from the > > > - * ability to pipeline the waits, pinning and any additional > > > subtleties > > > - * that may differentiate the display plane from ordinary buffers. > > > + * domains. So in many ways this looks like set_to_gtt_domain(). > > ...apart from the whole pinning and pipelining. It looks less like > > set-to-gtt-domain over time. > > > > Not an improvement. I'll be the first to admit that it is not a great > > comment, but at least it does try to capture why we don't just treat > > the display plane as GTT. A better comment would explain our concept > > of display plane and pipelining. > > Separate patch though, don't you think? And it is now pipe-lining the > waits, so I'm confused why you don't think it's an improvement. Right. So how does removing the hint of why pin-to-display is different from set-to-gtt when it now performs said function help improve the comment? I completely agree that changing that comment is outside of the scope of this patch. -Chris -- Chris Wilson, Intel Open Source Technology Centre