From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/5] drm/i915: tracepoints for semaphores Date: Fri, 16 Sep 2011 09:37:41 +0100 Message-ID: References: <1316138941-6537-1-git-send-email-ben@bwidawsk.net> <1316138941-6537-6-git-send-email-ben@bwidawsk.net> <20110916075853.GB2873@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B46F9E74F for ; Fri, 16 Sep 2011 01:37:45 -0700 (PDT) In-Reply-To: <20110916075853.GB2873@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 16 Sep 2011 09:58:53 +0200, Daniel Vetter wrote: > We already have trace_i915_gem_request_add in i915_add_request which is > essentially giving out the same information (well, minus the hopefully > correct singal_mbox reg addresses). I think we can drop this one. I thought that as well, but then realised that a complete set of ring tracepoints would be useful independent of the request/object tracepoints. A couple of tracepoints on the gen6 paths is insufficients. ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre