From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/5] drm/i915: tracepoints for semaphores Date: Fri, 16 Sep 2011 10:45:34 +0100 Message-ID: References: <1316138941-6537-1-git-send-email-ben@bwidawsk.net> <1316138941-6537-6-git-send-email-ben@bwidawsk.net> <20110916075853.GB2873@phenom.ffwll.local> <20110916090729.GC2873@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id ED9ED9E734 for ; Fri, 16 Sep 2011 02:45:38 -0700 (PDT) In-Reply-To: <20110916090729.GC2873@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 16 Sep 2011 11:07:29 +0200, Daniel Vetter wrote: > On Fri, Sep 16, 2011 at 09:37:41AM +0100, Chris Wilson wrote: > > On Fri, 16 Sep 2011 09:58:53 +0200, Daniel Vetter wrote: > > > We already have trace_i915_gem_request_add in i915_add_request which is > > > essentially giving out the same information (well, minus the hopefully > > > correct singal_mbox reg addresses). I think we can drop this one. > > > > I thought that as well, but then realised that a complete set of ring > > tracepoints would be useful independent of the request/object > > tracepoints. > > > > A couple of tracepoints on the gen6 paths is insufficients. ;-) > > Well, I've quickly reviewed them and I think we're mostly covered. Many of > the tracepoints are called from generic code i915_gem.c right before/after > calling into the chipset-specific ringbuffer functions. It's just the difference of being able to watch only i915:intel_ring* to reduce the amount of noise if that is all you are interested in. And you don't have to remember the relationship between a particular i915_gem_request and its effect upon the ring. -Chris -- Chris Wilson, Intel Open Source Technology Centre