From: Vincent Mailhol <mailhol@kernel.org>
To: Ard Biesheuvel <ardb+git@google.com>, linux-efi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v3 0/9] efi/libstub: Avoid UTF-16 conversion busywork
Date: Thu, 17 Sep 2026 08:21:45 +0200 [thread overview]
Message-ID: <c55f8ca6-3b67-45da-b309-b1793407fc04@kernel.org> (raw)
In-Reply-To: <20260916144647.2651379-11-ardb+git@google.com>
On 16/09/2026 at 16:46, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> The EFI libstub performs some redundant conversions between UTF-16 and
> UTF-8 and back again, which includes dealing with surrogate pairs, which
> UEFI implementations themselves simply ignore.
>
> So drop all the homegrown code, and use the existing UCS-2 (== UTF-16
> without surrogate pairs) library code where conversion to UTF-8 is
> actually needed (the kernel command line).
>
> The remaining handling involves the EFI console, which supports wide
> characters natively, so just use those directly.
This v3 looks good to me and runs fine.
Patch 8 still uses spaces instead of tabulation for indentations. But,
notwithstanding of that and for the full series:
Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2026-09-17 6:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 14:46 [PATCH v3 0/9] efi/libstub: Avoid UTF-16 conversion busywork Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 1/9] lib/ucs2_string: Drop arbitrary input size limit and associated WARN() Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 2/9] lib/ucs2_string: Suppress modinfo when __DISABLE_EXPORTS is set Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 3/9] lib/ucs2_string: Split out ucs2_as_utf8_l() taking a separate limit Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 4/9] efi/libstub: Use ucs2_string library for UTF-16 to UTF-8 conversion Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 5/9] efi/libstub: Avoid efi_puts() for compile time constant strings Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 6/9] efi/libstub: Output UTF-16 directly from vsnprintf() Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 7/9] efi/libstub: Add support for printing human readable GUIDs Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 8/9] efi/libstub: Add efi_snprintf() to construct wide strings Ard Biesheuvel
2026-09-16 14:46 ` [PATCH v3 9/9] efi/libstub: add initial Boot Loader Interface support Ard Biesheuvel
2026-09-17 6:21 ` Vincent Mailhol [this message]
2026-09-17 9:37 ` [PATCH v3 0/9] efi/libstub: Avoid UTF-16 conversion busywork Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c55f8ca6-3b67-45da-b309-b1793407fc04@kernel.org \
--to=mailhol@kernel.org \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.