From: Edward Cree <ecree.xilinx@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Andrew Lunn <andrew@lunn.ch>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/5] netdevice: convert private flags > BIT(31) to bitfields
Date: Fri, 28 Jun 2024 17:03:10 +0100 [thread overview]
Message-ID: <c561738f-e28f-9231-af04-10937fac61da@gmail.com> (raw)
In-Reply-To: <20240627125541.3de68e1f@kernel.org>
On 27/06/2024 20:55, Jakub Kicinski wrote:
> On Thu, 27 Jun 2024 11:50:40 +0200 Alexander Lobakin wrote:
>>> I don't think we should group them indiscriminately. Better to add the
>>> asserts flag by flag. Neither of the flags you're breaking out in this
>>> patch are used on the fast path.
>>>
>>> Or is the problem that CACHELINE_ASSERT_GROUP_MEMBER doesn't work on
>>> bitfields?
>>
>> It generates sizeof(bitfield) which the compilers don't like and don't
>> want to compile ._.
>
> Mm. Okay, I have no better ideas then.
>
> Do consider moving the cold flags next to wol_enabled, tho?
My RSS series moves wol_enabled out to struct ethtool_netdev_state [1] so
this may not be worthwhile?
-ed
[1]: https://lore.kernel.org/netdev/293a562278371de7534ed1eb17531838ca090633.1719502239.git.ecree.xilinx@gmail.com/
next prev parent reply other threads:[~2024-06-28 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 11:44 [PATCH net-next 0/5] netdev_features: start cleaning netdev_features_t up Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 1/5] netdevice: convert private flags > BIT(31) to bitfields Alexander Lobakin
2024-06-26 14:51 ` Jakub Kicinski
2024-06-27 9:50 ` Alexander Lobakin
2024-06-27 19:55 ` Jakub Kicinski
2024-06-28 10:37 ` Alexander Lobakin
2024-06-28 16:03 ` Edward Cree [this message]
2024-06-29 1:59 ` Jakub Kicinski
2024-07-02 16:08 ` Edward Cree
2024-06-26 14:54 ` Jakub Kicinski
2024-06-27 9:48 ` Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 2/5] netdev_features: remove unused __UNUSED_NETIF_F_1 Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 3/5] netdev_features: convert NETIF_F_LLTX to dev->lltx Alexander Lobakin
2024-06-25 14:00 ` Eric Dumazet
2024-06-26 8:52 ` Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 4/5] netdev_features: convert NETIF_F_NETNS_LOCAL to dev->netns_local Alexander Lobakin
2024-06-25 11:44 ` [PATCH net-next 5/5] netdev_features: convert NETIF_F_FCOE_MTU to dev->fcoe_mtu Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c561738f-e28f-9231-af04-10937fac61da@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.