From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C46FC54E49 for ; Fri, 1 Mar 2024 13:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fr9CPwNOkjqNx6y3ZzGt9LHwAzOOMtgb75XFGZ0wck4=; b=ikwwxdtxEo+cdSNE+qJqyB76eo FyuCYXHlWupDUngcfYqgp9rMMvA7BF59JIFTxo9a6lbiiAVBxApPQpGpyD4Ujsz3GUotv256N0ImY iOfb7k5Zojvi1baEmNouPZRC1wjXW5Smj3rQhrCT0zAoPtxAwf7xA3wXO2CjjXeh1putp7eVixW9/ FuUqAeat7jk0sU7gd5Vu+7jhxcwOkTobFtzZKAE0Nur6WOK9Fxj5FdRVle391SsfMt5VrtyCun5HP 3rEkjjk7e8uvaSWYlG/kS2FZCdH2XpHkwRPUDInHo+6iA9knewbNAFqFOz9Xr6fHODDn0gP1zeSlK tAl2TmGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg33M-00000000Vtz-3b1V; Fri, 01 Mar 2024 13:35:56 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg2fN-00000000KTx-1DOr; Fri, 01 Mar 2024 13:11:20 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709298667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pARlF+NGAspV2QL6E9uhUMg1sZQdY7U/4Iec0zryMSA=; b=a3hs1+1fIzU53wCY3lb6T6qn4rGB+TdDENM0Zz7Be/qBbAACfIHP4/G+MvAgciRwK7jnCa JrFf0HAEWf2Y0PRr29nbKdW2/tADdqRbV0eFUsR+1A5q8/RKxw6BnH1oSeRQjSWD9zw4By sSSwOTAZ6N3C5dsvdn3v9hX+dQFQMBz1d9P+hk3uaQBaDKCmp0TCPZd/YjfAnNO8hlRMxQ QNW87CXgXDA17ZLl72ikMEOSOof0asGr/k6kv5y4fOy8PbSbPeAW5wTDD50IUOFUepfTN5 4Y4AZMaBTYkokM/WdBX37CJhBiW0zeqr1Cfd+DVre0H8VMRrsL7rpkdRtfBidw== Date: Fri, 01 Mar 2024 14:11:07 +0100 From: Dragan Simic To: wens@kernel.org Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_051118_696263_EB35DFD4 X-CRM114-Status: GOOD ( 27.12 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8gQ2hlbi1ZdSwKCk9uIDIwMjQtMDMtMDEgMTM6MDIsIENoZW4tWXUgVHNhaSB3cm90ZToK PiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDc6MTDigK9QTSBBbGV4ZXkgQ2hhcmtvdiA8YWxjaGFy a0BnbWFpbC5jb20+IAo+IHdyb3RlOgo+PiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDEyOjUy4oCv UE0gRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+IAo+PiB3cm90ZToKPj4gPiBPbiAy MDI0LTAzLTAxIDA5OjI1LCBBbGV4ZXkgQ2hhcmtvdiB3cm90ZToKPj4gPiA+IE9uIEZyaSwgTWFy IDEsIDIwMjQgYXQgOTo1MeKAr0FNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiB3 cm90ZToKPj4gPiBUaHVzLCB3aG8ga25vd3Mgd2hhdCBtaWdodCAob3IgbWlnaHQgbm90KSBnbyB3 cm9uZyBpZiB3ZSBkb24ndCByZXNldCB0aGUKPj4gPiBQTUlDIGF0IHRoZSBzYW1lIHRpbWUgd2hl biB0aGUgQ1JVIHJlc2V0cyB0aGUgU29DPyAgVW5mb3J0dW5hdGVseSwgdGhlCj4+ID4gdGhpbmdz IGFyZW4ndCB0aGF0IHN0cmFpZ2h0Zm9yd2FyZC4KPj4gPgo+PiA+IE9uIHRvcCBvZiB0aGF0LCBz b21lIGJvYXJkcywgc3VjaCBhcyB0aGUgUm9jayA1QiwgdXNlIGEgZmV3IGFkZGl0aW9uYWwKPj4g PiBkaXNjcmV0ZSB2b2x0YWdlIHJlZ3VsYXRvcnMgaW5zdGVhZCBvZiBhIG1hc3Rlci1zbGF2ZSBQ TUlDCj4+ID4gY29uZmlndXJhdGlvbiwKPj4gPiB3aGljaCBtYXkgYWN0dWFsbHkgaW50cm9kdWNl IHNvbWUgd2VpcmQgcG93ZXItcmVsYXRlZCBpc3N1ZXMsIHdoaWNoIGFsc28KPj4gPiBtYXkgYmUg aW50ZXJtaXR0ZW50LiAgQWN0dWFsbHksIEkndmUgYWxyZWFkeSBvdmVyaGVhcmQgdGhhdCB0aGUg Um9jayA1Qgo+PiA+IGV4cGVyaWVuY2VzIHNvbWUgaXNzdWVzIG9mIHRoYXQgbmF0dXJlLCBidXQg SSBkb24ndCBrbm93IHRoZSBkZXRhaWxzLgo+PiAKPj4gVGhvc2UgZGlzY3JldGUgcmVndWxhdG9y cyBzZWVtIHRvIGJlIG91dCBvZiBzY29wZSBvZiB0aGlzIGRpc2N1c3Npb24uCj4+IAo+PiBJIGFn cmVlIHRoYXQgYSBkZWVwZXIgcG93ZXItY3ljbGUgd2l0aCBwcm9wZXIgcG93ZXItdXAgc2VxdWVu Y2UgdG8KPj4gZm9sbG93IGl0IGlzIGJldHRlciB3aGVuIGl0J3MgYXZhaWxhYmxlIGluIHRoZSBy ZXNwZWN0aXZlIGhhcmR3YXJlLgo+PiBJJ20gYWxzbyBoYXBweSB0byBwcm92aWRlIGEgZm9sbG93 LXVwIHBhdGNoIHRvIHN3aXRjaCBmcm9tIENSVSB0byBQTUlDCj4+IHJlc2V0cyBmb3IgdGhlIGJv YXJkcyBJIGZvdW5kIHRvIHN1cHBvcnQgdGhlIGxhdHRlci4KPj4gCj4+IFRoZSBxdWVzdGlvbiB3 ZSBoYXZlIGF0IGhhbmQgaXMgc29sZWx5IGFib3V0IHRoZSBkZWZhdWx0IGJlaGF2aW9yIGZvcgo+ PiBhIGh5cG90aGV0aWNhbCBuZXcgYm9hcmQgd2l0aCBtaW5pbWFsIC5kdHMsIG9yIGFuIGV4aXN0 aW5nIGJvYXJkIHdoZXJlCj4+IHdlIGNhbid0IGRldGVybWluZSB0aGUgd2lyaW5nIG9mIHRoZSBU U0hVVCBzaWduYWw6Cj4+IE9wdGlvbiAxLiBMZXQgdGhlbSBzdGF5IG5pY2UgYW5kIHdhcm0gYXQg MTIwQysgdW5kZXIgbG9hZCwgYmVjYXVzZQo+PiB0aGV5IHNob3VsZCBoYXZlIGtub3duIGJldHRl ciBhbmQgc2hvdWxkIGhhdmUgZW5hYmxlZCB0aGUgVFNBREMgaW4KPj4gdGhlaXIgZGV2aWNlIHRy ZWUgYmVmb3JlIHB1dHRpbmcgdGhlIHN5c3RlbSB1bmRlciBsb2FkCj4+IE9wdGlvbiAyLiBHZXQg dGhlbSBwYXNzaXZlbHkgY29vbGVkIGF0IDg1QyB1bmRlciBsb2FkIGV2ZW4gd2l0aCBubwo+PiBo ZWF0c2luaywgdGhlbiBmb3JjZSBhIENSVSByZXNldCBvdXQgb2YgYWJ1bmRhbmNlIG9mIGNhdXRp b24gYXQgMTIwQwo+PiB1bmxlc3MgdGhleSBkZWZpbmVkIFBNSUMgcmVzZXQgaW4gdGhlaXIgZGV2 aWNlIHRyZWUKPj4gCj4+IEknbSBhZHZvY2F0aW5nIGZvciB0aGUgbGF0dGVyLgo+IAo+IEZXSVcs IHRoZSBDUlUgcmVzZXQgaXMgd2hhdCB0aGUga2VybmVsIHVzZXMgZm9yIHJlYm9vdGluZyB0aGUg c3lzdGVtLAo+IGVpdGhlciBkdXJpbmcgYSByZWJvb3Qgb3IgYSBrZXJuZWwgcGFuaWMuIFNvIGl0 IGlzIGFscmVhZHkgdXNlZCBmb3IgCj4gYm90aAo+IG5vcm1hbCBhbmQgYWJub3JtYWwgc2NlbmFy aW9zLiBBbmQgeWVzLCBpdCBzb21ldGltZXMgbGVhdmVzIHJlZ3VsYXRvcnMKPiBvciBvdGhlciBw YXJ0cyBvZiB0aGUgc3lzdGVtIGluIHNvbWUgd2VpcmQgc3RhdGUgdGhhdCB0aGUgQlJPTSBpc24n dAo+IGV4cGVjdGluZy4KCkFjY29yZGluZyB0byBkcml2ZXJzL21mZC9yazh4eC1jb3JlLmMsIHNv bWUgUE1JQ3MgKFJLODA5IGFuZCBSSzgxNywgdG8KYmUgcHJlY2lzZSkgYWxyZWFkeSBzdXBwb3J0 IHRha2luZyBvdmVyIHRoZSBib2FyZCByZXNldHMgd2hlbiBjb25maWd1cmVkCndpdGggInJvY2tj aGlwLHN5c3RlbS1wb3dlci1jb250cm9sbGVyIi4gIFBlcmhhcHMgd2Ugc2hvdWxkIGRvIHRoZSBz YW1lCndpdGggdGhlIFJLODA2LCB0byBhdm9pZCBhbnkgcG9zc2libGUgaXNzdWVzIHdpdGggQ1JV LWJhc2VkIGJvYXJkIApyZXNldHM7CkknbGwgc2VlIHRvIGludmVzdGlnYXRlIHRoYXQgZnVydGhl ci4KCk5vdCBhbGwgUm9ja2NoaXAgUE1JQ3MgKFJLODA4LCBmb3IgZXhhbXBsZSkgc3VwcG9ydCBz b2Z0d2FyZS1pbml0aWF0ZWQKcmVzZXRzLCB1bmZvcnR1bmF0ZWx5LiAgQWNjb3JkaW5nIHRvIHRo ZSBSSzgwNiBkYXRhc2hlZXQsIGl0IHNlZW1zIApjYXBhYmxlCm9mIHRoYXQ7ICBzZWUgcGFnZXMg MjcgYW5kIDI4IGluIHRoZSB2ZXJzaW9uIDEuMCBvZiB0aGUgZGF0YXNoZWV0LgoKPiBXaHkgc2hv dWxkIGEgaGFyZHdhcmUgdHJpZ2dlcmVkIHJlc2V0IGJlIGFueSBkaWZmZXJlbnQ/CgpBY2NvcmRp bmcgdG8gdGhlIFJLODA2IGRhdGFzaGVldCwgcmVzZXR0aW5nIHRocm91Z2ggUE1JQyhzKSBjYXVz ZXMgdGhlClBNSUMocykgdG8gY3V0IHRoZSBwb3dlciByYWlscyBpbiBhIGNvbnRyb2xsZWQgd2F5 LCBpLmUuIHdpdGggdGhlIApleHBlY3RlZApyYW1wLWRvd25zIGFuZCBzZXF1ZW5jaW5nLCBhbmQg dGhlIFNvQyB0aGVuIHdha2VzIHVwIGluIGEgc3RhdGUgb2YgdGhlCnJlZ3VsYXRvcnMgdGhhdCdz IGV4YWN0bHkgdGhlIHNhbWUgYXMgd2hlbiBpdCBnZXRzIHBvd2VyZWQgdXAgb24gY29sZCAKYm9v dC4KRG9pbmcgaXQgdGhhdCB3YXkgc2hvdWxkIGJlIGJldHRlci4KClRoZSByZXNldCBwcm9jZWR1 cmUgX3Nob3VsZF8gYmUgdmlydHVhbGx5IHRoZSBzYW1lIGZvciBhbGwgUm9ja2NoaXAgClBNSUNz LApidXQgcGxlYXNlIGRvbid0IHRha2UgbXkgd29yZCBvbiB0aGF0LiAgUmVzZXRzIGFyZSBkZXNj cmliZWQgcXVpdGUgCnBvb3JseQppbiBzb21lIFBNSUMgZGF0YXNoZWV0cy4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C61AC5478C for ; Fri, 1 Mar 2024 13:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p546AjP1u0WcOAj+0goOvZdhc9ZGZMJhLFAnoP2ID48=; b=Y7zjh2UehNXp18YBeciV5Pep7v NDKeU4YeYnkhF+ENz1wkg+HuXP4wYXM4cLlN5nAimAcwyu3PK53mOQ5b12pzfEcPVOzqvV8e4Ao/v L80HUPribNQhB7tR5M2H5rR/2IPoTDpdsM63Wz8BCAWSiMId1LKj4/od29ESiTGXBU1CR5zXXJIdn Dv0xkD+ptz+4C0liNV1E5YJEUIqooqATZwPjkcZ3dL7o09afPUAc89i01SCEN8SlBu3GdLY53q564 ycZtsXK3BdEPXNnkiI2BwjRk1M9L0iITqFwpcIcZe6GirkbIwwL4OnO4sigva/3hweaxihCU5Gk91 vg+eJfDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg33L-00000000Vsh-39Li; Fri, 01 Mar 2024 13:35:55 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg2fN-00000000KTx-1DOr; Fri, 01 Mar 2024 13:11:20 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709298667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pARlF+NGAspV2QL6E9uhUMg1sZQdY7U/4Iec0zryMSA=; b=a3hs1+1fIzU53wCY3lb6T6qn4rGB+TdDENM0Zz7Be/qBbAACfIHP4/G+MvAgciRwK7jnCa JrFf0HAEWf2Y0PRr29nbKdW2/tADdqRbV0eFUsR+1A5q8/RKxw6BnH1oSeRQjSWD9zw4By sSSwOTAZ6N3C5dsvdn3v9hX+dQFQMBz1d9P+hk3uaQBaDKCmp0TCPZd/YjfAnNO8hlRMxQ QNW87CXgXDA17ZLl72ikMEOSOof0asGr/k6kv5y4fOy8PbSbPeAW5wTDD50IUOFUepfTN5 4Y4AZMaBTYkokM/WdBX37CJhBiW0zeqr1Cfd+DVre0H8VMRrsL7rpkdRtfBidw== Date: Fri, 01 Mar 2024 14:11:07 +0100 From: Dragan Simic To: wens@kernel.org Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_051118_696263_EB35DFD4 X-CRM114-Status: GOOD ( 27.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gQ2hlbi1ZdSwKCk9uIDIwMjQtMDMtMDEgMTM6MDIsIENoZW4tWXUgVHNhaSB3cm90ZToK PiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDc6MTDigK9QTSBBbGV4ZXkgQ2hhcmtvdiA8YWxjaGFy a0BnbWFpbC5jb20+IAo+IHdyb3RlOgo+PiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDEyOjUy4oCv UE0gRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+IAo+PiB3cm90ZToKPj4gPiBPbiAy MDI0LTAzLTAxIDA5OjI1LCBBbGV4ZXkgQ2hhcmtvdiB3cm90ZToKPj4gPiA+IE9uIEZyaSwgTWFy IDEsIDIwMjQgYXQgOTo1MeKAr0FNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiB3 cm90ZToKPj4gPiBUaHVzLCB3aG8ga25vd3Mgd2hhdCBtaWdodCAob3IgbWlnaHQgbm90KSBnbyB3 cm9uZyBpZiB3ZSBkb24ndCByZXNldCB0aGUKPj4gPiBQTUlDIGF0IHRoZSBzYW1lIHRpbWUgd2hl biB0aGUgQ1JVIHJlc2V0cyB0aGUgU29DPyAgVW5mb3J0dW5hdGVseSwgdGhlCj4+ID4gdGhpbmdz IGFyZW4ndCB0aGF0IHN0cmFpZ2h0Zm9yd2FyZC4KPj4gPgo+PiA+IE9uIHRvcCBvZiB0aGF0LCBz b21lIGJvYXJkcywgc3VjaCBhcyB0aGUgUm9jayA1QiwgdXNlIGEgZmV3IGFkZGl0aW9uYWwKPj4g PiBkaXNjcmV0ZSB2b2x0YWdlIHJlZ3VsYXRvcnMgaW5zdGVhZCBvZiBhIG1hc3Rlci1zbGF2ZSBQ TUlDCj4+ID4gY29uZmlndXJhdGlvbiwKPj4gPiB3aGljaCBtYXkgYWN0dWFsbHkgaW50cm9kdWNl IHNvbWUgd2VpcmQgcG93ZXItcmVsYXRlZCBpc3N1ZXMsIHdoaWNoIGFsc28KPj4gPiBtYXkgYmUg aW50ZXJtaXR0ZW50LiAgQWN0dWFsbHksIEkndmUgYWxyZWFkeSBvdmVyaGVhcmQgdGhhdCB0aGUg Um9jayA1Qgo+PiA+IGV4cGVyaWVuY2VzIHNvbWUgaXNzdWVzIG9mIHRoYXQgbmF0dXJlLCBidXQg SSBkb24ndCBrbm93IHRoZSBkZXRhaWxzLgo+PiAKPj4gVGhvc2UgZGlzY3JldGUgcmVndWxhdG9y cyBzZWVtIHRvIGJlIG91dCBvZiBzY29wZSBvZiB0aGlzIGRpc2N1c3Npb24uCj4+IAo+PiBJIGFn cmVlIHRoYXQgYSBkZWVwZXIgcG93ZXItY3ljbGUgd2l0aCBwcm9wZXIgcG93ZXItdXAgc2VxdWVu Y2UgdG8KPj4gZm9sbG93IGl0IGlzIGJldHRlciB3aGVuIGl0J3MgYXZhaWxhYmxlIGluIHRoZSBy ZXNwZWN0aXZlIGhhcmR3YXJlLgo+PiBJJ20gYWxzbyBoYXBweSB0byBwcm92aWRlIGEgZm9sbG93 LXVwIHBhdGNoIHRvIHN3aXRjaCBmcm9tIENSVSB0byBQTUlDCj4+IHJlc2V0cyBmb3IgdGhlIGJv YXJkcyBJIGZvdW5kIHRvIHN1cHBvcnQgdGhlIGxhdHRlci4KPj4gCj4+IFRoZSBxdWVzdGlvbiB3 ZSBoYXZlIGF0IGhhbmQgaXMgc29sZWx5IGFib3V0IHRoZSBkZWZhdWx0IGJlaGF2aW9yIGZvcgo+ PiBhIGh5cG90aGV0aWNhbCBuZXcgYm9hcmQgd2l0aCBtaW5pbWFsIC5kdHMsIG9yIGFuIGV4aXN0 aW5nIGJvYXJkIHdoZXJlCj4+IHdlIGNhbid0IGRldGVybWluZSB0aGUgd2lyaW5nIG9mIHRoZSBU U0hVVCBzaWduYWw6Cj4+IE9wdGlvbiAxLiBMZXQgdGhlbSBzdGF5IG5pY2UgYW5kIHdhcm0gYXQg MTIwQysgdW5kZXIgbG9hZCwgYmVjYXVzZQo+PiB0aGV5IHNob3VsZCBoYXZlIGtub3duIGJldHRl ciBhbmQgc2hvdWxkIGhhdmUgZW5hYmxlZCB0aGUgVFNBREMgaW4KPj4gdGhlaXIgZGV2aWNlIHRy ZWUgYmVmb3JlIHB1dHRpbmcgdGhlIHN5c3RlbSB1bmRlciBsb2FkCj4+IE9wdGlvbiAyLiBHZXQg dGhlbSBwYXNzaXZlbHkgY29vbGVkIGF0IDg1QyB1bmRlciBsb2FkIGV2ZW4gd2l0aCBubwo+PiBo ZWF0c2luaywgdGhlbiBmb3JjZSBhIENSVSByZXNldCBvdXQgb2YgYWJ1bmRhbmNlIG9mIGNhdXRp b24gYXQgMTIwQwo+PiB1bmxlc3MgdGhleSBkZWZpbmVkIFBNSUMgcmVzZXQgaW4gdGhlaXIgZGV2 aWNlIHRyZWUKPj4gCj4+IEknbSBhZHZvY2F0aW5nIGZvciB0aGUgbGF0dGVyLgo+IAo+IEZXSVcs IHRoZSBDUlUgcmVzZXQgaXMgd2hhdCB0aGUga2VybmVsIHVzZXMgZm9yIHJlYm9vdGluZyB0aGUg c3lzdGVtLAo+IGVpdGhlciBkdXJpbmcgYSByZWJvb3Qgb3IgYSBrZXJuZWwgcGFuaWMuIFNvIGl0 IGlzIGFscmVhZHkgdXNlZCBmb3IgCj4gYm90aAo+IG5vcm1hbCBhbmQgYWJub3JtYWwgc2NlbmFy aW9zLiBBbmQgeWVzLCBpdCBzb21ldGltZXMgbGVhdmVzIHJlZ3VsYXRvcnMKPiBvciBvdGhlciBw YXJ0cyBvZiB0aGUgc3lzdGVtIGluIHNvbWUgd2VpcmQgc3RhdGUgdGhhdCB0aGUgQlJPTSBpc24n dAo+IGV4cGVjdGluZy4KCkFjY29yZGluZyB0byBkcml2ZXJzL21mZC9yazh4eC1jb3JlLmMsIHNv bWUgUE1JQ3MgKFJLODA5IGFuZCBSSzgxNywgdG8KYmUgcHJlY2lzZSkgYWxyZWFkeSBzdXBwb3J0 IHRha2luZyBvdmVyIHRoZSBib2FyZCByZXNldHMgd2hlbiBjb25maWd1cmVkCndpdGggInJvY2tj aGlwLHN5c3RlbS1wb3dlci1jb250cm9sbGVyIi4gIFBlcmhhcHMgd2Ugc2hvdWxkIGRvIHRoZSBz YW1lCndpdGggdGhlIFJLODA2LCB0byBhdm9pZCBhbnkgcG9zc2libGUgaXNzdWVzIHdpdGggQ1JV LWJhc2VkIGJvYXJkIApyZXNldHM7CkknbGwgc2VlIHRvIGludmVzdGlnYXRlIHRoYXQgZnVydGhl ci4KCk5vdCBhbGwgUm9ja2NoaXAgUE1JQ3MgKFJLODA4LCBmb3IgZXhhbXBsZSkgc3VwcG9ydCBz b2Z0d2FyZS1pbml0aWF0ZWQKcmVzZXRzLCB1bmZvcnR1bmF0ZWx5LiAgQWNjb3JkaW5nIHRvIHRo ZSBSSzgwNiBkYXRhc2hlZXQsIGl0IHNlZW1zIApjYXBhYmxlCm9mIHRoYXQ7ICBzZWUgcGFnZXMg MjcgYW5kIDI4IGluIHRoZSB2ZXJzaW9uIDEuMCBvZiB0aGUgZGF0YXNoZWV0LgoKPiBXaHkgc2hv dWxkIGEgaGFyZHdhcmUgdHJpZ2dlcmVkIHJlc2V0IGJlIGFueSBkaWZmZXJlbnQ/CgpBY2NvcmRp bmcgdG8gdGhlIFJLODA2IGRhdGFzaGVldCwgcmVzZXR0aW5nIHRocm91Z2ggUE1JQyhzKSBjYXVz ZXMgdGhlClBNSUMocykgdG8gY3V0IHRoZSBwb3dlciByYWlscyBpbiBhIGNvbnRyb2xsZWQgd2F5 LCBpLmUuIHdpdGggdGhlIApleHBlY3RlZApyYW1wLWRvd25zIGFuZCBzZXF1ZW5jaW5nLCBhbmQg dGhlIFNvQyB0aGVuIHdha2VzIHVwIGluIGEgc3RhdGUgb2YgdGhlCnJlZ3VsYXRvcnMgdGhhdCdz IGV4YWN0bHkgdGhlIHNhbWUgYXMgd2hlbiBpdCBnZXRzIHBvd2VyZWQgdXAgb24gY29sZCAKYm9v dC4KRG9pbmcgaXQgdGhhdCB3YXkgc2hvdWxkIGJlIGJldHRlci4KClRoZSByZXNldCBwcm9jZWR1 cmUgX3Nob3VsZF8gYmUgdmlydHVhbGx5IHRoZSBzYW1lIGZvciBhbGwgUm9ja2NoaXAgClBNSUNz LApidXQgcGxlYXNlIGRvbid0IHRha2UgbXkgd29yZCBvbiB0aGF0LiAgUmVzZXRzIGFyZSBkZXNj cmliZWQgcXVpdGUgCnBvb3JseQppbiBzb21lIFBNSUMgZGF0YXNoZWV0cy4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 944D640BE5; Fri, 1 Mar 2024 13:11:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298673; cv=none; b=dHd5AW//tn5waFxRpYUu4i7fSzIaK7YriN6OG5J78o1/BqxzmKZxMJ5CiwXsP+lCFA5+WlLb8gd7PF9T+o2vsDUy0fHztRbl6TDGZsLtF8dcyIcQaDF3VBBiXfJrXmVt9TguWvEBPjiikRs3rDmH8rrirgCXA/i09DpPy3ST0H4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298673; c=relaxed/simple; bh=2vqK4pQX7osqKFRNzAZNRnfWBu5U2CJo6jIYRgshkyk=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=Eik9VBtQpB+n/cVhpvgUf8wn9NtPK4C2cSNC8Bl0b87C5Qapk0NycNCzUv3ElYMBjFytfv5/7jizdCMOnfnJraD5ijmlfDF86eXPrdnuzru4n+aPw6ftSKuTQqwApFps62t6cVuWZRzuT58G9+NqaEkdsvj3/tXd/cWJ7d5iyeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=a3hs1+1f; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="a3hs1+1f" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709298667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pARlF+NGAspV2QL6E9uhUMg1sZQdY7U/4Iec0zryMSA=; b=a3hs1+1fIzU53wCY3lb6T6qn4rGB+TdDENM0Zz7Be/qBbAACfIHP4/G+MvAgciRwK7jnCa JrFf0HAEWf2Y0PRr29nbKdW2/tADdqRbV0eFUsR+1A5q8/RKxw6BnH1oSeRQjSWD9zw4By sSSwOTAZ6N3C5dsvdn3v9hX+dQFQMBz1d9P+hk3uaQBaDKCmp0TCPZd/YjfAnNO8hlRMxQ QNW87CXgXDA17ZLl72ikMEOSOof0asGr/k6kv5y4fOy8PbSbPeAW5wTDD50IUOFUepfTN5 4Y4AZMaBTYkokM/WdBX37CJhBiW0zeqr1Cfd+DVre0H8VMRrsL7rpkdRtfBidw== Date: Fri, 01 Mar 2024 14:11:07 +0100 From: Dragan Simic To: wens@kernel.org Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello Chen-Yu, On 2024-03-01 13:02, Chen-Yu Tsai wrote: > On Fri, Mar 1, 2024 at 7:10 PM Alexey Charkov > wrote: >> On Fri, Mar 1, 2024 at 12:52 PM Dragan Simic >> wrote: >> > On 2024-03-01 09:25, Alexey Charkov wrote: >> > > On Fri, Mar 1, 2024 at 9:51 AM Dragan Simic wrote: >> > Thus, who knows what might (or might not) go wrong if we don't reset the >> > PMIC at the same time when the CRU resets the SoC? Unfortunately, the >> > things aren't that straightforward. >> > >> > On top of that, some boards, such as the Rock 5B, use a few additional >> > discrete voltage regulators instead of a master-slave PMIC >> > configuration, >> > which may actually introduce some weird power-related issues, which also >> > may be intermittent. Actually, I've already overheard that the Rock 5B >> > experiences some issues of that nature, but I don't know the details. >> >> Those discrete regulators seem to be out of scope of this discussion. >> >> I agree that a deeper power-cycle with proper power-up sequence to >> follow it is better when it's available in the respective hardware. >> I'm also happy to provide a follow-up patch to switch from CRU to PMIC >> resets for the boards I found to support the latter. >> >> The question we have at hand is solely about the default behavior for >> a hypothetical new board with minimal .dts, or an existing board where >> we can't determine the wiring of the TSHUT signal: >> Option 1. Let them stay nice and warm at 120C+ under load, because >> they should have known better and should have enabled the TSADC in >> their device tree before putting the system under load >> Option 2. Get them passively cooled at 85C under load even with no >> heatsink, then force a CRU reset out of abundance of caution at 120C >> unless they defined PMIC reset in their device tree >> >> I'm advocating for the latter. > > FWIW, the CRU reset is what the kernel uses for rebooting the system, > either during a reboot or a kernel panic. So it is already used for > both > normal and abnormal scenarios. And yes, it sometimes leaves regulators > or other parts of the system in some weird state that the BROM isn't > expecting. According to drivers/mfd/rk8xx-core.c, some PMICs (RK809 and RK817, to be precise) already support taking over the board resets when configured with "rockchip,system-power-controller". Perhaps we should do the same with the RK806, to avoid any possible issues with CRU-based board resets; I'll see to investigate that further. Not all Rockchip PMICs (RK808, for example) support software-initiated resets, unfortunately. According to the RK806 datasheet, it seems capable of that; see pages 27 and 28 in the version 1.0 of the datasheet. > Why should a hardware triggered reset be any different? According to the RK806 datasheet, resetting through PMIC(s) causes the PMIC(s) to cut the power rails in a controlled way, i.e. with the expected ramp-downs and sequencing, and the SoC then wakes up in a state of the regulators that's exactly the same as when it gets powered up on cold boot. Doing it that way should be better. The reset procedure _should_ be virtually the same for all Rockchip PMICs, but please don't take my word on that. Resets are described quite poorly in some PMIC datasheets.