From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F1AC2D0B1 for ; Thu, 6 Feb 2020 07:29:37 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83CAE20720 for ; Thu, 6 Feb 2020 07:29:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="JsEQrrtB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="DD5VV24m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83CAE20720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1izbbU-0003J8-Bo; Thu, 06 Feb 2020 07:29:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1izbbS-0003J1-UE for linux-f2fs-devel@lists.sourceforge.net; Thu, 06 Feb 2020 07:29:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T3TmHsw9sQEqlRvQtVmDYQKIbJSMayuXpyURC4BIzr8=; b=JsEQrrtBrKGF1O8MtMgsaxJP15 FcHgE81rbKcyMFkVDL0mRSmOjr9dZnzJnHlsgwhz3Ob9Ys1rTlwCbNWgSzfzLKHSDg+KsY7UuVpWz +n0ZEqOc4gnoxo2pdgQWAe38QXLj28uembXAVGfuMJ9MO/vgLswwRUb/ha5PJ5SnMNoI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=T3TmHsw9sQEqlRvQtVmDYQKIbJSMayuXpyURC4BIzr8=; b=DD5VV24mG2qpowUuzoN/21uOQI x2VconAzvofWy0TqRnhfSfJlJgRXtDVY/pSeixR0D70X1uqpn/HObZH31/U4Z8SUeV146KhxkGb4L 0g3l9l4WYKA6zVGiYQXCJEHk1FzA0gSJXqsiOWUu4dpBauWoHsmXMVnNXr+U89+ktcHg=; Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtp (Exim 4.92.2) id 1izbZq-00122o-A6 for linux-f2fs-devel@lists.sourceforge.net; Thu, 06 Feb 2020 07:29:34 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AB7CA32F6C2CAFABF1A5; Thu, 6 Feb 2020 14:29:34 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Feb 2020 14:29:31 +0800 To: Matthew Wilcox References: <20200201150807.17820-1-willy@infradead.org> <20200203033903.GB8731@bombadil.infradead.org> <20200205030845.GP8731@bombadil.infradead.org> From: Chao Yu Message-ID: Date: Thu, 6 Feb 2020 14:29:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200205030845.GP8731@bombadil.infradead.org> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1izbZq-00122o-A6 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: Make f2fs_readpages readable again X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/2/5 11:08, Matthew Wilcox wrote: > On Wed, Feb 05, 2020 at 09:58:29AM +0800, Chao Yu wrote: >> On 2020/2/3 11:39, Matthew Wilcox wrote: >>> >>> Remove the horrendous ifdeffery by slipping an IS_ENABLED into >>> f2fs_compressed_file(). >> >> I'd like to suggest to use >> >> if (IS_ENABLED(CONFIG_F2FS_FS_COMPRESSION) && f2fs_compressed_file(inode)) >> >> here to clean up f2fs_readpages' codes. >> >> Otherwise, f2fs module w/o compression support will not recognize compressed >> file in most other cases if we add IS_ENABLED() condition into >> f2fs_compressed_file(). > > If we need to recognise them in order to deny access to them, then I > suppose we need two predicates. Perhaps: Yup, for compression feature, now we use f2fs_is_compress_backend_ready() to check whether current kernel can support to handle compressed file. For the purpose of cleanup, I guess below change should be enough... >> if (IS_ENABLED(CONFIG_F2FS_FS_COMPRESSION) && f2fs_compressed_file(inode)) Thanks, > > f2fs_unsupported_attributes(inode) > and > f2fs_compressed_file(inode) > > where f2fs_unsupported_attributes can NACK any set flag (including those > which don't exist yet), eg encrypted. That seems like a larger change > than I should be making, since I'm not really familiar with f2fs code. > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8577EC2D0B1 for ; Thu, 6 Feb 2020 06:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 597A320838 for ; Thu, 6 Feb 2020 06:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727798AbgBFG3i (ORCPT ); Thu, 6 Feb 2020 01:29:38 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:45846 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725809AbgBFG3h (ORCPT ); Thu, 6 Feb 2020 01:29:37 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AB7CA32F6C2CAFABF1A5; Thu, 6 Feb 2020 14:29:34 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Feb 2020 14:29:31 +0800 Subject: Re: [PATCH v2] f2fs: Make f2fs_readpages readable again To: Matthew Wilcox CC: Jaegeuk Kim , Chao Yu , , References: <20200201150807.17820-1-willy@infradead.org> <20200203033903.GB8731@bombadil.infradead.org> <20200205030845.GP8731@bombadil.infradead.org> From: Chao Yu Message-ID: Date: Thu, 6 Feb 2020 14:29:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200205030845.GP8731@bombadil.infradead.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2020/2/5 11:08, Matthew Wilcox wrote: > On Wed, Feb 05, 2020 at 09:58:29AM +0800, Chao Yu wrote: >> On 2020/2/3 11:39, Matthew Wilcox wrote: >>> >>> Remove the horrendous ifdeffery by slipping an IS_ENABLED into >>> f2fs_compressed_file(). >> >> I'd like to suggest to use >> >> if (IS_ENABLED(CONFIG_F2FS_FS_COMPRESSION) && f2fs_compressed_file(inode)) >> >> here to clean up f2fs_readpages' codes. >> >> Otherwise, f2fs module w/o compression support will not recognize compressed >> file in most other cases if we add IS_ENABLED() condition into >> f2fs_compressed_file(). > > If we need to recognise them in order to deny access to them, then I > suppose we need two predicates. Perhaps: Yup, for compression feature, now we use f2fs_is_compress_backend_ready() to check whether current kernel can support to handle compressed file. For the purpose of cleanup, I guess below change should be enough... >> if (IS_ENABLED(CONFIG_F2FS_FS_COMPRESSION) && f2fs_compressed_file(inode)) Thanks, > > f2fs_unsupported_attributes(inode) > and > f2fs_compressed_file(inode) > > where f2fs_unsupported_attributes can NACK any set flag (including those > which don't exist yet), eg encrypted. That seems like a larger change > than I should be making, since I'm not really familiar with f2fs code. > . >