From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62881C3A5A6 for ; Sat, 31 Aug 2019 17:07:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E9C022D37 for ; Sat, 31 Aug 2019 17:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728189AbfHaRHl (ORCPT ); Sat, 31 Aug 2019 13:07:41 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:44855 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728119AbfHaRHl (ORCPT ); Sat, 31 Aug 2019 13:07:41 -0400 Received: by mail-ed1-f66.google.com with SMTP id a21so11559656edt.11; Sat, 31 Aug 2019 10:07:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Lik2TQFtm24ZeMK7lbOS3RM+iMDhKtG/DlU1Hn/vZvk=; b=IzJRNCSwoQaaawnqH5JdQhmrYzO19Ll6eYto0R1OjvO+dLU0rqEfq9SHnOBHM4ZJmd PZVOH6es77IXwL9eQS9AS45/VuyjnKGEcSuFCpbTWMU8OqPgXZSrUdAN0ze+MSfUGe4h UD8jfnSbkTUK+oALMnqQff0HvXr9w5bYf0Q4aBZH4x6D+BojR3LeEtdPFbQphnskvAPR RFjb49+o+9L+N1BF6gyKlTMlODxDbg77UnIEdTQnUwbFJWTp1jkHJZG1h49eX8qgICpJ Lnk+zEtSzCNjLeOlun606LVo6Zj4C/hyVR096kFtvgw5ptdfD+ph+r2roCxu+wTA4qLE IQ4A== X-Gm-Message-State: APjAAAWnzPTprPpd4yAextydYr/KFliZwBLSAjicJFr7z5c+QVebLtpV W5aUKwVNipYyFRQKWJQSdsE= X-Google-Smtp-Source: APXvYqwYiVn+T/jnXqHdTksQFpnl6eq02sfkOXYISHWm5GobK2D0xg22AxYic/zL89Sp0zVPu8fsxw== X-Received: by 2002:a50:88c5:: with SMTP id d63mr21674654edd.122.1567271258673; Sat, 31 Aug 2019 10:07:38 -0700 (PDT) Received: from [10.68.32.192] (broadband-188-32-48-208.ip.moscow.rt.ru. [188.32.48.208]) by smtp.gmail.com with ESMTPSA id i23sm1739594edv.11.2019.08.31.10.07.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2019 10:07:38 -0700 (PDT) Subject: Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls To: Markus Elfring , Joe Perches Cc: Andrew Morton , Anton Altaparmakov , Andy Whitcroft , Boris Ostrovsky , Boris Pismenny , "Darrick J. Wong" , "David S. Miller" , Dennis Dalessandro , Dmitry Torokhov , dri-devel@lists.freedesktop.org, Inaky Perez-Gonzalez , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Leon Romanovsky , linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-rdma@vger.kernel.org, linux-wimax@intel.com, linux-xfs@vger.kernel.org, Mike Marciniszyn , netdev@vger.kernel.org, =?UTF-8?Q?Pali_Roh=c3=a1r?= , Rob Clark , Saeed Mahameed , Sean Paul , Alexander Viro , xen-devel@lists.xenproject.org, Enrico Weigelt References: <20190829165025.15750-1-efremov@linux.com> <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> <689c8baf-2298-f086-3461-5cd1cdd191c6@linux.com> <493a7377-2de9-1d44-cd8f-c658793d15db@web.de> From: Denis Efremov Message-ID: Date: Sat, 31 Aug 2019 20:07:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <493a7377-2de9-1d44-cd8f-c658793d15db@web.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 31.08.2019 19:45, Markus Elfring wrote: >>>> +# nested likely/unlikely calls >>>> +        if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { >>>> +            WARN("LIKELY_MISUSE", >>> >>> How do you think about to use the specification “(?:IS_ERR(?:_(?:OR_NULL|VALUE))?|WARN)” >>> in this regular expression? > … >> IS_ERR >> (?:_ <- Another atomic group just to show that '_' is a common prefix? > > Yes. - I hope that this specification detail can help a bit. I'm not sure that another pair of brackets for a single char worth it. >> Usually, Perl interpreter is very good at optimizing such things. The interpreter optimizes it internally: echo 'IS_ERR_OR_NULL' | perl -Mre=debug -ne '/IS_ERR(?:_OR_NULL|_VALUE)?/ && print' Compiling REx "IS_ERR(?:_OR_NULL|_VALUE)?" Final program: 1: EXACT (4) 4: CURLYX[0]{0,1} (16) 6: EXACT <_> (8) <-- common prefix 8: TRIE-EXACT[OV] (15) ... > > Would you like to help this software component by omitting a pair of > non-capturing parentheses at the beginning? > > \b(?:un)?likely\s* This pair of brackets is required to match "unlikely" and it's optional in order to match "likely". Regards, Denis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Efremov Subject: Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Date: Sat, 31 Aug 2019 20:07:34 +0300 Message-ID: References: <20190829165025.15750-1-efremov@linux.com> <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> <689c8baf-2298-f086-3461-5cd1cdd191c6@linux.com> <493a7377-2de9-1d44-cd8f-c658793d15db@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <493a7377-2de9-1d44-cd8f-c658793d15db@web.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Markus Elfring , Joe Perches Cc: Andrew Morton , Anton Altaparmakov , Andy Whitcroft , Boris Ostrovsky , Boris Pismenny , "Darrick J. Wong" , "David S. Miller" , Dennis Dalessandro , Dmitry Torokhov , dri-devel@lists.freedesktop.org, Inaky Perez-Gonzalez , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Leon Romanovsky , linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-rdma@vger.kernel.org, linux-wimax@intel.com List-Id: linux-input@vger.kernel.org On 31.08.2019 19:45, Markus Elfring wrote: >>>> +# nested likely/unlikely calls >>>> +        if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { >>>> +            WARN("LIKELY_MISUSE", >>> >>> How do you think about to use the specification “(?:IS_ERR(?:_(?:OR_NULL|VALUE))?|WARN)” >>> in this regular expression? > … >> IS_ERR >> (?:_ <- Another atomic group just to show that '_' is a common prefix? > > Yes. - I hope that this specification detail can help a bit. I'm not sure that another pair of brackets for a single char worth it. >> Usually, Perl interpreter is very good at optimizing such things. The interpreter optimizes it internally: echo 'IS_ERR_OR_NULL' | perl -Mre=debug -ne '/IS_ERR(?:_OR_NULL|_VALUE)?/ && print' Compiling REx "IS_ERR(?:_OR_NULL|_VALUE)?" Final program: 1: EXACT (4) 4: CURLYX[0]{0,1} (16) 6: EXACT <_> (8) <-- common prefix 8: TRIE-EXACT[OV] (15) ... > > Would you like to help this software component by omitting a pair of > non-capturing parentheses at the beginning? > > \b(?:un)?likely\s* This pair of brackets is required to match "unlikely" and it's optional in order to match "likely". Regards, Denis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E19C3A5A6 for ; Sat, 31 Aug 2019 17:08:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC0BC22D37 for ; Sat, 31 Aug 2019 17:08:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC0BC22D37 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i46qj-0007C0-Pz; Sat, 31 Aug 2019 17:07:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i46qi-0007BG-MI for xen-devel@lists.xenproject.org; Sat, 31 Aug 2019 17:07:40 +0000 X-Inumbo-ID: d61e04e8-cc11-11e9-8980-bc764e2007e4 Received: from mail-ed1-f66.google.com (unknown [209.85.208.66]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d61e04e8-cc11-11e9-8980-bc764e2007e4; Sat, 31 Aug 2019 17:07:39 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id t50so11617078edd.2 for ; Sat, 31 Aug 2019 10:07:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Lik2TQFtm24ZeMK7lbOS3RM+iMDhKtG/DlU1Hn/vZvk=; b=JmhuDntiBP1815tnHmoZAXLXMaABpiC0Iq2fIeug/kWDAbMU0YNX17O3i4kQuJZDzC zPN+n922PF5WTsLCm7GGqv7+GnewbRsBMtXx6vqp8NYwAZ/F3VzpvOK3m/nNla8GTasx fc6cPphy8IyGck87mELz5n3xzb98GcRtR2U7UtX2v59F/jvwOd15xDicycg5PFKBE+Za Vk6LPuwU7kae4aAE8gSAN2oS0V4L/33uJU2w0P5R3A5nKnHmPsmzVcwfapoxlyQlxfOq A9pXYKzz7a1P+NfnkatzXv1+6AcFnJQfSNvQ9/cVI0TFl9Ro0p2JqDPym7mSALBHsHyn botQ== X-Gm-Message-State: APjAAAX01/EWy84vD+P7H8lIiNLoEHc/wab2XUmCj/uwt6LPnJuO0d5b DseLCqrEbfNhePrSXPSPBd0= X-Google-Smtp-Source: APXvYqwYiVn+T/jnXqHdTksQFpnl6eq02sfkOXYISHWm5GobK2D0xg22AxYic/zL89Sp0zVPu8fsxw== X-Received: by 2002:a50:88c5:: with SMTP id d63mr21674654edd.122.1567271258673; Sat, 31 Aug 2019 10:07:38 -0700 (PDT) Received: from [10.68.32.192] (broadband-188-32-48-208.ip.moscow.rt.ru. [188.32.48.208]) by smtp.gmail.com with ESMTPSA id i23sm1739594edv.11.2019.08.31.10.07.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2019 10:07:38 -0700 (PDT) To: Markus Elfring , Joe Perches References: <20190829165025.15750-1-efremov@linux.com> <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> <689c8baf-2298-f086-3461-5cd1cdd191c6@linux.com> <493a7377-2de9-1d44-cd8f-c658793d15db@web.de> From: Denis Efremov Message-ID: Date: Sat, 31 Aug 2019 20:07:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <493a7377-2de9-1d44-cd8f-c658793d15db@web.de> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Leon Romanovsky , "Darrick J. Wong" , linux-rdma@vger.kernel.org, Inaky Perez-Gonzalez , Saeed Mahameed , linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, Boris Pismenny , linux-arm-msm@vger.kernel.org, linux-wimax@intel.com, Enrico Weigelt , Alexander Viro , Andy Whitcroft , Boris Ostrovsky , Sean Paul , Anton Altaparmakov , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Mike Marciniszyn , linux-ntfs-dev@lists.sourceforge.net, netdev@vger.kernel.org, Dennis Dalessandro , Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, Rob Clark , =?UTF-8?Q?Pali_Roh=c3=a1r?= , linux-fsdevel@vger.kernel.org, Andrew Morton , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" CgpPbiAzMS4wOC4yMDE5IDE5OjQ1LCBNYXJrdXMgRWxmcmluZyB3cm90ZToKPj4+PiArIyBuZXN0 ZWQgbGlrZWx5L3VubGlrZWx5IGNhbGxzCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICgkbGluZSA9 fiAvXGIoPzooPzp1bik/bGlrZWx5KVxzKlwoXHMqIT9ccyooSVNfRVJSKD86X09SX05VTEx8X1ZB TFVFKT98V0FSTikvKSB7Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgV0FSTigiTElLRUxZ X01JU1VTRSIsCj4+Pgo+Pj4gSG93IGRvIHlvdSB0aGluayBhYm91dCB0byB1c2UgdGhlIHNwZWNp ZmljYXRpb24g4oCcKD86SVNfRVJSKD86Xyg/Ok9SX05VTEx8VkFMVUUpKT98V0FSTinigJ0KPj4+ IGluIHRoaXMgcmVndWxhciBleHByZXNzaW9uPwo+IOKApgo+PiAgICBJU19FUlIKPj4gICAgKD86 XyA8LSBBbm90aGVyIGF0b21pYyBncm91cCBqdXN0IHRvIHNob3cgdGhhdCAnXycgaXMgYSBjb21t b24gcHJlZml4Pwo+IAo+IFllcy4gLSBJIGhvcGUgdGhhdCB0aGlzIHNwZWNpZmljYXRpb24gZGV0 YWlsIGNhbiBoZWxwIGEgYml0LgoKSSdtIG5vdCBzdXJlIHRoYXQgYW5vdGhlciBwYWlyIG9mIGJy YWNrZXRzIGZvciBhIHNpbmdsZSBjaGFyIHdvcnRoIGl0LgoKPj4gICAgICAgICAgICBVc3VhbGx5 LCBQZXJsIGludGVycHJldGVyIGlzIHZlcnkgZ29vZCBhdCBvcHRpbWl6aW5nIHN1Y2ggdGhpbmdz LgoKVGhlIGludGVycHJldGVyIG9wdGltaXplcyBpdCBpbnRlcm5hbGx5OgplY2hvICdJU19FUlJf T1JfTlVMTCcgfCBwZXJsIC1NcmU9ZGVidWcgLW5lICcvSVNfRVJSKD86X09SX05VTEx8X1ZBTFVF KT8vICYmIHByaW50JwpDb21waWxpbmcgUkV4ICJJU19FUlIoPzpfT1JfTlVMTHxfVkFMVUUpPyIK RmluYWwgcHJvZ3JhbToKICAgMTogRVhBQ1QgPElTX0VSUj4gKDQpCiAgIDQ6IENVUkxZWFswXXsw LDF9ICgxNikKICAgNjogICBFWEFDVCA8Xz4gKDgpICAgICAgPC0tIGNvbW1vbiBwcmVmaXgKICAg ODogICBUUklFLUVYQUNUW09WXSAoMTUpCiAgICAgICAgPE9SX05VTEw+IAogICAgICAgIDxWQUxV RT4KLi4uCj4gCj4gV291bGQgeW91IGxpa2UgdG8gaGVscCB0aGlzIHNvZnR3YXJlIGNvbXBvbmVu dCBieSBvbWl0dGluZyBhIHBhaXIgb2YKPiBub24tY2FwdHVyaW5nIHBhcmVudGhlc2VzIGF0IHRo ZSBiZWdpbm5pbmc/Cj4gCj4gXGIoPzp1bik/bGlrZWx5XHMqCgpUaGlzIHBhaXIgb2YgYnJhY2tl dHMgaXMgcmVxdWlyZWQgdG8gbWF0Y2ggInVubGlrZWx5IiBhbmQgaXQncwpvcHRpb25hbCBpbiBv cmRlciB0byBtYXRjaCAibGlrZWx5Ii4KClJlZ2FyZHMsCkRlbmlzCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs